GitHub user daserge opened a pull request:
https://github.com/apache/cordova-labs/pull/8
CB-51 API: FileTransfer - Support PUT Method
Replaces tabs with whitespaces
[Jira issue](https://issues.apache.org/jira/browse/CB-51)
You can merge this pull request into a Git
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/109
CB-51 API: FileTransfer - Support PUT Method
Adds support for Windows platform
[Jira issue](https://issues.apache.org/jira/browse/CB-51)
You can merge this pull
The vote has failed. The results are:
Positive Binding Votes: 1
Vladimir Kotikov
Negative Binding Votes: 1
Steven Gill
-
Best regards, Vladimir
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, October 27, 2015 2:16 AM
To: dev@cordova.apache.org
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/331
CB-9890 Documenting cordova-common
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9890
Alternatively
This is fixed in
https://github.com/apache/cordova-android/commit/78fa7374d97ad9ed85c5c857a77a8f3830d600f9.
However tests are still failing locally, but this seems to be a problem with
tests, not LIB/Android. Alex Sorokin is looking into this.
-
Best regards, Vladimir
-Original
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/108
CB-51 API: FileTransfer - Support PUT Method
Adds a test for upload via PUT method
[Jira issue](https://issues.apache.org/jira/browse/CB-51)
You can merge this pull
The vote has failed. I'll bump version to 1.0.0 and start a new vote once the
documentation for module will be added/updated.
Steve, Carlos, could you please review cordova-common documentation draft here:
https://github.com/apache/cordova-lib/pull/331
-
Best regards, Vladimir.
GitHub user simpsond opened a pull request:
https://github.com/apache/cordova-docs/pull/406
Correct example of AppendUserAgent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simpsond/cordova-docs patch-1
Alternatively you can
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-lib/pull/332
CB-9872 Fixed save.spec.11 failure
This is a fix for https://issues.apache.org/jira/browse/CB-9872
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user jerem opened a pull request:
https://github.com/apache/cordova-windows/pull/131
Fixed a typo.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerem/cordova-windows patch-1
Alternatively you can review and apply
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/143
CB-9887 cordova.file.* paths for windows platform
Update the plugin to define cordova.file.* paths for windows platform as
appropriate.
Documentation updated to show where to
Github user Krishnarajd commented on the pull request:
https://github.com/apache/cordova-docs/pull/389#issuecomment-151739838
Hi @dblotsky
We have not able to commit a image directly using browser so we have
submitted image in the previous update. Could you let me know is
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-ios/pull/175#issuecomment-151753738
@shazron, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/235
CB-9880 Fixes platform update failure when upgrading from android@<4.1.0
JIRA issue: [CB-9880](https://issues.apache.org/jira/browse/CB-9880)
You can merge this pull request into
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Done.
On Wed, Oct 28, 2015 at 9:34 AM, Jesse wrote:
> Yes, fixing now. Thanks.
>
>
> My team is hiring!
> @purplecabbage
> risingj.com
>
> On Wed, Oct 28, 2015 at 9:32 AM, Nikhil Khandelwal > wrote:
>
>> It seems to be caused by this commit:
Yes, fixing now. Thanks.
My team is hiring!
@purplecabbage
risingj.com
On Wed, Oct 28, 2015 at 9:32 AM, Nikhil Khandelwal
wrote:
> It seems to be caused by this commit:
>
It seems to be caused by this commit:
https://github.com/apache/cordova-plugin-device-motion/commit/90ef274ea8cae2a5639d148b769f7718f33b7134
-Nikhil
-Original Message-
From: Dmitry Blotsky [mailto:dblot...@microsoft.com]
Sent: Tuesday, October 27, 2015 9:24 PM
To:
We do the version bump on plugins at release time when we review the
changelogs. No need to do that before that step in the process.
On Tue, Oct 27, 2015 at 6:10 PM, Joe Bowser wrote:
> Sorry, none of them have gotten their major version bump yet. I'll be
> bumping them
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/332#discussion_r43292467
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -244,19 +307,26 @@ describe('(save flag)', function () {
console.log(err);
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-151918673
So Alex - what was the underlying problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/333#issuecomment-151920060
Yep, saw that PR just after I sent this one :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/333
Dummy PR to trigger a test run - don't merge :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib tb-temp
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/333#issuecomment-151917387
@timbarham, I think we need to merge
https://github.com/apache/cordova-lib/pull/332 first to get green badges -
apart from android issue there are some
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/175#issuecomment-151940801
@vladimir-kotikov Sorry I had to update this, it was wrong:
https://github.com/apache/cordova-ios/commit/29f10b475414e84121e2e77f79095b6bccdc6b35
---
If your
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151959078
@infil00p @nikhilkh please review. I was also unsure of how to handle
cordova.js; do we commit that for every js change? I did not update it in my pr.
---
If
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151972235
Sure, I'll push the camera branch and work on a good sample app
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151975164
Camera code is here:
https://github.com/MSOpenTech/cordova-plugin-camera/tree/save-state
---
If your project is set up for it, you can reply to this email and
Github user TimBarham closed the pull request at:
https://github.com/apache/cordova-lib/pull/333
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Bnaya commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151969621
Looks like good a solution,
I think you need to also guarantee that handlers registered before you
fired the resume event will get it, as it with device ready
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-android/pull/236
API for saving/restoring plugin and js state
Here is my proposal for dealing with Activity destruction in Android. The
code is still a little rough and might need to be finalized, but I
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151959575
Can we get an updated Camera plugin branch with the same branch name so
that we can work off the same code? Also, an example app for this may be a
good idea
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-151969906
Merged with cordova-lib/master.
Some tests fail but those failure were already present in the master branch.
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Sorry for being late to the party.
+1 to conclusion
But leaving 2 cents
- Using "npm install" or "npm link" is a development time (i.e. cordova
contributors) only, When a product is shipped we should not rely on using
this process to satisfy dependencies
- The way dependencies are manage in
+1
On Wednesday, October 28, 2015, Steven Gill wrote:
> Sounds good to me.
>
> For reference, we are going to shut down
> https://github.com/cordova/apache-blog-posts in favor of
> https://github.com/apache/cordova-docs.
>
> On Wed, Oct 28, 2015 at 5:25 PM, Dmitry
Steve,
Did you mean you will shut this down?
https://github.com/cordova/apache-blog-posts
And not https://github.com/apache/cordova-docs
-Nikhil
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Wednesday, October 28, 2015 6:53 PM
To: dev@cordova.apache.org
Subject:
Welcome, and don't be a stranger you can use Slack to get in touch with us
also here http://slack.cordova.io/
On Tue, Oct 27, 2015 at 8:11 PM Shazron wrote:
> Welcome! Let us know if you need any help getting up to speed.
>
> On Tue, Oct 27, 2015 at 5:07 PM, Jason Ginchereau
+1 much better README, and npm angels will bless you with a kiss for
versioning it 1.0.0
On Wed, Oct 28, 2015 at 9:11 PM Steven Gill wrote:
> Left a bit of feedback. LGTM. Lets get this release rolling.
>
> -Steve
>
> On Wed, Oct 28, 2015 at 6:30 AM, Vladimir Kotikov
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-152079604
Failing tests!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Jeet thanks for reaching out to our mailing list, this mailing list is
intended for contributors making changes to the Apache Cordova Open Source
project.
The Cordova project seats below UI frameworks, and it provides a vanilla JS
API to access native capabilities, so we are UI framework agnostic.
+1
It doesn't hurt to bump the major version, since it's major change and the
code is seating on master.
This way we or consumers can test semver in config.xml, or plugin add
semver ranges, etc..
On Wed, Oct 28, 2015 at 12:40 PM Steven Gill wrote:
> We do the version
made comments and LGTM
On Tue, Oct 27, 2015 at 1:26 PM Nikhil Khandelwal
wrote:
> I made some updates based on feedback. Please review this version:
> https://github.com/apache/cordova-coho/pull/97
>
> I'm hoping we can agree on a JIRA triage process in the next couple
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-coho/pull/97#issuecomment-152054152
+1 LGTM
Yes Agree, I think folks see a name associated with a bug, and they think
that person already looked at it when it reality it's what @purplecabbage
Sorry late to the bridge dead sentence.
+1 Strongly agree, some of these feel like old hacks that are not need it
anymore, and also not public documented so it's OK for removal.
On Tue, Oct 27, 2015 at 9:06 PM Tommy Williams wrote:
> +1
>
>
> On 28 October 2015 at
What's the latest status on this? cordova-android master being fixed to
make it green again?
On Wed, Oct 28, 2015 at 7:28 AM Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> This is fixed in
> https://github.com/apache/cordova-android/commit/78fa7374d97ad9ed85c5c857a77a8f3830d600f9.
+1
I didn't realize this, yes this is better in one place
To be clear, now it's a matter of creating a new PR here [1] right?
[1]: https://github.com/apache/cordova-docs/tree/master/www/_posts
On Wed, Oct 28, 2015 at 10:12 PM Nikhil Khandelwal
wrote:
> Steve,
> Did you
Nikhil, yes. I believe that is what I said in my earlier email too. :)
On Wed, Oct 28, 2015 at 7:12 PM, Nikhil Khandelwal
wrote:
> Steve,
> Did you mean you will shut this down?
> https://github.com/cordova/apache-blog-posts
>
> And not
GitHub user guopengliang opened a pull request:
https://github.com/apache/cordova-docs/pull/407
Adding DailyCost app to showcase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guopengliang/cordova-docs master
Alternatively you
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152049507
@riknoll As for cordova.js changes you can follow the instructions here:
https://github.com/apache/cordova-js to generate a cordova.js. We generate the
file
+1
Review the new commits for release
Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz
Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05)
Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0
--dest test-hello/ and compare with dist
I had the impression that we wanted to deprecate cordova-wp8 and move
forward with cordova-windows only for everything.
On Wed, Oct 28, 2015 at 12:42 PM Jesse wrote:
> Done.
>
>
> On Wed, Oct 28, 2015 at 9:34 AM, Jesse wrote:
>
> > Yes, fixing
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-152079484
Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
They are safe to copy.
However, I don't see why anyone would have run npm link in the template
folder of a platform, or why anyone would need to.
We should probably just document that if you do this, it will break.
Can anyone think of a reason why they would 'need' to npm link those
modules?
Right now there is a difference between the cordova-common that’s in master,
the cordova-common that’s released on NPM, and the cordova-common that comes
with a platform. If we’re fine with these differences, then there isn’t really
an issue. Are we fine with them?
Kindly,
Dmitry
> On Oct 28,
This use case does mostly affect Cordova contributors. Usually the platforms
will come packaged, you’re right. The discussion of packaged-vs-installed is
separate, but just as a nod to it: I don’t see a reason we can’t just
automatically call “npm install” in platforms/ios/cordova. Copying over
Github user arangas commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-152005214
I've tested and examined this and it looks great, thanks! Is there any
reason not to define applicationStorageDirectory and set it to the same value
as
Follow-up: the reason we link them is so that we test master with master at all
times. As of right now, that workflow breaks because my version of "npm link”
makes relative links.
Kindly,
Dmitry
> On Oct 28, 2015, at 1:28 PM, Jesse wrote:
>
> They are safe to copy.
>
It is completely likely, and maybe even expected that the specific version
of cordova-common that sits in any particular platform template can be
different than what is used by cordova-lib.
They may even be different amongst platforms in a single project.
As long as the lib->platform api is
Is it possible to do “npm install” in those directories instead? Or to adjust
the path so that require() works with the original node_modules directory?
Kindly,
Dmitry
> On Oct 27, 2015, at 10:31 PM, Steven Gill wrote:
>
> I don't think we thought of symlinks in this
Currently, those modules ship with the platform. Example, cordova-ios will
have all necessary modules bundled in. When you create a cordova project
and add a platform, it takes those modules and moves them into your newly
created cordova project. To have the cordova project run `npm install` and
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-151986714
Here's an example index.js and index.html:
https://gist.github.com/riknoll/94a40dc147040191fd3e
For anyone hoping to test it out, make sure you check
This sounds really good!
The only reservation I have is making a new non-standard way of saving
state in js.
Instead of providing navigator.app.saveState() I think we should be content
to simply raise the event, and allow the app developer to choose how they
wish to store it. The obvious choice
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-152015056
We were using master version of cordova-android platform and after recent
changes which introduce new Api, mocks in these tests became insufficient. So
Github user pke commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-152016809
@purplecabbage The Secretary of the Apache Software Foundation has informed
me that my ICLA has been filed
---
If your project is set up for it, you can
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-152022199
I don't like the idea of testing 4.1.0 instead of master. Is this something
we will have to update everytime we release a newer version?
What is it
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/332#discussion_r43331295
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -244,19 +307,26 @@ describe('(save flag)', function () {
console.log(err);
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/332#discussion_r43327317
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -244,19 +307,26 @@ describe('(save flag)', function () {
console.log(err);
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152024614
I turned on "Don't keep activities" on both a Moto E (Android 4.4.1) and a
Samsung Galaxy S6 Edge (Android 5.1) to test this, and I'm not able to actually
get
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/332#issuecomment-152024899
@stevengill - ultimately, the point of these tests is to test the `--save`
feature, so going forward I don't think we want them to be at risk of being
broken by
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152031010
I believe iOS also has the same issue when transitioning from UIWebView to
other native views (although I don't believe app crashes) so I vote for having
a
> trust that each platform will be updated
> with a newer cordova-common when it makes sense
That sounds reasonable to me. I’m removing the link step for cordova-common in
platforms.
Last question: the cordova-common used by cordova-lib should still be linked,
yes?
Kindly,
Dmitry
> On Oct
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152026095
I am using a Nexus 6 with Marshmallow. Did you update cordova.js? I didn't
check it in to the PR because I was unsure of what the protocol was since it's
a
That's a pretty good point. When I was working on it, I figured that since this
was a platform specific issue, mimicking the platform's API (Android's
onSaveInstanceState) was the way to go. Expanding CoreAndroid's secret APIs is
probably worth avoiding though.
Thanks,
Richard
-Original
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152032481
Windows apps also have to deal with saving and restoring state like this in
at least some cases. See [MSDN - Guidelines for app suspend and
Hey folks,
Now that the website, blog, and docs are all in one Git repo, can we
discontinue the blog posts repo? Contributions can be made just as before, by
committing to the Git repo. Moreover, there is no more clone-then-copy-over
procedure.
Kindly,
Dmitry
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Yes, I believe the cordova-lib case should be linked, and definitely this
is where a relative link makes sense, since it's all in the same repo.
@purplecabbage
risingj.com
On Wed, Oct 28, 2015 at 5:28 PM, Dmitry Blotsky
wrote:
> > trust that each platform will be
+1 nice conclusion.
On Wed, Oct 28, 2015 at 5:30 PM, Jesse wrote:
> Yes, I believe the cordova-lib case should be linked, and definitely this
> is where a relative link makes sense, since it's all in the same repo.
>
>
> @purplecabbage
> risingj.com
>
> On Wed, Oct 28,
Sounds good to me.
For reference, we are going to shut down
https://github.com/cordova/apache-blog-posts in favor of
https://github.com/apache/cordova-docs.
On Wed, Oct 28, 2015 at 5:25 PM, Dmitry Blotsky
wrote:
> Hey folks,
>
> Now that the website, blog, and docs are
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/331#discussion_r43339044
--- Diff: cordova-common/README.md ---
@@ -20,12 +20,128 @@
-->
# cordova-common
-Contains shared classes and routines used by
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/331#discussion_r43339261
--- Diff: cordova-common/README.md ---
@@ -20,12 +20,128 @@
-->
# cordova-common
-Contains shared classes and routines used by
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/331#issuecomment-152044979
Looks great! Did some basic rewording
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Left a bit of feedback. LGTM. Lets get this release rolling.
-Steve
On Wed, Oct 28, 2015 at 6:30 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> The vote has failed. I'll bump version to 1.0.0 and start a new vote once
> the documentation for module will be added/updated.
>
>
I'll shut it down tomorrow afternoon. If anyone has any objections or
concerns, please speak up. :)
On Wed, Oct 28, 2015 at 5:53 PM, Steven Gill wrote:
> Sounds good to me.
>
> For reference, we are going to shut down
> https://github.com/cordova/apache-blog-posts in
87 matches
Mail list logo