RE: [DISCUSS] Tools Release

Android was fixed, but the tests still failing. However this is a problem with tests, not tools. The PR that fixes tests is here: https://github.com/apache/cordova-lib/pull/332 - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent:

[GitHub] cordova-lib pull request: CB-9872 Fixed save.spec.11 failure

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/332#issuecomment-152167831 We've scheduled adding e2e `update` tests for android and refactoring these tests to abstract from real platforms as two next high-pri tasks, so for now I

[GitHub] cordova-plugin-device-motion pull request: Pended tests that use a...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/37 Pended tests that use accelerometer on iOS simulator https://issues.apache.org/jira/browse/CB-9900 You can merge this pull request into a Git repository by running: $

RE: [Vote] 3.10.0 Cordova App Hello World Release

I vote +1 * Ran coho verify-archive successfully * Created blank application using cordova-app-hello-world@3.10.0, build and ran successfully - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, October 29, 2015 5:20 AM To:

[VOTE] Cordova-common 1.0.0 release

Please review and vote on this Cordova-common Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9899 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9899/ The

[GitHub] cordova-plugin-media pull request: Update plugin.xml

Github user pliablepixels closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media pull request: Update plugin.xml

GitHub user pliablepixels opened a pull request: https://github.com/apache/cordova-plugin-media/pull/75 Update plugin.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/pliablepixels/cordova-plugin-media

Re: [DISCUSS] Removal of unused iOS bridges

+1, I first saw the bridges when looking into one issue but didn't know if the user configures them or if it was something internal that changed on certain circumstances, so if it isn't used, remove it. 2015-10-29 3:35 GMT+01:00 Carlos Santana : > Sorry late to the bridge

[GitHub] cordova-lib pull request: CB-9872 Fixed save.spec.11 failure

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/332#issuecomment-152242161 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Who's interested on Cordova translation process ownership?

Hello community. It's with mixed feelings that I have to say this. My current assignment at work is keeping me away from the community, hence I haven't been able to perform in the way all of you deserve in reciprocity for your hard work. Because of this, I need to hand over the translation work

Re: [Vote] 3.10.0 Cordova App Hello World Release

choo choo !! On Thu, Oct 29, 2015 at 10:08 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I vote +1 > > * Ran coho verify-archive successfully > * Created blank application using cordova-app-hello-world@3.10.0, build > and ran successfully > > - > Best regards, Vladimir > >

RE: [Android] Possible solution to Camera/Media

Hey everyone, I just wanted to update this thread with a link to the PR I submitted as a proposed solution to this issue. Just making sure that people are aware that there is some discussion taking place in Github about this problem: https://github.com/apache/cordova-android/pull/236 Thanks,

[GitHub] cordova-lib pull request: CB-9872 Fixed save.spec.11 failure

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/332#issuecomment-152255889 Merge! That way I can do the tools release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-9872 Fixed save.spec.11 failure

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/332 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

GitHub user Sinistralis opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122 Added Android cookie sharing functionality between webviews There currently exists a gap in functionality with Android as opposed to iOS where iOS will actively share

Re: [DISCUSS] Removing blog posts repo

@Carlos: yes. That is the correct place where blog posts live now. Kindly, Dmitry > On Oct 28, 2015, at 8:16 PM, Carlos Santana wrote: > > +1 > I didn't realize this, yes this is better in one place > To be clear, now it's a matter of creating a new PR here [1] right? >

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152275664 Closing and reopening to trigger the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

GitHub user vladimir-kotikov reopened a pull request: https://github.com/apache/cordova-lib/pull/329 CB-9834 Introduce cordova modules compatibility map for plugin hooks This fixes potential issue with third-party plugin hooks, since many of them using internal cordova modules, in

Re: [DISCUSS] Copying node_modules during platform install

Gotcha. I’m now thoroughly convinced that shipping node_modules directly is the 100% way to go. I guess having out of date dependencies is just an unavoidable side effect of shipping software as-is. We’ll just have to be diligent in updating cordova-common in platforms quickly enough to unblock

Re: [DISCUSS] Tools Release

Thanks Alex and Tim ! - Carlos @csantanapr > On Oct 29, 2015, at 2:50 PM, Tim Barham wrote: > > There was still a problem with the tests in cordova-lib. Alex's fix has just > been merged and tests are now green. > > -Original Message- > From: Carlos Santana

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

GitHub user eymorale opened a pull request: https://github.com/apache/cordova-lib/pull/334 CB-9901 cordova plugin search opens in a browser You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-lib CB-9901

[GitHub] cordova-plugin-geolocation pull request: background location under...

Github user andreyzenkov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/51#issuecomment-152298743 Hey guys. This fix really need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [Android] Possible solution to Camera/Media

Thanks Joe, this is very good area to improve, with mobile OS being more aggressive on saving battery and giving less time to processes on the background the problem will show in the wild more often, so having a clean way to restore state is good way to move forward. On Thu, Oct 29, 2015 at 12:37

RE: [DISCUSS] Tools Release

There was still a problem with the tests in cordova-lib. Alex's fix has just been merged and tests are now green. -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Wednesday, October 28, 2015 7:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Tools

Re: [DISCUSS] Tools Release

Sweet. I'm continuing the release now. -Steve On Thu, Oct 29, 2015 at 11:50 AM, Tim Barham wrote: > There was still a problem with the tests in cordova-lib. Alex's fix has > just been merged and tests are now green. > > -Original Message- > From: Carlos

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152334883 >The fact that iOS shares cookies is a defect imho. I would be completely ok with agreeing with this. I just want constancy,

[GitHub] cordova-plugin-camera pull request: CB-7668 Adding a sterner warni...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/130 CB-7668 Adding a sterner warning for allowedit on Android Adds a much clearer warning about `allowEdit` on Android to the README. That particular feature has been the cause of many

[GitHub] cordova-plugin-camera pull request: CB-7668 Adding a sterner warni...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/130#issuecomment-152308660 @infil00p please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-9902 - cordova run --list broken

GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/335 CB-9902 - cordova run --list broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-9902 Alternatively you can

Re: [DISCUSS] Tools Release

Breakage: https://issues.apache.org/jira/browse/CB-9902 Sent a PR: https://github.com/apache/cordova-lib/pull/335 On Thu, Oct 29, 2015 at 12:46 PM, Carlos Santana wrote: > Thanks Alex and Tim ! > > - Carlos > @csantanapr > >> On Oct 29, 2015, at 2:50 PM, Tim Barham

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152319159 The fact that iOS shares cookies is a defect imho. That said, I think what 'should' happen is that this 'feature' should be exposed as an

[GitHub] cordova-lib pull request: CB-9902 - cordova run --list broken

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/335#issuecomment-152336596 LGTM spawn or targets hasn't changed so maybe options coming into targets has changed since cordova-common. I'll look at the history to see whats up but

[GitHub] cordova-lib pull request: Fix create argument prerequisite check

GitHub user ZombieProtectionAgency opened a pull request: https://github.com/apache/cordova-lib/pull/337 Fix create argument prerequisite check Store argument.length from create before return call Update returns prerequisite checks to use the previously stored arg length You

[GitHub] cordova-coho pull request: Update app-hello-world-release-process....

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9902 - cordova run --list broken

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152337481 Correct, my thought process was that you would want to absolutely clear these cookies upon closing the app. Which leads into a

Re: [Vote] 3.10.0 Cordova App Hello World Release

The vote has now closed. The results are: Positive Binding Votes: (# of PMC members that +1'ed) Steve Gill Carlos Santana Vladimir Kotikov The vote has passed. I will now publish to dist & npm. On Thu, Oct 29, 2015 at 11:16 AM, Carlos Santana wrote: > choo choo !! > >

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152341159 The clear-cache options also clear the cookies in the inappbrowser before a page loads, so if you wanted to load something you didn't trust,

[GitHub] cordova-coho pull request: Update app-hello-world-release-process....

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/99 Update app-hello-world-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-38

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152337087 Thanks for the info. I think this is actually fine, as long as the options `clearsessioncache` and `clearcache` are honored, as

[GitHub] cordova-lib pull request: Update create, allow cfg.lib.www.url and...

GitHub user ZombieProtectionAgency opened a pull request: https://github.com/apache/cordova-lib/pull/336 Update create, allow cfg.lib.www.url and dir to be siblings I am trying to get some practice with Node and various modules and build methods. While trying to create a

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-152341785 I think we have different concerns here even though we agree on the same thing. If the app developer is concerned about exposing their

[ANNOUNCEMENT] Cordova-app-hello-world@3.10.0 has been released!

:D Also updated Android, iOS and Windows templates with this released version (for non cli usecases).

Re: [DISCUSS] Removing blog posts repo

IT HAS BEEN TERMINATED On Thu, Oct 29, 2015 at 12:50 PM, Dmitry Blotsky wrote: > @Carlos: yes. That is the correct place where blog posts live now. > > Kindly, > Dmitry > > > On Oct 28, 2015, at 8:16 PM, Carlos Santana > wrote: > > > > +1 > > I

[GitHub] cordova-plugin-device-motion pull request: CB-9369 Return error wh...

Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/38#issuecomment-152372394 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [VOTE] Cordova-common 1.0.0 release

+1 * Ran coho audit-license-headers over the repo * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured cordova-lib tests pass when npm linked cordova-common * Created hello world app using cordova-cli On Thu, Oct 29, 2015 at 4:28 AM,

[GitHub] cordova-android pull request: CB-9909 Shouldn't escape spaces in p...

GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-android/pull/237 CB-9909 Shouldn't escape spaces in paths on Windows. Instead on windows just wrap in quotes. Note that this value is only never executed directly - just displayed to the user. But this

[GitHub] cordova-android pull request: CB-9909 Shouldn't escape spaces in p...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-android/pull/237#issuecomment-152359281 @stevengill - can you take a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-9890 Documenting cordova-common

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android pull request: CB-9909 Shouldn't escape spaces in p...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-android/pull/237#issuecomment-152415463 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-device-motion pull request: Pended tests that use a...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/37#issuecomment-152373498 Have a look at #38, it does not make tests depend on device. --- If your project is set up for it, you can reply to this email and have