[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159524926 We were only running this on one machine, and we took that machine down and requested for it to be rebuilt, so no worries. As for the change, we should either look

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159510578 @dblotsky, @stevengill, @shazron - Can you please advice on how to handle this issue? Should we switch to manual form parsing or to some lib supporting in-memory

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

2015-11-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159499456 @stevengill, There are some questions and proposals on improvement for this PR - I believe they should be addressed first. This is a new featur

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-11-24 Thread snstarosciak
Github user snstarosciak commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159498834 @ghenry22 Ahhh thankyou so much man, you've been a huge help :) :+1: Though I can get audio to work, I may need to try testing it in an HTML 5 audio pl

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[ANNOUNCE] Cordova 5.4.1 released!

2015-11-24 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/669333854591692801 Blog: http://cordova.apache.org/news/2015/11/24/tools-release.html

[VOTE] cordova-ubuntu 4.3.1

2015-11-24 Thread Steven Gill
Please review and vote on this 4.3.1 Ubuntu Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10030 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10030 The package w

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159457232 Thanks for posting the JIRA @BernsteinA This pull request can't be accepted as is, but I will look into the issue soon. --- If your project is

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-11-24 Thread Steven Gill
Starting the vote for this On Tue, Nov 17, 2015 at 9:31 AM, David Barth wrote: > Hey, > > I would like to update the 4.x series of cordova-ubuntu with a couple of > fixes, and make it the last in the series supporting the cordova-cli 4.3.1 > branch as well > >- Cb 9868 - Should propose to in

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA
Github user BernsteinA commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159453172 @purplecabbage can you reopen this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA
Github user BernsteinA commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159457841 Thanks. In the meantime could it be listed under iOS Quirks in the readme? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA
Github user BernsteinA commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159459013 :p how did I know that was going to be the answer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159458313 Sure. Send a pull request! :smiley_cat: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA
Github user BernsteinA commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159456824 Linking to Jira for posterity: https://issues.apache.org/jira/browse/CB-7684 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

2015-11-24 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159452714 @daserge thoughts on merging this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159452179 Thanks @BernsteinA ! asfgit is not a person ... it's a bot that closes prs based on commit comments. This does appear to be an error, although

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-docs/pull/431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[ANNOUNCE] Plugins Release!

2015-11-24 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/669306712533237760 Blog: http://cordova.apache.org/news/2015/11/24/plugins-release.html Thanks to everyone who helped test & merge PRs!

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-11-24 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159431966 That function just gets the directory that you would store your files in. You can then append any file name you want to access. For example you could us

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA
Github user BernsteinA commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159431126 @asfgit looks like you closed the wrong PR by accident --- If your project is set up for it, you can reply to this email and have your reply appear on G

Re: [DISCUSS] Plugins release

2015-11-24 Thread Simon MacDonald
Yeah, no coffee for developers that don't release because, "Coffee's for closers!" Simon Mac Donald http://hi.im/simonmacdonald On Tue, Nov 24, 2015 at 4:32 PM, Jesse wrote: > +1 to release > Always Be Releasing! > > > @purplecabbage > risingj.com > > On Tue, Nov 24, 2015 at 1:28 PM, julio cesa

Re: [DISCUSS] Plugins release

2015-11-24 Thread Jesse
+1 to release Always Be Releasing! @purplecabbage risingj.com On Tue, Nov 24, 2015 at 1:28 PM, julio cesar sanchez wrote: > Last update was on june for most plugins and there are a lot of issues > resolved. People is usually complain on stack overflow and phonegap build > forums about issues t

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159411134 Please rewrite the form code so that nothing gets written to disk. --- If your project is set up for it, you can reply to this email and have your reply appear on G

Re: [DISCUSS] Plugins release

2015-11-24 Thread julio cesar sanchez
Last update was on june for most plugins and there are a lot of issues resolved. People is usually complain on stack overflow and phonegap build forums about issues that are already fixed but not released, so +1 to release now El martes, 24 de noviembre de 2015, Simon MacDonald < simon.macdon...@g

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159403068 The `formidable` package writes `multipart-form` files to a temporary file on disk. This is a **huge** security problem. --- If your project is set up for it, you

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159402700 I usually test it locally or with Heroku along with cordova-plugin-test-framework and the plugin auto tests. What do you mean by writing to disk? Can you please p

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159402244 Also... hold on... this server actually writes the files to disk. It should *not* do that. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159401871 Do you think we can have some tests for this file? It's tedious to test it manually with `curl`. :/ --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/9#issuecomment-159399788 @dblotsky, updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/9#discussion_r45791371 --- Diff: server.js --- @@ -4,6 +4,8 @@ var formidable = require('formidable'), port = process.env.PORT || 5000; stringify = require('js

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/9#discussion_r45791347 --- Diff: server.js --- @@ -35,15 +37,34 @@ http.createServer(function (req, res) { res.writeHead(200, {'Content-Type': 'text/plain'});

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/9#discussion_r45791335 --- Diff: server.js --- @@ -4,6 +4,8 @@ var formidable = require('formidable'), port = process.env.PORT || 5000; stringify = require('js

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/9#discussion_r45791254 --- Diff: server.js --- @@ -4,6 +4,8 @@ var formidable = require('formidable'), port = process.env.PORT || 5000; stringify = require('jso

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/9#discussion_r45790741 --- Diff: server.js --- @@ -4,6 +4,8 @@ var formidable = require('formidable'), port = process.env.PORT || 5000; stringify = require('js

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/9#discussion_r45790663 --- Diff: server.js --- @@ -35,15 +37,34 @@ http.createServer(function (req, res) { res.writeHead(200, {'Content-Type': 'text/plain'});

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-labs/pull/9 CB-9563 Mulptipart form data is used even a header named Content-Type… … is present Adds direct upload endpoint [Jira issue](https://issues.apache.org/jira/browse/CB-9563)

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

2015-11-24 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118 CB-8641 Some file-transfer plugin tests occasionally fail in mobilesp… …ec on Windows Phone 8.1 Increases timeouts for Windows platform in abort tests Adds impl

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/431#discussion_r45786234 --- Diff: www/_posts/2015-11-24-plugins-release.md --- @@ -0,0 +1,330 @@ +--- +layout: post +author: +name: Steve Gill +ur

Re: [DISCUSS] Plugins release

2015-11-24 Thread Simon MacDonald
I agree with Steve. I'm already running into many issues from developers not being able to get their code working on Android 6. I really want the plugins out to support them. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Nov 24, 2015 at 1:28 PM, Steven Gill wrote: > I disagree > > I have

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/86#issuecomment-159364907 very nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

Re: [Vote] Tools Release Cordova 5.4.1

2015-11-24 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Alexander Sorokin Vladimir Kotikov The vote has passed. I will be publishing to dist + npm later today. As well as the blog post. On Tue, Nov 24, 2015 at 12:59 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com

Re: [VOTE] Plugins Release! (attempt 2)

2015-11-24 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Alexander Sorokin Joe Bowser The vote has passed. I will be publishing the blog post + posting these to dist and npm later today. On Mon, Nov 23, 2015 at 10:06 AM, Joe Bowser wrote: > +1 > On Nov 23, 2015 7:19 AM,

Re: [DISCUSS] Plugins release

2015-11-24 Thread Steven Gill
I disagree I have been getting pinged for weeks(months even) now to update the plugins and don't think we should delay. If we are waiting for cordova 6 to pin cordova-android 5 and cordova-ios 4, that will probably take at least a couple of weeks still. I'll make sure to link the android 5.0 blog

Re: [DISCUSS] Plugins release

2015-11-24 Thread Nikhil Khandelwal
Sorry for being late to respond. It will be great if we can publish the plugins release on npm at the same time as the tools release which pins android 5.0. Not publishing at the same time will break a very simple use case that Alex described below. -Nikhil On 11/20/15, 12:43 PM, "Steven Gi

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-11-24 Thread snstarosciak
Github user snstarosciak commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159325716 @ghenry22 - If I could hug you...I would squeeze you until you popped, like a balloon. I tested a combination of that code out with mine AND IT WORKED.

Re: [DISCUSS] Plugins release

2015-11-24 Thread Raymond Camden
LGTM On Tue, Nov 24, 2015 at 1:35 AM, Steven Gill wrote: > Please review the blog post for the plugins release > > https://github.com/apache/cordova-docs/pull/431 > > On Fri, Nov 20, 2015 at 12:43 PM, Steven Gill > wrote: > >> Manually update until we released tools with android 5 pinned. >> >>

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-24 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/86 CB-9770 Request user permissions before picking a contact This fixes [CB-9770](https://issues.apache.org/jira/browse/CB-9770) by requesting address book permissions before p

RE: [Vote] Tools Release Cordova 5.4.1

2015-11-24 Thread Vladimir Kotikov (Akvelon)
I vote +1 * Ran coho -verify archive over RC archives * Ran npm test for relevant repos, checked out to release tag * Verified that mobilespec, created with old cli builds and runs successfully - Best regards, Vladimir -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/431#discussion_r45705993 --- Diff: www/_posts/2015-11-24-plugins-release.md --- @@ -0,0 +1,330 @@ +--- +layout: post +author: +name: Steve Gill +url: h

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/431#discussion_r45706005 --- Diff: www/_posts/2015-11-24-plugins-release.md --- @@ -0,0 +1,330 @@ +--- +layout: post +author: +name: Steve Gill +url: h