[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2016-01-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/360#issuecomment-170710634 I agree that plugman shouldn't be installing to platform_www so this logic belongs more to cli workflow LGTM --- If your project is set up for it, you

[GitHub] cordova-docs pull request: CB-10299 Adds windows@4.3.0 release blo...

2016-01-11 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/453#issuecomment-170743024 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.2 blog post

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: CB-10319 android: Adding reflect...

2016-01-11 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-file/pull/155 CB-10319 android: Adding reflective helper methods for permission requests As discussed on the mailing list. I ran the manual and auto mobilespec tests with cordova-android's master

[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...

2016-01-11 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66 CB-10319 android: Adding reflective helper methods for permission requests Adds reflection helper class as was discussed on the mailing list. I ran the mobilespec auto tests with

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...

2016-01-11 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-170498911 @trancee, could you please close this? #73 has been merged. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...

2016-01-11 Thread trancee
Github user trancee commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-170499604 Sure. Thanks for the merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...

2016-01-11 Thread trancee
Github user trancee closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: Update index.md

2016-01-11 Thread Vic-thor
GitHub user Vic-thor opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/150 Update index.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/Vic-thor/cordova-plugin-camera patch-1 Alternatively you can

[GitHub] cordova-plugin-splashscreen pull request: CB-9538 Implementing Fad...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: Update index.md

2016-01-11 Thread Vic-thor
Github user Vic-thor closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-docs pull request: CB-10299 Adds windows@4.3.0 release blo...

2016-01-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/453 CB-10299 Adds windows@4.3.0 release blog post See [CB-10299](https://issues.apache.org/jira/browse/CB-10299) You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

2016-01-11 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/129#issuecomment-170513142 Re-based on top of master and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[REVIEW] cordova-windows 4.3.0 blog post

2016-01-11 Thread Vladimir Kotikov (Akvelon)
Please review and comment: https://github.com/apache/cordova-docs/pull/453 - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] Windows 4.3.0 Release

2016-01-11 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this 4.3.0 Windows Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10299 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10299 The

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2016-01-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/360#issuecomment-170584322 @stevengill, what do you think about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-test-framework pull request: CB-10318 Do not wrap t...

2016-01-11 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/16 CB-10318 Do not wrap test title https://issues.apache.org/jira/browse/CB-10318 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-test-framework pull request: CB-10318 Do not wrap t...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: CB-10319 android: Adding refle...

2016-01-11 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/151 CB-10319 android: Adding reflective helper methods for permission requests As discussed on the mailing list You can merge this pull request into a Git repository by running: $

Re: [GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...

2016-01-11 Thread Jesse
Great! I don't know how those last buttons made it in, but they were UGLY! @purplecabbage risingj.com On Mon, Jan 11, 2016 at 3:26 AM, sgrebnov wrote: > Github user sgrebnov commented on the pull request: > > >

[GitHub] cordova-docs pull request: CB-10299 Adds windows@4.3.0 release blo...

2016-01-11 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/453#issuecomment-170644458 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-10319 android: Adding refle...

2016-01-11 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-170647098 @infil00p @jasongin please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If