[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread dlogo
Github user dlogo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-173118941 @riknoll thanks for reviewing the code, I'll follow your recommendations and update the code asap! --- If your project is set up for it, you can reply to

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Simon MacDonald
Yup, that was exactly what I was thinking. Check in see if we've made progress on what we talked about last time. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jan 19, 2016 at 10:05 PM, Parashuram N wrote: > Like another Cordova Face to Face ? It would be almost 6 months since we > had

RE: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Parashuram N
Like another Cordova Face to Face ? It would be almost 6 months since we had the last one. -Original Message- From: Simon MacDonald [mailto:simon.macdon...@gmail.com] Sent: Tuesday, January 19, 2016 6:02 PM To: dev@cordova.apache.org Subject: Re: Apache Con NA May 11-13 in Vancouver, BC

[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

2016-01-19 Thread njleonzhang
Github user njleonzhang commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173069706 @daserge, when AutoHideSplashScreen is disabled, I think the splash should not hide when app is switch to background. So I think the flowing

[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-19 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/69#issuecomment-173062219 @dblotsky @nikhilkh @riknoll Can you please check and merge this request? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-coho pull request: Updated step to create permanent releas...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-coho pull request: Updated step to create permanent releas...

2016-01-19 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/110 Updated step to create permanent release tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-47 Alterna

[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-19 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-medic/pull/69 CB-10390: ADB doesn't recognize existing devices in Medic In Apache CI, we get the error: ADB doesn't recognize existing devices in Medic. The root cause for this error is that there is

[ANNOUNCE] Cordova Plugins Released!

2016-01-19 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/689631426921107457 Blog: https://cordova.apache.org/news/2016/01/19/plugins-release.html

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Simon MacDonald
I would be interested in going as well. Might be an easier sell if we could schedule a Cordova check up around the same time. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jan 19, 2016 at 4:20 PM, Anis KADRI wrote: > I'd be down to go. I went last year and our project had a few talks but

[GitHub] cordova-docs pull request: added plugins release blog post

2016-01-19 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-docs/pull/458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

Re: [DISCUSS] Plugins Release

2016-01-19 Thread Carlos Santana
I know I know, well at least it's a good thing, plugin that didn't get an update it's stable or recently already released :-) On Tue, Jan 19, 2016 at 8:22 PM Steven Gill wrote: > Actually not every plugin was updated :P > > On Tue, Jan 19, 2016 at 5:17 PM, Carlos Santana > wrote: > > > LGTM mi

Re: [DISCUSS] Plugins Release

2016-01-19 Thread Steven Gill
Actually not every plugin was updated :P On Tue, Jan 19, 2016 at 5:17 PM, Carlos Santana wrote: > LGTM might want to add that this is a "plugin extravaganza" every plugin > got an update :-) > > > On Tue, Jan 19, 2016 at 1:57 AM Steven Gill > wrote: > > > Please review the plugins release blog

Re: [VOTE] Plugins Release! Jan 15, 2016

2016-01-19 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Alexander Sorokin Jesse MacFadyen The vote has passed. I will post the blog and publish to dist & npm. On Tue, Jan 19, 2016 at 2:19 PM, Jesse wrote: > I vote +1. > > * Verified signatures and hashes > * Verified ta

Re: [DISCUSS] Plugins Release

2016-01-19 Thread Carlos Santana
LGTM might want to add that this is a "plugin extravaganza" every plugin got an update :-) On Tue, Jan 19, 2016 at 1:57 AM Steven Gill wrote: > Please review the plugins release blog post. > https://github.com/apache/cordova-docs/pull/458 > > Also, need one more vote for the release. > > On Thu

Re: This is me!

2016-01-19 Thread Carlos Santana
Bienvenido Hernan Check out how to get started here: http://cordova.apache.org/contribute/contribute_guidelines.html Just curious, what features media-capture do you use, it will be good to hear use cases for the plugin since camera it's more widely used than capture. On Tue, Jan 19, 2016 at

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/457#issuecomment-173042779 Thanks, Dmitry! I fixed the points that you brought up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

This is me!

2016-01-19 Thread HernĂ¡n Orozco
Hello, My name is Hernan Orozco, I'm 23 years old, I'm a Ruby on Rails - Angularjs - Phonegap developer. I've been working with Cordova for around two years. I'm from Colombia and I'm currently working for Koombea . I would like to contribute to some cordova plugins such as the

Re: [VOTE] Plugins Release! Jan 15, 2016

2016-01-19 Thread Jesse
I vote +1. * Verified signatures and hashes * Verified tags @purplecabbage risingj.com On Mon, Jan 18, 2016 at 8:21 AM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > I vote +1. > > * Verified signatures and hashes > * Verified tags > * Verified that plugins can be added correc

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-173005542 @dlogo Thanks for submitting a PR! There are a number of whitespace issues that must be resolved before this is eligible to be merged. Please make sure y

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/457#issuecomment-173002762 Just a suggestion: maybe add some CSS to make the link vanish unless the title is hovered, and add a bit of spacing. --- If your project is set up for it, you ca

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Anis KADRI
I'd be down to go. I went last year and our project had a few talks but still was super under represented so everyone that can make it should go I think. On Tue, Jan 19, 2016 at 11:49 AM Steven Gill wrote: > I'm planning on going but it seems i'm the only one so far. > > On Tue, Jan 19, 2016 at

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/457#discussion_r50170880 --- Diff: www/static/js/docs.js --- @@ -48,7 +57,10 @@ $(document).ready(function () { // add a special class to the anchor for this to

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/457#discussion_r50170623 --- Diff: _config.yml --- @@ -73,7 +73,9 @@ redcarpet: - lax_spacing - tables - + +# enables

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Steven Gill
Looks like it has been merged. Good to release now? On Tue, Jan 19, 2016 at 11:57 AM, Joe Bowser wrote: > OK, that's fine for now, but we should look at moving up which Android > Gradle version we're building with. I'm kind of hesitant to use 2.0.0 > because it might break stuff, and more and m

[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Joe Bowser
OK, that's fine for now, but we should look at moving up which Android Gradle version we're building with. I'm kind of hesitant to use 2.0.0 because it might break stuff, and more and more getting the feeling that the tools team is trying to make it harder for us to do things. On Tue, Jan 19, 201

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165780 --- Diff: src/android/FileHelper.java --- @@ -79,50 +79,72 @@ public static String getRealPath(String uriString, CordovaInterface cordova) {

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#discussion_r50165621 --- Diff: src/android/FileHelper.java --- @@ -79,50 +79,72 @@ public static String getRealPath(String uriString, CordovaInterface cordova) {

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

2016-01-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/457#discussion_r50165370 --- Diff: www/static/js/docs.js --- @@ -48,7 +57,10 @@ $(document).ready(function () { // add a special class to the anchor for this to

[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/249#issuecomment-172966143 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/249#issuecomment-172965450 @infil00p Please take a look and lets start the release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Steven Gill
I'm planning on going but it seems i'm the only one so far. On Tue, Jan 19, 2016 at 11:23 AM, Joe Bowser wrote: > As usual, I'm not going to be attending this conference. I'm pretty sure > I'm banned from attending this. > > On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva > wrote: > > > If we

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

2016-01-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-172961014 This seems important enough. @riknoll can you review this? It relates to: CB-10177 --- If your project is set up for it, you can reply to this email a

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Joe Bowser
As usual, I'm not going to be attending this conference. I'm pretty sure I'm banned from attending this. On Tue, Jan 19, 2016 at 11:16 AM, Ryan J. Salva wrote: > If we can get critical mass among other committers, I'd love to head up to > Vancouver for a few days. Without other Cordova committe

RE: [DISCUSS] Android@5.1.0

2016-01-19 Thread Nikhil Khandelwal
We have customers who have an existing C++ code base and looking to use NDK in their plugins. From what I can see the property android.useDeprecatedNdk=true needs to be part of gradle.properties and not .gradle file itself. I am aware that a plugin can add .gradle files - but I'm not sure they

RE: Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Ryan J. Salva
If we can get critical mass among other committers, I'd love to head up to Vancouver for a few days. Without other Cordova committers attending, I'm not sure I could justify attending solo. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, January 19,

[GitHub] cordova-android pull request: CB-10386 Add android.useDeprecatedNd...

2016-01-19 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-android/pull/249 CB-10386 Add android.useDeprecatedNdk=true to support NDK in gradle You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova

Apache Con NA May 11-13 in Vancouver, BC

2016-01-19 Thread Steven Gill
Anyone planning on submitting a talk for apachecon? The folks over at Apache Flex are wondering if we want to partner to create a client-side track. http://events.linuxfoundation.org/events/apachecon-north-america

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Simon MacDonald
I'd say, don't delay the release for this. Send a PR to the crosswalk team to let them know as it is ultimately their problem. Simon On Jan 19, 2016 13:36, "Joe Bowser" wrote: > Yes, it probably can. I'm thinking that Google once again put us in > dependency hell with the new NDK functionality,

[GitHub] cordova-plugin-inappbrowser pull request: Add fix for iOS file upl...

2016-01-19 Thread birge
GitHub user birge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/139 Add fix for iOS file upload. I'd like to start by saying I don't understand fully what the issue is or how this fixes the issue. I have been having an issue where my cordova app

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Joe Bowser
Yes, it probably can. I'm thinking that Google once again put us in dependency hell with the new NDK functionality, which is why I'm not super stoked about this file existing at all. On Tue, Jan 19, 2016, 10:29 AM Simon MacDonald wrote: > Can't the crosswalk plugin deliver the > Gradle files via

[GitHub] cordova-plugin-inappbrowser pull request: add fix for iOS upload

2016-01-19 Thread birge
Github user birge closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Simon MacDonald
Can't the crosswalk plugin deliver the Gradle files via the framework tag of its plugin. Xml to fix this? Simon On Jan 19, 2016 13:26, "Joe Bowser" wrote: > I really don't want to add this file and use the deprecated NDK, especially > since we don't know if this is a plugin or platform responsib

[GitHub] cordova-plugin-inappbrowser pull request: add fix for iOS upload

2016-01-19 Thread birge
GitHub user birge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/138 add fix for iOS upload You can merge this pull request into a Git repository by running: $ git pull https://github.com/birge/cordova-plugin-inappbrowser add-ios-workaround

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Joe Bowser
I really don't want to add this file and use the deprecated NDK, especially since we don't know if this is a plugin or platform responsibility. I also don't want to delay a release for people not using Crosswalk. Do we know of any other plugins that use the NDK? If there aren't any, I'm more agre

RE: [DISCUSS] Android@5.1.0

2016-01-19 Thread Nikhil Khandelwal
If this is a regression in behavior and CrossWalk will not work out of the box - we should consider fixing it. Sounds like it is a simple fix. Is there a JIRA for this? Overall, we shouldn't require/expect Cordova JS developers to modify gradle files. -Nikhil -Original Message- From:

Re: [DISCUSS] Android@5.1.0

2016-01-19 Thread Carlos Santana
What you guys think of making MIN SDK VER 15 instead of 14 as the default for this Android@5.1.0 ? We have a couple of plugins that required minsdk 15 [1], I also see that phonegap push plugin have problems with min sdk 14 here [2] Instead of anoying user with readme instructions to change it to

[GitHub] cordova-plugin-camera pull request: Try to use realpath filename i...

2016-01-19 Thread nantunes
Github user nantunes commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-172819385 _Per se_ the patch only manipulates strings: ```java String fileName = realPath != null ? realPath.substring(realPath.lastIndexOf('/') + 1)

[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

2016-01-19 Thread neo-clon
Github user neo-clon closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-splashscreen pull request: Get AutoHideSplashScreen...

2016-01-19 Thread neo-clon
Github user neo-clon commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/66#issuecomment-172779405 Thanks, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-docs pull request: Fix invalid dash sign (`Too many parame...

2016-01-19 Thread SunboX
GitHub user SunboX opened a pull request: https://github.com/apache/cordova-docs/pull/459 Fix invalid dash sign (`Too many parameters` exception) You can merge this pull request into a Git repository by running: $ git pull https://github.com/SunboX/cordova-docs patch-1 Altern