[GitHub] cordova-plugin-camera pull request: Update CDVCamera.m

2016-01-20 Thread Raaj19091
GitHub user Raaj19091 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/157 Update CDVCamera.m just to check how to edit it and use You can merge this pull request into a Git repository by running: $ git pull https://github.com/Raaj19091/cordova-plugin

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-20 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173476489 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173475729 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-20 Thread bso-intel
Github user bso-intel commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173474167 Hi @purplecabbage, Would you review this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

Re: PhoneGap Day US - In Utah next week

2016-01-20 Thread Don Coleman
I'll be there. On Wed, Jan 20, 2016 at 8:25 PM, Jesse wrote: > Who all from this list is attending PGD next week in Utah? > Of course the whole Adobe PhoneGap team will be there, including members > from 4 corners of North America, and 1.5 Australians. > > Cheers, > Jesse > > @purplecabbage >

PhoneGap Day US - In Utah next week

2016-01-20 Thread Jesse
Who all from this list is attending PGD next week in Utah? Of course the whole Adobe PhoneGap team will be there, including members from 4 corners of North America, and 1.5 Australians. Cheers, Jesse @purplecabbage risingj.com

Re: [DISCUSS] Improving core plugins automated test coverage

2016-01-20 Thread Carlos Santana
Wow this is great! not just for our cordova code, but app developers that want to learn how to use appium to test their own plugins and app code Is this something we can run on saucelabs?, I think is free for open source projects. On Wed, Jan 20, 2016 at 8:16 PM Steven Gill wrote: > Sweet! Tha

Re: [DISCUSS] Improving core plugins automated test coverage

2016-01-20 Thread Steven Gill
Sweet! Thanks for doing this Alexander! Always thought it would be a great idea to write some our tests with appium On Wed, Jan 20, 2016 at 5:07 PM, Joe Bowser wrote: > So, Appium works now and I can close the issue complaining that Appium > doesn't work? > > On Wed, Jan 20, 2016, 9:12 AM Alexan

[Vote] 5.1.0 Android Release

2016-01-20 Thread Steven Gill
Please review and vote on this 5.1.0 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10391 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10391 The package

Re: [DISCUSS] Improving core plugins automated test coverage

2016-01-20 Thread Joe Bowser
So, Appium works now and I can close the issue complaining that Appium doesn't work? On Wed, Jan 20, 2016, 9:12 AM Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > Hi guys. > > Lately I've been working on improving automated test coverage of core > plugins. Work is still in progress

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

2016-01-20 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/460 CB-10330 Adding style guide for xml references You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs raghav/xml Altern

--browserify workflow status?

2016-01-20 Thread Nikhil Khandelwal
Where are we with --browserify support? From what I can see, most or all the work has been completed: https://issues.apache.org/jira/browse/CB-8801 Should it move out of experimental now?[1] It will help to document it and perhaps blog about its benefits as opposed to the current default workf

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

2016-01-20 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-173398203 Is there a link to the conversation around this change? ( I assume it is [1] ) Ultimately there are 2 pieces to splash-screen : 1. the platform/os

[GitHub] cordova-medic pull request: CB-10401: Connectivity Issue to github...

2016-01-20 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/71#issuecomment-173371802 @dblotsky @nikhilkh @riknoll @alsorokin Can you please review and merge this PR? Tks. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-medic pull request: CB-10401: Connectivity Issue to github...

2016-01-20 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-medic/pull/71 CB-10401: Connectivity Issue to github from cordova- Adding retry logic to cloning github repositories. Added 2 parameters: 1. retryFetch - Git specific parameter - Ref Link: http://

[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/69#issuecomment-173358200 Good catch, @sarangan12! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...

2016-01-20 Thread guillaumedev
GitHub user guillaumedev opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/67 Update iOS geolocation plugin to avoid THREAD WARNING: ['Geolocation'… To avoid warning "THREAD WARNING: ['Geolocation'] took 'X' ms. Plugin should use a background thread

[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/69#issuecomment-173346488 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: [DISCUSS] Node versions on Travis and Appveyor

2016-01-20 Thread Steven Gill
I would recommend testing the latest 4 and the latest 5. Testing 0.10 and 0.12 would also be nice. On Wed, Jan 20, 2016 at 11:56 AM, Jesse wrote: > +1 to expanding coverage, but we should stick to stable versions as Carlos > notes. > > > @purplecabbage > risingj.com > > On Wed, Jan 20, 2016 at

Re: [DISCUSS] Node versions on Travis and Appveyor

2016-01-20 Thread Jesse
+1 to expanding coverage, but we should stick to stable versions as Carlos notes. @purplecabbage risingj.com On Wed, Jan 20, 2016 at 5:11 AM, Carlos Santana wrote: > What about node 4.0? That's the LTS (i.e. stable) version > > > On Wed, Jan 20, 2016 at 4:42 AM Dmitry Blotsky > wrote: > > > H

[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...

2016-01-20 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/76 CB-8056 Implement splashscreen for Windows platform [Jira issue](https://issues.apache.org/jira/browse/CB-8056) The plugin implementation has been moved to the platform c

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

2016-01-20 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/141 CB-8056 Implement splashscreen for Windows platform [Jira issue](https://issues.apache.org/jira/browse/CB-8056) Moved the implementation to the platform as per plugins triage recom

[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...

2016-01-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/69#issuecomment-173323145 @alsorokin to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Reg- Add Orubase Tools in Cordova Website

2016-01-20 Thread Bharathi D
Hi Team, We have created pull request for adding Orubase Tool in Cordova website home page, still that request is not processed. Orubase is a UI Framework that uses Cordova for accessing the Native API's. Could you please add our Orubase tool into y

[DISCUSS] Improving core plugins automated test coverage

2016-01-20 Thread Alexander Sorokin (Akvelon)
Hi guys. Lately I've been working on improving automated test coverage of core plugins. Work is still in progress but there are some results that I want to share. The idea is to use Appium framework to automate core plugins manual tests in mobilespec app. I've implemented a new command for Medi

[GitHub] cordova-plugin-device-motion pull request: CB-10400 Added Appium t...

2016-01-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/39 CB-10400 Added Appium tests for Android platform https://issues.apache.org/jira/browse/CB-10400 You can merge this pull request into a Git repository by running: $ git pu

[GitHub] cordova-plugin-battery-status pull request: CB-10398 Added Appium ...

2016-01-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/29 CB-10398 Added Appium tests for Android platform https://issues.apache.org/jira/browse/CB-10398 You can merge this pull request into a Git repository by running: $ git p

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-01-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/101 CB-10399 Added Appium tests https://issues.apache.org/jira/browse/CB-10399 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSO

[GitHub] cordova-plugin-camera pull request: CB-10397 Added Appium tests

2016-01-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/156 CB-10397 Added Appium tests https://issues.apache.org/jira/browse/CB-10397 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpe

[GitHub] cordova-medic pull request: CB-10396 Implemented Appium test runne...

2016-01-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/70 CB-10396 Implemented Appium test runner https://issues.apache.org/jira/browse/CB-10396 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MS

[GitHub] cordova-plugin-camera pull request: Fix FileNotFoundException in o...

2016-01-20 Thread MiniGab
GitHub user MiniGab opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/155 Fix FileNotFoundException in ouputModifiedBitmap The ouputModifiedBitmap expect the result from FileHelper.getRealPath to return null in case of error : String realPath =

[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...

2016-01-20 Thread davetayls
Github user davetayls commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-173243484 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...

2016-01-20 Thread davetayls
Github user davetayls commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/154#discussion_r50270493 --- Diff: src/browser/CameraProxy.js --- @@ -66,7 +66,15 @@ function capture(success, errorCallback) { imageData = imageData.rep

Re: [DISCUSS] Node versions on Travis and Appveyor

2016-01-20 Thread Carlos Santana
What about node 4.0? That's the LTS (i.e. stable) version On Wed, Jan 20, 2016 at 4:42 AM Dmitry Blotsky wrote: > Hey folks, > > Richard and I came across a discrepancy today where some cordova-lib tests > were failing on a local machine but not on Travis or Appveyor, and we > figured it was l

[DISCUSS] Node versions on Travis and Appveyor

2016-01-20 Thread Dmitry Blotsky
Hey folks, Richard and I came across a discrepancy today where some cordova-lib tests were failing on a local machine but not on Travis or Appveyor, and we figured it was likely due to different Node versions (0.12 vs. 5.0). Are there any objections to expanding our coverage on Travis and Appv