Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186517246
It looks great assuming that before_platform_add and after_platform_add
hooks could be platform specific.
My understanding about the current convention is a
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545261
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545199
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545185
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-186493087
@daserge Thanks for pointing me to the discussion. I forgot about it! I
think right now the process is unintuitive. Now that the plugin docs are moving
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/504#issuecomment-186486786
@dhams Thanks for the PR! This is no longer an issue in master because the
android `config.md` file was removed as part of the Android Guide improvements
in
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53542149
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -118,72 +113,8 @@ Windows
-## Configuring Splash
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53542106
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -52,7 +48,7 @@ which will be used for all platforms.
For each platform you can also define a
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-186485912
@daserge Have you tested this and verified it's working? I have the
splashscreen plugin v3.2.0, and have manually converted my existing
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/511#discussion_r53542087
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -34,15 +31,14 @@ If you do not specify an icon then the Apache Cordova
logo is used.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53539872
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -132,20 +203,20 @@ To preview the app in the iOS emulator:
4. Press the
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-docs/pull/511
CB-10347: Remove 'Add icons and splash screen' article
Icons page cleanup
@nikhilkh @rakatyal @dblotsky Can you please review and merge this PR?
You can merge this pull request
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/510#discussion_r53539639
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -62,7 +62,7 @@ And many, many, more.
One of the biggest mistakes a new Cordova
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/510#discussion_r53539593
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -141,7 +144,7 @@ Debugging Cordova requires some setup. Unlike a desktop
application, you can't
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/510#discussion_r53539495
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -141,7 +144,7 @@ Debugging Cordova requires some setup. Unlike a desktop
application, you can't
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/510#discussion_r53539472
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -132,7 +135,7 @@ Itâs not uncommon to use desktop browsers and device
simulators/emulators
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/510#discussion_r53539411
--- Diff: www/docs/en/dev/guide/next/index.md ---
@@ -62,7 +62,7 @@ And many, many, more.
One of the biggest mistakes a new Cordova
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/505#issuecomment-186469445
- Rebased on top of master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-186466203
@TimBarham addressed your other feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53536875
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-windows/pull/152#issuecomment-186449043
+1 to remove the lines. @alsorokin your thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53532560
--- Diff: www/docs/en/dev/guide/platforms/index.md ---
@@ -61,11 +61,8 @@ a lower-level alternative to the `cordova` command-line
utility.
## iOS
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/152#issuecomment-186445524
@alsorokin: is there a reason that the code under [this line][line] is even
necessary?
[line]:
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/152#issuecomment-186444637
@alsorokin yep, I ran those and now it works. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53531598
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-docs/pull/509#issuecomment-186442942
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53531200
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53531054
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/508
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/506#issuecomment-186440666
Addressed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53529433
--- Diff: cordova-lib/spec-cordova/plugin_fetch.spec.js ---
@@ -0,0 +1,203 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53529097
--- Diff: cordova-lib/spec-cordova/plugin_fetch.spec.js ---
@@ -0,0 +1,203 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r53528143
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
# Android Plugins
This
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186428877
@bso-intel will you take a look, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186425912
I'd like to see this get fixed, so I thought I'd submit a PR, but I'm a
node noob - this definitely needs to be reviewed before being merged in.
---
If your
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-lib/pull/395
CB-10654 make hooks fire when platforms added from repo or dir
move `hooksRunner.fire('before_platform_'...) ` till after platform has
been resolved, pass resolved platform instead of target.
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/509#discussion_r53513087
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -29,7 +29,7 @@ accessed. By default, new apps are configured to allow
access to any
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/510
CB-9478, CB-9973: Minor fixes to next steps article
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav-next
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/509#discussion_r53510678
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -29,7 +29,7 @@ accessed. By default, new apps are configured to allow
access to any
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/509#discussion_r53510644
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -29,7 +29,7 @@ accessed. By default, new apps are configured to allow
access to any
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/509#issuecomment-186380426
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/509
CB-10337: Changing whitelist guide to remove confusion about iOS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53503210
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-186362161
:ship: it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53500398
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r5358
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53499455
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53499272
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53498542
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53498288
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -72,192 +60,124 @@ There are two ways to download Xcode:
which requires
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-186352413
Responded to most the feedback. Also added warnings and verbose logging
which I completely forgot in my original PR. I will rebase this branch soon
---
If your
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53497631
--- Diff: www/docs/en/dev/guide/platforms/index.md ---
@@ -61,11 +61,8 @@ a lower-level alternative to the `cordova` command-line
utility.
## iOS
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/508#issuecomment-186334602
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186325651
This needs to use the new PermissionHelper class instead of the
CordovaInterface methods for requestPermission and hasPermission
---
If your project is
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/394#issuecomment-186313374
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186313033
This is in response to @infil00p's comments here:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094
I've
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186312333
@infil00p I've rebased here:
https://github.com/apache/cordova-plugin-camera/pull/174
---
If your project is set up for it, you can reply to this
GitHub user MatthewBooth opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/174
Rebased ochakov's branch to the latest as of writing
You can merge this pull request into a Git repository by running:
$ git pull
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094
WTF? I thought this was merged weeks ago, or we decided not to merge it or
something. We need to get the conflicts resolved and this thing pulled in.
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186290675
This should be merged ASAP. It fixes this very issue for a project I'm
working on.
You absolutely should be declaring the permissions in
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/81
CB-10652 Added the instruction on how to prepare a slave for Appium tâ¦
â¦ests
https://issues.apache.org/jira/browse/CB-10652
You can merge this pull request into a Git
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-medic/pull/81#issuecomment-186250451
@dblotsky please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/151
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull
Github user dhams commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53453538
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
}
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#discussion_r53451788
--- Diff: src/android/SplashScreen.java ---
@@ -341,7 +341,11 @@ public void onCancel(DialogInterface dialog) {
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85#issuecomment-186184171
Thanks!
Could you please explain your use case why the spinner should be
cancellable?
---
If your project is set up for it, you can reply to
GitHub user dhams opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/85
CB-10643cordova plugin splashscreen : Added new preference to choose
whether dialog is cancelable or not.
Added option to choose whether developer wants cancelable dialog or not
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user spedmo commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-186174071
Why isnt this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-js/pull/132
CB-10650 Non-index content.src causes Splashscreen to be not displayeâ¦
â¦d on browser
[Jira issue](https://issues.apache.org/jira/browse/CB-10650)
You can merge this pull request
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/84#issuecomment-186160148
Associated with PR https://github.com/apache/cordova-browser/pull/23
---
If your project is set up for it, you can reply to this email and have
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/84
CB-10636 CB-10650 Add JSHint for plugins
[CB-10636 Add JSHint for
plugins](https://issues.apache.org/jira/browse/CB-10636)
[CB-10650 Non-index content.src causes
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-browser/pull/23
CB-10650 Non-index content.src causes Splashscreen to be not displayeâ¦
â¦d on browser
[Jira issue](https://issues.apache.org/jira/browse/CB-10650)
You can merge this pull
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-186137795
@nikhilkh, will do that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/394#issuecomment-186135548
@nikhilkh, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-windows/pull/152#issuecomment-186125182
@dblotsky as far as I remember, this script can run without administrator
privileges, but you'll need to enable the needed channels first:
`wevtutil
79 matches
Mail list logo
