[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

2016-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/505 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...

2016-02-21 Thread bso-intel
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-android/pull/261 CB-10660 fixed the exception when removing a non-existing directory It is ALWAYS safer to check if the directory exists before it tires to remove the directory. The uninstallation of

[GitHub] cordova-ios pull request: CB-10659 changed project name to fix the...

2016-02-21 Thread bso-intel
GitHub user bso-intel opened a pull request: https://github.com/apache/cordova-ios/pull/195 CB-10659 changed project name to fix the platform add failure The project name "Hello Cordova" does not match with template project "HelloCordova", and it causes failure when finding the .xco

Re: [Android] CB-10625 Google Photos update breaks Camera's Gallery API

2016-02-21 Thread julio cesar sanchez
I've commited new changes that should fix the whole problem. When you edit the image it get changed and then you get it from a file path instead of a content path. 2016-02-21 23:22 GMT+01:00 julio cesar sanchez : > The PR doesn't fix CB-10625 > With the fix, if I choose photos app it doesn't take

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-02-21 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186937961 There was an issue on JIRA about the camera permission and was closed as "won't fix" becase camera permission shouldn't be asked by the app as we use

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

2016-02-21 Thread MatthewBooth
Github user MatthewBooth commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186934876 Probably why Travis is failing. Beyond me, though. I prefer native Java to this. --- If your project is set up for it, you can reply to this email

Re: [Android] CB-10625 Google Photos update breaks Camera's Gallery API

2016-02-21 Thread julio cesar sanchez
The PR doesn't fix CB-10625 With the fix, if I choose photos app it doesn't takes me to the "edit" screen and it works. If I choose gallery app it takes me to the "edit" screen and it fails. I can choose 2 apps to edit, photos and crop app, none of them work. 2016-02-21 21:09 GMT+01:00 julio cesar

[GitHub] cordova-plugin-device pull request: update

2016-02-21 Thread alexislg2
Github user alexislg2 closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-device pull request: update

2016-02-21 Thread alexislg2
Github user alexislg2 commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/51#issuecomment-186922888 sorry made mistake --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-device pull request: update

2016-02-21 Thread alexislg2
GitHub user alexislg2 opened a pull request: https://github.com/apache/cordova-plugin-device/pull/51 update You can merge this pull request into a Git repository by running: $ git pull https://github.com/alexislg2/cordova-plugin-device master Alternatively you can review and

Re: [Android] CB-10625 Google Photos update breaks Camera's Gallery API

2016-02-21 Thread julio cesar sanchez
Joe, I've found the real problem, forget what I said about the isGooglePhotosUri, it wasn't even entering in the if, it was crashing on DocumentsContract.getDocumentId(uri); with "IllegalArgumentException: Invalid URI" I've added a try catch and in case it crashes it will use the original uri to q

[GitHub] cordova-plugin-camera pull request: Fix for CB-10625

2016-02-21 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/175 Fix for CB-10625 getDocumentId was crashing in some cases. Now, in case it crashes, it will use the original uri to query. You can merge this pull request into a Git reposito

[GitHub] cordova-lib pull request: CB-10658: Downgrade error to warning

2016-02-21 Thread sajacy
GitHub user sajacy opened a pull request: https://github.com/apache/cordova-lib/pull/397 CB-10658: Downgrade error to warning Replace error with warning message if search paths differ. (which does happen with `cca` tool from the MobileChromeApps project) Generally, if th

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

2016-02-21 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/505#issuecomment-186778586 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature