[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-ios/pull/198#issuecomment-188647919 discussion: https://issues.apache.org/jira/browse/CB-9254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-ios/pull/198 CB-9254 copy over templates/PROJECT_NAME/Classes during cordova platf… …orm update You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-188631491 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: Replacing SDK/ARCH parameters by new des...

GitHub user robertoandrade opened a pull request: https://github.com/apache/cordova-ios/pull/197 Replacing SDK/ARCH parameters by new destination parameter Fixes issues when project has targets using different SDKs, i.e.: watchOS vs iOS. Addresses

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/499#issuecomment-188586378 @stevengill you can close this PR. I've done the work in #520 and I'll merge it tomorrow. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: Add CLI reference and Create your first...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/519#discussion_r54044465 --- Diff: gulpfile.js --- @@ -232,7 +235,7 @@ gulp.task("serve", ["build"], function () { }); }); -gulp.task("build",

Re: [DISCUSS] Cordova-iOS release

Ran into a bug while testing upgrading from 3.9.2 to 4.1.0 https://issues.apache.org/jira/browse/CB-9254 On Wed, Feb 24, 2016 at 5:00 PM, Steven Gill wrote: > Changes: > > * CB-10693 added missing header license > * CB-10693 Updated checked-in node_modules > *

Re: [DISCUSS] Cordova-Android 5.2.0 Release

I added them today :D On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal wrote: > These commands look great - it will be good to add them to release process > docs if they are not already there. > > -Nikhil > > -Original Message- > From: Steven Gill

RE: [DISCUSS] Cordova-Android 5.2.0 Release

These commands look great - it will be good to add them to release process docs if they are not already there. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, February 24, 2016 10:03 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS]

RE: Ask for advice about 'cordova build' command

I think you have to invoke cordova build with the CALL command to ensure it does not cause your script to exit. call cordova build -Nikhil -Original Message- From: So, Byoungro [mailto:byoungro...@intel.com] Sent: Wednesday, February 24, 2016 12:19 PM To: dev@cordova.apache.org

[GitHub] cordova-docs pull request: Add CLI reference and Create your first...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/519#discussion_r54038571 --- Diff: www/_layouts/docs.html --- @@ -189,7 +189,7 @@ {{ page.toc_text }} {{

[GitHub] cordova-docs pull request: Renaming 6.0.0 to 6.x.

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/520 Renaming 6.0.0 to 6.x. @nikhilkh @rakatyal please review when you have a moment. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188555220 I'm going to merge my branch tomorrow. @MatthewBooth can you close this PR and I'll open another? --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188545978 A simpler fix might be: since all we're looking for is the project's `id`, why not fall back on the main Cordova project's `config.xml` if we don't find a

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/81#discussion_r54035101 --- Diff: SLAVES.md --- @@ -38,6 +49,12 @@ To make the Android commands available on the command line, set the following en - `ANDROID_HOME`,

[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/56#issuecomment-188543877 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-188543128 @daserge @infil00p Would you be able to review this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/86 CB-10692 Don't fade when plugin is forced to close The fading logic exposed a race condition in an edge case when the plugin was repeatedly reinitialized, e.g. when the

Re: [DISCUSS] Cordova-iOS release

Changes: * CB-10693 added missing header license * CB-10693 Updated checked-in node_modules * CB-10530 - Updated cordova.js. This closes #193 * CB-10530 - App freezes sometimes directly after starting on iOS * CB-10668 checked in node_modules * CB-10668 removed bin/node_modules * CB-10668 updated

[GitHub] cordova-docs pull request: Add CLI reference and Create your first...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Cordova-iOS release

Merged it in after chatting with Shaz On Wed, Feb 24, 2016 at 12:55 PM, Darryl Pogue wrote: > I think we're still waiting for > https://github.com/apache/cordova-ios/pull/193 to land (but it's probably > good to merge) > > On 24 February 2016 at 12:53, Steven Gill

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-188514200 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r54023297 --- Diff: gulpfile.js --- @@ -193,14 +193,6 @@ gulp.task("watch", ["serve"], function () { ); gulp.watch( [ -

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r54022946 --- Diff: gulpfile.js --- @@ -211,8 +203,10 @@ gulp.task("watch", ["serve"], function () { gulp.watch( [

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r54022811 --- Diff: gulpfile.js --- @@ -211,8 +203,10 @@ gulp.task("watch", ["serve"], function () { gulp.watch( [

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188500100 Alright, I pushed an update branch here: https://github.com/MSOpenTech/cordova-plugin-camera/tree/CB-10120. I still need to do some testing. --- If

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r54022552 --- Diff: gulpfile.js --- @@ -193,14 +193,6 @@ gulp.task("watch", ["serve"], function () { ); gulp.watch( [ -

[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...

GitHub user JonHerr opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/56 CB-10690 windows: fix crash when user cancels/closes photo app wrapped the file.moveAsync() function with a check for file and return CaptureError.CAPTURE_NO_MEDIA_FILES when

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/363#issuecomment-188462559 @TimBarham could you take a quick look at the updates when you get a chance? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r54008241 --- Diff: gulpfile.js --- @@ -280,7 +280,11 @@ gulp.task("defaults", function () { }); gulp.task("toc", ["fetch"], function (done) {

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r54008179 --- Diff: gulpfile.js --- @@ -249,7 +243,13 @@ gulp.task("regen", ["jekyll"], function () { }); gulp.task("fetch", function (done) {

[GitHub] cordova-docs pull request: Add CLI reference and Create your first...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/519#issuecomment-188456154 @rakatyal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Add CLI reference and Create your first...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/519 Add CLI reference and Create your first app article Please review this commit: a6e1da5. The others are part of this pending PR #516 You can merge this pull request into a Git repository by

Re: [DISCUSS] Cordova-iOS release

I think we're still waiting for https://github.com/apache/cordova-ios/pull/193 to land (but it's probably good to merge) On 24 February 2016 at 12:53, Steven Gill wrote: > Any blockers? Going to aim to send this out this afternoon. > > > -Steve >

[GitHub] cordova-coho pull request: Added steps to update checked in node_m...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: Added steps to update checked in node_m...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/113 Added steps to update checked in node_modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-50

[DISCUSS] Cordova-iOS release

Any blockers? Going to aim to send this out this afternoon. -Steve

[Vote] 5.1.1 Android Release

Please review and vote on this 5.1.1 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10687 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10687 The package

[GitHub] cordova-plugin-media-capture pull request: fix for Cancel or back ...

Github user JonHerr closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: Ask for advice about 'cordova build' command

After-build hook is a reasonable solution, Qiang. You may want to check if the source directory "D: \cordovaWorkSpace\MyApp\platforms\android\build\outputs\apk\android-debug.apk". It seems there is a space between "D:" and "\". Another possible cause would be the permission issue on the target

Re: Ask for advice about 'cordova build' command

Hey! Why not use a after_build hook instead? http://cordova.apache.org/docs/en/latest/guide/appdev/hooks/index.html On Wed, Feb 24, 2016 at 11:04 AM, Raphael Bircher wrote: > Hi > > I remember that we have had a similar issue on a other project > (OpenOffice Testtool)

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/363#issuecomment-188425964 After conversation with @nikhilkh, I reworked the code a bit so that the warnings it prints are more actionable. They now list what dependencies failed for the

[GitHub] cordova-plugin-media-capture pull request: fix for Cancel or back ...

GitHub user JonHerr opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/55 fix for Cancel or back button in Windows 8/10 I made a slight change based on changes from another user. When the cancel or back button is pressed the promise is completed and

[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...

GitHub user restouffer opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/126 [Android] Handle redirects when downloading a file The FileTransfer plugin was stopping on a 301 redirect and storing the HTML from that page instead of the target file.

Re: Ask for advice about 'cordova build' command

Hi I remember that we have had a similar issue on a other project (OpenOffice Testtool) The only solution was to switch to VBA. As I know the Batch interpreter has issues with external processes. Have a nice day Raphael On Wed, Feb 24, 2016 at 11:54 AM, QiangOffice

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/511#issuecomment-188385262 Thank you! :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [DISCUSS] Cordova-Android 5.2.0 Release

Definitely. Already committed the update. My new strategy with bundled/checked in dependencies * update package.json dep version if required * rm -rf node_modules * npm install --production (skips dev dependencies) * git add node_modules/* (checkin all modules needed for platform add git url) *

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/511#issuecomment-188384413 @daserge Link: https://github.com/apache/cordova-plugin-splashscreen/blob/master/README.md This file is downloaded to the site. Agreed that this does not have

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/511#issuecomment-188382947 @sarangan12, I looked but was not able to find `## Configuring Splash Screens in the CLI` and `# Example configuration` substitutes. Could you please share a

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/511#issuecomment-188380902 @daserge As part of plugin pull task, the details are already available on the readme file of splashscreen plugin and available in our site. The link (in the

RE: [DISCUSS] Cordova-Android 5.2.0 Release

Steve, do you plan to update bundled `cordova-common` as a part of this release? - Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, February 24, 2016 8:12 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-Android

Ask for advice about 'cordova build' command

Hi Sir, I have used cordova develop my app for five months, thank you support this nice framework for us. For convenience, I wrote a batch file to build app automatically, but there is a catch, after the 'cordova build' command executed, the batch will end, commands which after 'cordova

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/516#issuecomment-188376934 @dblotsky I made some updates - please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188373756 Looking into failures... Another possible fix here - update `browser` platform rather than introducing additional complexity to platform adding

Re: [DISCUSS] Cordova-Android 5.2.0 Release

Issue: https://issues.apache.org/jira/browse/CB-10687 I'm going to make this version 5.1.1. I'll update here if I decide to go with 5.2.0 instead. On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser wrote: > OK, are we sure we didn't add any new minor features? > > On Wed, Feb 17,

[GitHub] cordova-lib pull request: Fix CB-10034

GitHub user robertoandrade opened a pull request: https://github.com/apache/cordova-lib/pull/399 Fix CB-10034 - Moved previously committed node-xcode extension to that project. Waiting PR: https://github.com/alunny/node-xcode/pull/79 - Added options and tests for iOS frameworks

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188327164 @TimBarham, could you take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/398 CB-10662 Apply project config to platform before installing any plugins JIRA: [CB-10662](https://issues.apache.org/jira/browse/CB-10662) This change is needed because some

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request: CB-10636 Add JSHint for ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-js pull request: CB-10650 Non-index content.src causes Spl...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-browser pull request: CB-10650 Non-index content.src cause...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-10636 Add JSHint for plugin...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user JoMas971 commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-188254202 Hello @Sinistralis, can you give us an update ? I also need this for my app, i'm actually using Xwalk (for android development, you can't

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/81#issuecomment-188248990 Also, added the links to the Appium issues describing the problem and the workaround for the chromedriver issue. --- If your project is set up for it, you can

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/81#issuecomment-188232798 @dblotsky iOS steps will always be necessary only if you want to run the tests on real device. You don't need to run these steps to run the tests on the

[GitHub] cordova-medic pull request: CB-10638 Appium runner: Fixed build co...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/82#issuecomment-188219789 ping @dblotsky - finally made the PR Squashed and rebased, so unfortunately all our comments does not display here but I think I've addressed all of your

[GitHub] cordova-medic pull request: CB-10638 Appium runner: Fixed build co...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/82 CB-10638 Appium runner: Fixed build command on OSX, Refactored runner code https://issues.apache.org/jira/browse/CB-10638 You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53921776 --- Diff: tests/tests.js --- @@ -18,9 +18,10 @@ * */ -/*global cordova, exports*/ -/*jshint jasmine: true*/

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53919580 --- Diff: src/firefoxos/FileProxy.js --- @@ -67,10 +69,12 @@ QUIRKS: exports.requestFileSystem = function(successCallback,

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53918932 --- Diff: tests/tests.js --- @@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/165#issuecomment-188155119 Mostly LGTM apart from a few minor comments/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911524 --- Diff: tests/tests.js --- @@ -18,9 +18,10 @@ * */ -/*global cordova, exports*/ -/*jshint jasmine: true*/

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911243 --- Diff: www/blackberry10/write.js --- @@ -40,7 +40,7 @@ module.exports = function (success, fail, args) { var uri = args[0],

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911054 --- Diff: tests/tests.js --- @@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {

[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53910671 --- Diff: src/firefoxos/FileProxy.js --- @@ -67,10 +69,12 @@ QUIRKS: exports.requestFileSystem =

[GitHub] cordova-plugin-inappbrowser pull request: CB-10636 Add JSHint for ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/151#issuecomment-188149151 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/84#issuecomment-188148446 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/511#issuecomment-188146084 @sarangan12, do you plan to move splashscreen-related configuration docs to cordova-plugin-splashscreen? --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-camera pull request: CB-10636 Add JSHint for plugin...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/173#issuecomment-188145591 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not