Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/261#issuecomment-189579252
Thanks for merging, Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189578539
Hi Vladimir,
I updated the code to accommodate your comments.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328731
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328707
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328698
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
var spli
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/33#issuecomment-189573337
@nikhilkh @riknoll @rkatyal please review when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/33
Reorganizing and rewording docs.
- Put examples below events
- De-duped returned object section
- Removed Tizen (deprecated)
- Made quirks a little easier to distin
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
not from my side.
thanks!
On Fri, Feb 26, 2016 at 3:51 PM, Steven Gill wrote:
> We need to do a update since the package on npm is missing some bundled
> node modules.
>
> Any blockers?
-
To unsubscribe, e-mail: dev-unsubscr...
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user omefire closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
We need to do a update since the package on npm is missing some bundled
node modules.
Any blockers?
Please review and vote on this 4.1.0 iOS Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10693
The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10693
The package was
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/181#issuecomment-189526888
I just realized that unless the image is saved to the photo album, we won't
be able to have a native URI for iOS(ms-assets://).
So, I'll change this
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/523#discussion_r54315923
--- Diff: tools/bin/util.js ---
@@ -22,45 +22,93 @@ module.exports = function () {
var fs = require("fs");
var path = require("path"
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/181
CB-10711: getPicture() should NOT save to photo album when called witâ¦
â¦h destinationType set Camera.DestinationType.NATIVE_URI
You can merge this pull request into a Git reposito
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/523#discussion_r54315457
--- Diff: tools/bin/util.js ---
@@ -22,45 +22,93 @@ module.exports = function () {
var fs = require("fs");
var path = require("path"
Github user thehuijb closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-189506713
@thehuijb Can you please close this PR? It's no relevant anymore.
---
If your project is set up for it, you can reply to this email and have your
reply a
GitHub user jerroydmoore opened a pull request:
https://github.com/apache/cordova-windows/pull/153
CB-10714 Ignore case for --archs
If "ARM" is passed to --archs, the Appx file is compiled, but the build
will fail due to a case sensitive string comparison.
You can merge this pul
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/180#issuecomment-189504717
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Alright, I ended up just doing a rebase from master instead of
cherry-picking. I think it should be all good now. Third vote sent.
On Fri, Feb 26, 2016 at 9:00 AM, Steven Gill wrote:
> Hmm. Alright. I thought I got them all but obviously not. I'll
> reinvestigate today.
> On Feb 26, 2016 3:58 AM
Please review and vote on this 5.1.1 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10687
The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10687
The package
This vote has failed
On Thu, Feb 25, 2016 at 12:11 PM, Steven Gill
wrote:
> Please review and vote on this 5.1.1 Android Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10687
>
> The archive has been publ
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/180
Adding focus handler to make sure filepicker gets launched when app iâ¦
â¦s active
FilesavePicker gives error when launched from an app which is currently not
active. When
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/179#issuecomment-189490623
@MatthewBooth I want to merge this in. Have you filed an ICLA? See the
prerequisites here:
http://cordova.apache.org/contribute/contribute_guidelines.htm
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/83#issuecomment-189490637
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-189440680
They local urls get auto added. I believe it is harmless. It got changed
when I made plist a top level dependency due to needing it for bin/lib/create.js
---
If
Github user dallas commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189430481
@dlogo & @riknoll any chance of getting this merged in today (not sure what
time zones you are all in)? I'm in US Pacific time zone and I'd love to try
th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-189419231
Besides the plist/package.json changes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/401#issuecomment-189417199
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/263#issuecomment-189415040
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/72
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull http
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/65
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull https://
Hmm. Alright. I thought I got them all but obviously not. I'll
reinvestigate today.
On Feb 26, 2016 3:58 AM, "Alexander Sorokin (Akvelon)" <
v-als...@microsoft.com> wrote:
> Sorry to say that but it looks like only a half of the changes made it to
> the archive this time.
>
> Here's what is missin
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-docs/pull/524
CB-10707 Add OS X to platform support page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tripodsan/cordova-docs CB-10707
Alternativel
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189269844
@andorman, i'll take care of tests. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189263000
@vladimir-kotikov The supported image types and namings can be found here:
https://msdn.microsoft.com/en-us/library/windows/apps/mt412102.aspx
Either "s
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/401#issuecomment-189262857
@nikhilkh, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/401
CB-10462 Get rid of npmconf in favor of npm
JIRA [CB-10462](https://issues.apache.org/jira/browse/CB-10462)
You can merge this pull request into a Git repository by running:
$ git
Sorry to say that but it looks like only a half of the changes made it to the
archive this time.
Here's what is missing:
* CB-10138 Adds missing plugin metadata to `plugin_list` module.
* CB-10443 Pass original options instead of remaining
* CB-10443 Fix `this.root` null reference
* CB-10421 Fixe
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/25
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pu
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/41
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull ht
Github user dlogo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-189215745
Hi,
@riknoll, I've implemented the requested changes and also received the ok
for the Apache ICLA register. Unfortunately I have to merge changes, I'll
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/263
CB-10669 cordova run --list cannot find 'adb'
[Jira issue](https://issues.apache.org/jira/browse/CB-10669)
You can merge this pull request into a Git repository by running:
$ git pull
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54224163
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
v
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54223240
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54222593
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189176531
LGTM. @andorman, It'd be great if you could add a couple of tests for this?
@nikhilkh, it looks like `target` attribute for images is not documented
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189172760
From what i understand the corresponding JIRA contains two separate issues
and one of them is a regression (see apache/cordova-lib#392), but second one
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/105
CB-10636 Add JSHint for plugins
Fixed contacts.spec.5
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by
54 matches
Mail list logo
