[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r55480177 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,176 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contribu

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r55480086 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,176 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contribu

[GitHub] cordova-docs pull request: Master

2016-03-08 Thread chrisgriffith
GitHub user chrisgriffith opened a pull request: https://github.com/apache/cordova-docs/pull/546 Master Fixing a typo Adjusting the iOS nesting diagram You can merge this pull request into a Git repository by running: $ git pull https://github.com/chrisgriffith/cordova-docs

[GitHub] cordova-docs pull request: Update tools.md

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/483#issuecomment-194122867 This has been already fixed. This PR needs to be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-cli pull request: CB-10679: Adding explanation for plugin ...

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/238#discussion_r55473629 --- Diff: doc/plugin.txt --- @@ -4,20 +4,23 @@ Synopsis Manage project plugins -add [...] Add specified plugins

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r55473246 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,176 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributo

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r55472886 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,176 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributo

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

2016-03-08 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/185#issuecomment-194112155 Thanks @dieppe , I'll resume looking at this PR soon. I've been out. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cordova-docs pull request: Making dropdowns preserve /latest/ in t...

2016-03-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/545#issuecomment-194086200 @rakatyal @nikhilkh @riknoll please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request: Making dropdowns preserve /latest/ in t...

2016-03-08 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/545 Making dropdowns preserve /latest/ in their links. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs latest-dropdow

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-194065776 Needs https://github.com/apache/cordova-cli/pull/239. Discussion at https://github.com/cordova/cordova-discuss/pull/33 --- If your project is set up for

[GitHub] cordova-cli pull request: CB-9858 added --fetch option

2016-03-08 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-cli/pull/239 CB-9858 added --fetch option Needs https://github.com/apache/cordova-lib/pull/407 Part of https://github.com/cordova/cordova-discuss/pull/33 You can merge this pull request into a G

Re: [DISCUSS] Plugins release

2016-03-08 Thread Carlos Santana
Steve I can handle the release for the plugins, I might need to get access to npm registry. I will start working on it tomorrow and send out the VOTE thread So far only 4 plugins: 1. globalization 2. splashscreen 3. camera 4. statusbar On Tue, Mar 8, 2016 at 8:36 PM Steven Gill wrote: > I'm tr

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-194059148 I decided to write the tests in node-tap. I am now regretting that decision a bit. Tests randomly timeout and fail. Doesn't happen in actual use. --- If your p

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

2016-03-08 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/407 CB-9858 Cordova Fetch Work This is not ready to merge yet! Opening the PR so it is easy to manage diffs and take feedback You can merge this pull request into a Git repository by running:

Re: [DISCUSS] Plugins release

2016-03-08 Thread Steven Gill
I'm traveling to Vancouver tomorrow until Sunday. It would be nice if someone can take over being the release master for this one. I can answer any questions along the way. Cheers, -Steve On Mon, Mar 7, 2016 at 11:58 AM, julio cesar sanchez wrote: > I add cordova-plugin-statusbar to the list >

[GitHub] cordova-cli pull request: CB-10679: Adding explanation for plugin ...

2016-03-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-cli/pull/238#issuecomment-194053721 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...

2016-03-08 Thread jamesandersen
Github user jamesandersen closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55457515 --- Diff: www/FileReader.js --- @@ -96,6 +106,78 @@ function initRead(reader, file) { } /** + * Callback used by the following

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55456235 --- Diff: www/FileReader.js --- @@ -96,6 +106,78 @@ function initRead(reader, file) { } /** + * Callback used by the followin

[GitHub] cordova-plugin-wkwebview-engine pull request: Support the scroll d...

2016-03-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4#issuecomment-194041370 Issue filed: https://issues.apache.org/jira/browse/CB-10818 @dpogue can you prefix the title of this PR with CB-10818? Thanks! --- If your pr

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10269: Replace co...

2016-03-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-194040883 @jamesandersen can you close this? it came out in the 1.0.2 release of the plugin --- If your project is set up for it, you can reply to this em

[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...

2016-03-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194039914 Sorry, overlooked this. The normal process is to file a JIRA issue and reference it in the title here (which will mirror comments to the issue). I

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/168#issuecomment-194033408 LGTM. Tested on Marshmallow device and KitKat emulator --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-docs pull request: Rewrite of storage guide.

2016-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55451426 --- Diff: www/FileReader.js --- @@ -96,6 +106,78 @@ function initRead(reader, file) { } /** + * Callback used by the following

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

2016-03-08 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194025822 Thanks @riknoll!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

2016-03-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194025033 Added you both as owners. The tests use cordova-android version 3.1.0, which is checked into cordova-lib: ``` cordova-lib/cordova-lib/spec-cordova/fixtures/p

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

2016-03-08 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194021132 LGTM. Question though, what version of android are the tests using? What version gets fetched (1.1.2 it looks like)? Maybe add vlad and me as owners to

RE: Edit to Edit on Github for Docs

2016-03-08 Thread Dmitry Blotsky
I don't know if we have A/B testing capabilities, but I'm cool with changing the text to "Edit on GitHub". Also, we have like 10 open PRs for docs from contributors, so the buttons definitely work. :) I'll make the change for "Edit on GitHub" unless someone objects. Kindly, Dmitry -Origina

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-08 Thread Carlos Santana
I was never a fan of the "platform update" command since it was not fully tested across the board. like all the permutations possible to/from upgrade. meaning going for very old like 3.6 to 5.1 If we do this I think it will break a lot of people that got used to changing files inside platform/ios/

[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...

2016-03-08 Thread jimmont
Github user jimmont commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194013037 What does it take to get this (very helpful change) merged into master? --- If your project is set up for it, you can reply to this email and hav

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-08 Thread Steven Gill
For Android, Joe brought up some real concerns. People not using build.json for releasing end up updating files within the android platform itself. Changes people might make to gradle files would get wiped out. People who copy 9patch files into their android projects. Some of these can be handled

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443925 --- Diff: tests/tests.js --- @@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () { expect(true).toFailWithMessa

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443750 --- Diff: tests/tests.js --- @@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () { expect(true).toFailWithMess

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443526 --- Diff: tests/tests.js --- @@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () { expect(true).toFailWithMessa

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443467 --- Diff: tests/tests.js --- @@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () { expect(true).toFailWithMessa

[GitHub] cordova-plugin-file pull request: CB-10577: Android resolveLocalFi...

2016-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/168#issuecomment-194003277 @rakatyal or @riknoll please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-cli pull request: CB-10679: Adding explanation for plugin ...

2016-03-08 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-cli/pull/238 CB-10679: Adding explanation for plugin version selection to plugin help This was just merged into cordova-lib. I wasn't totally sure where to add this blurb and decided on the current location

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-08 Thread So, Byoungro
I second that. +1 Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation From: Anis KADRI mailto:anis.ka...@gmail.com>> Reply-To: "dev@cordova.apache.org" mailto:dev@cordova.apache.org>> Date: Tuesday, March 8, 2016 at 2:34 PM To: "dev@cordova.apa

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-08 Thread Anis KADRI
I support this as well. Real updates never work. Better to remove/add. On Tue, Mar 8, 2016 at 12:04 PM Steven Gill wrote: > I would also like to see this happen. Would this cause problems if we did > this for other platforms? > > On Tue, Mar 8, 2016 at 11:55 AM, Shazron wrote: > > > See: > > ht

[ANNOUNCE] cordova-osx 4.0.1 released

2016-03-08 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/707321836246204416

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

2016-03-08 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/168 CB-7862: FileReader reads large files in chunks with progress I added support in FileReader for reading large files in chunks and reporting progress for each chunk. Previously, the Cor

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-08 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/544 CB-9393: Documenting how to embed a SystemWebView Redo of the pull request to update the SystemWebView documentation. You can merge this pull request into a Git repository by running: $

[GitHub] cordova-weinre pull request: `func` sometimes is undefined

2016-03-08 Thread pmuellr
Github user pmuellr commented on the pull request: https://github.com/apache/cordova-weinre/pull/13#issuecomment-193959003 So the ECONNREFUSED error you're seeing doesn't have anything to do with weinre? I'm worried the Error.prepareStackTrace was just the immediate symptom, that the

Re: Making plugins backward compatible to 5.1.1

2016-03-08 Thread Shazron
Agree with Kerri's points. Fork the code on Github (where it can live forever), call it cordova-plugin-device-legacy, apply the patch there. Publish to npm, and just install it using the npm package name. On Tue, Mar 8, 2016 at 12:21 PM, Kerri Shotts wrote: > While I’m happy that users are able t

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#issuecomment-193953081 Minor comments - LGTM otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Making plugins backward compatible to 5.1.1

2016-03-08 Thread Kerri Shotts
While I’m happy that users are able to continue supporting older environments, I also agree that legacy code is something that shouldn’t be added to the code base. Inevitably the more code one has === the more chances for failure & additional testing requirements. I think it would make more sen

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r55421079 --- Diff: README.md --- @@ -44,6 +44,53 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord - Windo

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r55420970 --- Diff: README.md --- @@ -44,6 +44,53 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord - Windo

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

2016-03-08 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/90#issuecomment-193949335 @rakatyal @nikhilkh @dblotsky @daserge Fixed your comments. Please verify this PR --- If your project is set up for it, you can reply to this em

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-08 Thread Steven Gill
I would also like to see this happen. Would this cause problems if we did this for other platforms? On Tue, Mar 8, 2016 at 11:55 AM, Shazron wrote: > See: > https://issues.apache.org/jira/browse/CB-10775 > > Problem: > For cordova-ios, "cordova platform update" does its own thing, which > causes

Re: Making plugins backward compatible to 5.1.1

2016-03-08 Thread julio cesar sanchez
I already said on the jira issue that I preffer not to add this. And cordova iOS 4.X.X breaks on iOS 6 and older, so it's a matter of time that you will have to update to cordova iOS 4 and you won't be able to support that versions. But the truth is the PR is very simple and won't make any harm to

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

2016-03-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-193942230 @stevengill @vladimir-kotikov please review when you have a moment --- If your project is set up for it, you can reply to this email and have your reply appear on G

[PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

2016-03-08 Thread Shazron
See: https://issues.apache.org/jira/browse/CB-10775 Problem: For cordova-ios, "cordova platform update" does its own thing, which causes problems. Proposal: Change "cordova platform update ios@version" to be basically an alias for: "cordova platform rm ios" "cordova platform add ios@version" ---

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

2016-03-08 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/406 CB-10679: Improving version choosing logic test coverage This adds a test plugin to improve our end to end tests related to the new plugin version choosing logic implementation. The plugin itse

[GitHub] cordova-docs pull request: CB-10813: Fix Hooks Guide

2016-03-08 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/543 CB-10813: Fix Hooks Guide Made the following changes: 1. Modified the column width to ensure that the commands are readable 2, Changed the commands for prepare, compile and buil

Re: [Vote] 4.0.1 OSX Release (attempt 2)

2016-03-08 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Tobias Bocanegra Carlos Santana The vote has passed. I will now publish to dist and npm On Sat, Mar 5, 2016 at 11:26 AM, Carlos Santana wrote: > I vote +1 > > $ coho verify-archive -r osx --tag 4.0.1 vote-osx/cord

Re: Edit to Edit on Github for Docs

2016-03-08 Thread Jesse
+1 to AB testing! > On Mar 8, 2016, at 11:02 AM, Steven Gill wrote: > > Look at us talking UX. Lets do some AB testing while we are at ;) > > On Tue, Mar 8, 2016 at 10:54 AM, Nikhil Khandelwal > wrote: > >> +1 for trying "Edit on Github" - anything that _may_ increase >> contributions to the

Re: Discuss: Moving current 'dev' documentation to 6.x

2016-03-08 Thread Steven Gill
Tweet: https://twitter.com/apachecordova/status/707280829299302400 On Tue, Mar 8, 2016 at 10:25 AM, Shazron wrote: > +++1 Excellent work > Kudos to the team that did this! > > On Tue, Mar 8, 2016 at 8:41 AM, Carlos Santana > wrote: > > Can someone tweet the blog post [1] for the new doc improve

Re: Making plugins backward compatible to 5.1.1

2016-03-08 Thread Steven Gill
Personally, I'm not a fan of adding/keeping legacy code for platforms we don't support. On Tue, Mar 8, 2016 at 9:09 AM, Thomas Allen wrote: > I opened ticket CB-10631 regarding the "Device" plugin that didn't work > when I built my app for iOS 5.1.1. I was asked by user jcesarmobile to send > an

Re: Edit to Edit on Github for Docs

2016-03-08 Thread Steven Gill
Look at us talking UX. Lets do some AB testing while we are at ;) On Tue, Mar 8, 2016 at 10:54 AM, Nikhil Khandelwal wrote: > +1 for trying "Edit on Github" - anything that _may_ increase > contributions to the docs is welcome. :) > > -Nikhil > > -Original Message- > From: Shazron [mailt

RE: Edit to Edit on Github for Docs

2016-03-08 Thread Nikhil Khandelwal
+1 for trying "Edit on Github" - anything that _may_ increase contributions to the docs is welcome. :) -Nikhil -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Tuesday, March 8, 2016 10:26 AM To: dev@cordova.apache.org Subject: Re: Edit to Edit on Github for Docs I'm a

[GitHub] cordova-docs pull request: Rewrite of storage guide.

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/531#issuecomment-193912293 LGTM. Ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Making plugins backward compatible to 5.1.1

2016-03-08 Thread Thomas Allen
I opened ticket CB-10631 regarding the "Device" plugin that didn't work when I built my app for iOS 5.1.1. I was asked by user jcesarmobile to send an email to discuss. https://issues.apache.org/jira/browse/CB-10631 Basically I submitted a patch to allow the plugin to work with iOS 5.1.1. You can

Re: Edit to Edit on Github for Docs

2016-03-08 Thread Shazron
I'm ambivalent. "Edit" is concise, and I would think most are curious enough to just click and see? On Tue, Mar 8, 2016 at 8:50 AM, Carlos Santana wrote: > The other day I was looking like crazy the doc source code that > corresponded to the page that a user was asking here in dev list where was

Re: Discuss: Moving current 'dev' documentation to 6.x

2016-03-08 Thread Shazron
+++1 Excellent work Kudos to the team that did this! On Tue, Mar 8, 2016 at 8:41 AM, Carlos Santana wrote: > Can someone tweet the blog post [1] for the new doc improvements from the > @apachecordova twitter account ? > > New Docs improvements are amazing +100 :-) > > [1]: > http://cordova.apache

[GitHub] cordova-lib pull request:

2016-03-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/commit/e1bde1afa0f22b783d3cecc5f7d14c39ab17528b#commitcomment-16568767 I fixed the issue as part of e740debffe6f83174126ba3c1711d017b3052d4f. Looks like the syntax error got introduced as part of

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-08 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/498#issuecomment-193884897 Redoing this pull request on a whole new branch, because this one-off is not going to work with all the changes @jcesarmobile is suggesting. --- If your projec

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

2016-03-08 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-docs/pull/498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request:

2016-03-08 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/commit/e1bde1afa0f22b783d3cecc5f7d14c39ab17528b#commitcomment-16567851 This change is [breaking the CI](https://ci.apache.org/waterfall?category=cordova&reload=15). Looks like there was a syntax

[GitHub] cordova-android pull request: 5.1.x fullscreen no immersive

2016-03-08 Thread oratthumzap
GitHub user oratthumzap opened a pull request: https://github.com/apache/cordova-android/pull/271 5.1.x fullscreen no immersive hi, we are using Cordova and would like to have the ability to set the Cordova activity in full screen mode, and not in an immersive mode regardless of

[GitHub] cordova-cli pull request: Remove invalid space from license in pac...

2016-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Edit to Edit on Github for Docs

2016-03-08 Thread Carlos Santana
Duh now I remembered. https://console.ng.bluemix.net/docs/services/mobile.html It's an IBM page, but still I think the change is still valuable, as user see "Edit" and might think they need a login account, and if they see "on Github" they can see that they will go to Github and related that with

Edit to Edit on Github for Docs

2016-03-08 Thread Carlos Santana
The other day I was looking like crazy the doc source code that corresponded to the page that a user was asking here in dev list where was the source code, so I assume he also didn't see the "Edit" Then someone pointed out there is an "Edit" link/button at the top right side of each page. Then I

Re: Discuss: Moving current 'dev' documentation to 6.x

2016-03-08 Thread Carlos Santana
Can someone tweet the blog post [1] for the new doc improvements from the @apachecordova twitter account ? New Docs improvements are amazing +100 :-) [1]: http://cordova.apache.org/announcements/2016/03/03/docs-improvement.html On Fri, Mar 4, 2016 at 7:56 PM Dmitry Blotsky wrote: > Hey folks,

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

2016-03-08 Thread FlossyWeb
Github user FlossyWeb commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-193845735 Hi there, Thanks @gaelenh this definitely fixes the issue, please merge guys ! --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-file-transfer pull request: Update index.md

2016-03-08 Thread k-yak
GitHub user k-yak opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/130 Update index.md fix bad command translation You can merge this pull request into a Git repository by running: $ git pull https://github.com/k-yak/cordova-plugin-file-transfe

[GitHub] cordova-windows pull request: TypeScript Error

2016-03-08 Thread cleaner321
GitHub user cleaner321 opened a pull request: https://github.com/apache/cordova-windows/pull/157 TypeScript Error Fix TypeScript error src: http://stackoverflow.com/questions/34120636/visual-studio-thinks-everything-is-a-typescript-resource You can merge this pull req

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-08 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-193655233 @nikhilkh > Are there still some test failures? No, tests should be green now. > Could you also add the travis badge for cordova-cli? Sure