Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/132#issuecomment-200192446
@sarangan12, changing `/* global describe, it, expect, beforeEach,
afterEach, spyOn, jasmine, pending */` to `/* jshint jasmine: true */` will
pro
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/42#issuecomment-200165040
Technically it is a period, but frequency is probably clearer. Perhaps
'interval' could be a choice as well.
---
If your project is set up
GitHub user zhouzhongyuan opened a pull request:
https://github.com/apache/cordova-docs/pull/566
change 'portait' to 'portrait'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhouzhongyuan/cordova-docs patch-1
Alternatively you
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/16#issuecomment-200148555
At this point it might be more sensible to drop the steps that auto search
in a few folders and instead have a simple explicity behaviour. This would cut
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/54#issuecomment-200146892
Apparently playAudioWhenScreenIsLocked is deprecated on iOS (from the
tickets I was reading today) anyway so this PR could probably be closed if that
is c
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-200146522
Just been testing this in my project, seems to work well. One issue with
this PR is that you have deleted a closing bracket on line 510 that should
still
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/77#issuecomment-200146217
Note that the first change in this PR is already included in master for
v2.2.0, I have been testing with the second change also included and that
combined
The vote has now closed. The results are:
Positive Binding Votes: 4
Steven Gill
Alexander Sorokin
Shazron Abdullah
Carlos Santana
The vote has passed.
On Tue, Mar 22, 2016 at 2:54 PM, Carlos Santana
wrote:
> I vote +1
> coho verify-archive
> coho verify-tags
> reproduce archives using coho
The vote has now closed. The results are:
Positive Binding Votes: 4
Steven Gill
Alexander Sorokin
Shazron Abdullah
Carlos Santana
The vote has passed.
On Tue, Mar 22, 2016 at 2:56 PM, Carlos Santana
wrote:
> I vote +1
> coho verify-archive
> coho verify-tags
> reproduce archives using coho
Github user rammie commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-200121717
Why is this not being merged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user ryouaki commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/109#issuecomment-200099675
this is the bug report :
[10935](https://issues.apache.org/jira/browse/CB-10935)
---
If your project is set up for it, you can reply to this email and
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/180#issuecomment-200089483
Yup it does break on Windows 8.1. Will fix it soon. Thanks for bringing
this to our attention.
---
If your project is set up for it, you can reply to t
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-docs/pull/544#issuecomment-200070628
Blargh! I need to hunt down the merge conflict before re-sending this pull
request. I have no idea what changed on this file, though.
---
If your project is set
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-docs/pull/544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user worsection commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/139#issuecomment-200051123
Will you add this fix or any alternative to fix ios file upload?
---
If your project is set up for it, you can reply to this email and have your
I vote +1
coho verify-archive
coho verify-tags
reproduce archives using coho create-archive
On Tue, Mar 22, 2016 at 5:51 PM Shazron wrote:
> I vote +1.
>
> * Ran coho verify-archive
> * Verified tag
>
>
> On Fri, Mar 18, 2016 at 6:00 PM, Steven Gill
> wrote:
> > Please review and vote on this c
I vote +1
coho verify-archive
coho verify-tags
reproduce archives using coho create-archive
Only minor thing found cordova-lib.tgz/package/node_modules/ included
more pacakges that it should, but not affect installation or functionality
On Tue, Mar 22, 2016 at 5:53 PM Shazron wrote:
> I vote
I vote +1.
* Ran coho verify-archive
* Verified tags
On Fri, Mar 18, 2016 at 12:59 PM, Steven Gill wrote:
> Please review and vote on this Tools Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10902
>
>
I vote +1.
* Ran coho verify-archive
* Verified tag
On Fri, Mar 18, 2016 at 6:00 PM, Steven Gill wrote:
> Please review and vote on this cordova-common Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-109
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
I agree to enable config.xml to be able to set or override using
config-file (i.e. any xml file including strings.xml)
I also think that adding support in config.xml and plugin.xml to edit
attributes is very helpful, this is exactly what we are doing for one of
our plugin to add the attribute andro
Github user ktop commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-29843
@infil00p can you take a look at this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/559#issuecomment-28409
Okay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/559#issuecomment-11281
We don't have a strict policy for blog posts. I think one day is good
enough. We can always update blog posts at a later date if the need arises.
---
If your
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57049010
--- Diff: tests/tests.js ---
@@ -451,11 +451,25 @@ exports.defineAutoTests = function () {
it("filetransfer.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57047593
--- Diff: tests/tests.js ---
@@ -451,11 +451,25 @@ exports.defineAutoTests = function () {
it("filetransfe
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57047060
--- Diff: tests/tests.js ---
@@ -1114,6 +1125,9 @@ exports.defineAutoTests = function () {
};
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/559#issuecomment-199960669
What is the expected review time for blog posts? I sent an email to the dev
list yesterday.
---
If your project is set up for it, you can reply to this email and
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/559#issuecomment-199960047
Lets merge and publish this! That way I can reference it in tools release
blog post.
---
If your project is set up for it, you can reply to this email and have
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/132#discussion_r57046468
--- Diff: tests/tests.js ---
@@ -451,11 +451,25 @@ exports.defineAutoTests = function () {
it("filetransfer.
The vote threads need another vote
On Fri, Mar 18, 2016 at 3:03 PM, Steven Gill wrote:
> Please review tools release blog post:
> https://github.com/apache/cordova-docs/pull/561
>
> Any other highlights I should include?
>
> -Steve
>
> On Thu, Mar 17, 2016 at 2:29 PM, Steven Gill
> wrote:
>
>>
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-199926536
@rakatyal to help review after the test failures are fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user skrosoft commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/35#issuecomment-199899458
Hi, I still have a memory problem with 2.0.1 version. Each time I call the
find() function, memory is acumulating the results, after calling the find
m
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-199892126
@dubeejw can you review your changes again , CI is failing appveyor and
travois-ci
---
If your project is set up for it, you can reply to this email and ha
GitHub user dubeejw opened a pull request:
https://github.com/apache/cordova-windows/pull/163
CB-10927 - Framework references in plugin.xml file prevent Windows
Universal projects from being used on other machines
- Stop using a hardcoded path to framework references
You ca
GitHub user cfjedimaster opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/42
Update README.md
Changed 'period' to 'frequency' in options.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cfjedimast
Yes, Simon, that's my opinion, and we should show the conficting values and
the id of the plugin with the conficting values so the user knows he has to
change the values on the config.xml or remove the plugin.
But we still will have problems if the plugin uses a hook to write values
instead of usi
Maybe the configured values of the plugins are sometimes just default
values that the user can override through the config.xml file.
What about adding a flag indicating whether the value is overridable ? My 2
cents ...
On Tue, Mar 22, 2016 at 3:02 PM, Simon MacDonald
wrote:
> So for Android's ca
So for Android's case you are thinking the order of precedence should be:
config.xml
plugin.xml
AndroidManifest.xml // created by the "cordova" cli
Then if config.xml overrides something that one of the plugins depends on
then the app won't build. I can actually get behind that proposal if I'm
un
I think, if there is a conflict between config.xml and plugin.xml we should
not build.
If we pick config.xml values, the plugins with conflicting values might not
work, and if we pick the plugin.xml values, the app might not work the way
the user wants.
I think both options are bad, the user want
GitHub user ryouaki opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/109
fix an issue of can not sync new contact into icloud which update new photo
with ABPersonSetImageData()
fix an issue of can not sync new contact into icloud which update new photo
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/162#issuecomment-199794196
@stebi, thanks for your contribution, but the issue has been fixed already
in dependency module. See apache/cordova-lib#392 The fix will be available in
When it comes to the AndroidManifest if config.xml and plugin.xml (possibly
multiple plugin.xml's) disagree on the value of an attribute:
- if the value is a boolean then it should default to 'false'. For instance
if it is an attribute like supports small screens if one plugin sets it to
false it
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Tue Mar 22 11:06:56 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
GitHub user stebi opened a pull request:
https://github.com/apache/cordova-windows/pull/162
CB-10622 Fix targetsize images being ignored
In the icon tag in config.xml the icon-"target" attribute is not read, so
MRT images are not loaded at all
e.g.
You can merge this
The disagreement could also like in a “preference” specifying a value, that is
overwritten by this fragment.
On 3/21/16, 11:28 PM, "Jesse" wrote:
>I like having the same xml fragments in config.xml as we use in plugin.xml
>
>
>parent="/manifest/application">
> android:name="https:/
47 matches
Mail list logo
