Re: Does Cordova have a problem making developers happy?

2016-04-18 Thread Shazron
Please see my comments on Robert's document, do chime in: https://github.com/cordova/cordova-discuss/pull/36 On Tuesday, March 29, 2016, Robert Posener wrote: > I did, but as my reply said, it wasn't showing up. > > Regards > *Rob Posener* > 0419 012 627 > > On 30 March

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/581#issuecomment-211647212 Let's merge this only after indexing is complete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-10981 Remove cordova-common from bund...

2016-04-18 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/419#issuecomment-211626986 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [VOTE] Plugins Release April 15, 2016

2016-04-18 Thread Shazron
I vote +1. * Verified signatures and hashes * Verified tags On Fri, Apr 15, 2016 at 2:58 PM, Steven Gill wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue:

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-18 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/581#issuecomment-211563103 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

2016-04-18 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60128184 --- Diff: lib/ParamedicPermissions.js --- @@ -0,0 +1,60 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path=

[GitHub] cordova-mobile-spec pull request: CB-11098 Allowed media from both...

2016-04-18 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/139#issuecomment-211554359 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

2016-04-18 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/581 CB-11104: Integrate Algolia Search to cordova docs @nikhilkh @dblotsky @riknoll @rakatyal Could you please review this PR? Note: Please do NOT merge this PR now. You can merge

[GitHub] cordova-mobile-spec pull request: CB-11098 Allowed media from both...

2016-04-18 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/139 CB-11098 Allowed media from both http and https in CSP tag https://issues.apache.org/jira/browse/CB-11098 You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-media pull request: Protect setVolume call in case ...

2016-04-18 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211529912 Should you instead use the ```readyPlayer(...)``` followed by seeking to the end of the file in this case ? It seems like a pattern used by

[CI] Status for 04/18/16

2016-04-18 Thread Mefire O .
Hey everyone, Here is the CI status for last week. Build Status (Pass/Total): 430 / 430 - Android on Windows 430 / 430 - Android on OS X 408 / 421 - iOS (CI failing, see CB-10475) 421 / 421 - WP 8.1 421 / 421 - Windows Store 8.1 JIRAs that need attention: - CB-10475: iOS Contacts

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

2016-04-18 Thread Quelu
Github user Quelu commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-211519224 My bad ! Thank you for the information ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

2016-04-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-211515374 This has been merged already. A plugin release is pending:

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-04-18 Thread Jesse
No, unfortunately the PhoneGap Vancouver office was closed. @purplecabbage risingj.com On Mon, Apr 18, 2016 at 10:53 AM, Ryan J. Salva wrote: > Is there still an Adobe office in Vancover? > > > Ryan J. Salva | Principal PM Manager > Visual Studio Tools for Apache

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-18 Thread jasongin
Github user jasongin closed the pull request at: https://github.com/apache/cordova-cli/pull/244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: Apache Con NA May 11-13 in Vancouver, BC

2016-04-18 Thread Ryan J. Salva
Is there still an Adobe office in Vancover? Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache Cordova rsa...@microsoft.com 425 706 5270 office 206 612 5079 mobile -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Monday, April 18, 2016 1:51 PM To:

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-04-18 Thread Shazron
Also, I would recommend an autumn date, where (presumably) everybody will be available. Preferably at one of our contributor sites that hasn't hosted before? We've had Google (Waterloo, ON) and Microsoft (Redmond, WA) previously. On Mon, Apr 18, 2016 at 11:34 AM, Jesse

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/244#issuecomment-211497103 Merged with commit: 6e2d201. Could you please close this PR now? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-medic pull request: Ensure Android adb logs have timestamp

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-test-framework pull request: Add spec started/compl...

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-04-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-211493781 It still needs to be able to update it dynamically. I would refactor it to not remove the existing code, but create a new `-

Re: Apache Con NA May 11-13 in Vancouver, BC

2016-04-18 Thread Jesse
Vancouver would be awesome! Just not as soon as ApacheCon. @purplecabbage risingj.com On Mon, Apr 18, 2016 at 8:42 AM, Ryan J. Salva wrote: > Regrettably, Microsoft won't be attending ApacheCon this year either. > Without critical mass from the other Cordova

RE: [DISCUSS] Cordova-common@1.2.0 release

2016-04-18 Thread Steven Gill
+1 On Apr 18, 2016 4:41 AM, "Vladimir Kotikov (Akvelon)" < v-vlk...@microsoft.com> wrote: > The release notes are: > > * CB-11022 Save modulesMetadata to both www and platform_www when necessary > * CB-10833 Deduplicate common logic for plugin installation/uninstallation > * CB-10822 Manage

RE: [VOTE] Plugins Release April 15, 2016

2016-04-18 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified signatures and hashes * Verified tags * Verified that plugins can be added correctly to blank app * Verified that blank app can be successfully built and ran (windows and android) * Verified that browserified app can be successfully built and ran (windows and android) *

[GitHub] cordova-android pull request: overrideBackbutton(boolean) from Cor...

2016-04-18 Thread dheeran1
Github user dheeran1 closed the pull request at: https://github.com/apache/cordova-android/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: Protect setVolume call in case ...

2016-04-18 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211453937 Instead of catching the `NullPointerException`, should you test for `if(this.player)` - I'm assuming that's what is null in this scenario. --- If your

RE: Apache Con NA May 11-13 in Vancouver, BC

2016-04-18 Thread Ryan J. Salva
Regrettably, Microsoft won't be attending ApacheCon this year either. Without critical mass from the other Cordova contributors, it simply doesn't make sense (as much as I'd love to visit Vancouver). Does anyone have a recommended destination, host or occasion for the F2F? rjs Ryan J. Salva

[GitHub] cordova-android pull request: overrideBackbutton(boolean) from Cor...

2016-04-18 Thread dheeran1
GitHub user dheeran1 opened a pull request: https://github.com/apache/cordova-android/pull/294 overrideBackbutton(boolean) from CoreAndroid.java has no effect Can't override android back button You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...

2016-04-18 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-ios/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...

2016-04-18 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/213#issuecomment-211430445 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-11066 Remove uap prefixed capabil...

2016-04-18 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/168 CB-11066 Remove uap prefixed capabilities when plugin has added regular ones This fixes a problem when some of capabilities, added by plugin are being modified at 'prepare' stage

[GitHub] cordova-android pull request: Update CoreAndroid.java

2016-04-18 Thread dheeran1
GitHub user dheeran1 opened a pull request: https://github.com/apache/cordova-android/pull/293 Update CoreAndroid.java No modifier (package-private) class to public class You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

2016-04-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/580 CB-11077 backbutton does not minimize app [Jira issue](https://issues.apache.org/jira/browse/CB-11077) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-battery-status pull request: CB-10398 Added Appium ...

2016-04-18 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

RE: [DISCUSS] Cordova-common@1.2.0 release

2016-04-18 Thread Vladimir Kotikov (Akvelon)
The release notes are: * CB-11022 Save modulesMetadata to both www and platform_www when necessary * CB-10833 Deduplicate common logic for plugin installation/uninstallation * CB-10822 Manage plugins/modules metadata using PlatformJson * CB-10940 Can't add Android platform from path * CB-10965

[DISCUSS] Cordova-common@1.2.0 release

2016-04-18 Thread Vladimir Kotikov (Akvelon)
Does anyone have any reason to delay the release? Any outstanding patches to land? If not, I will start the release tomorrow. - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional

[GitHub] cordova-windows pull request: CB-11022 Duplicate www files on plug...

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-11022 Duplicate www files on plug...

2016-04-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/167#discussion_r60028006 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -123,24 +123,27 @@ var handlers = { throw new CordovaError(' tag

[GitHub] cordova-lib pull request: CB-11022 Save modulesMetadata to both ww...

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/427 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...

2016-04-18 Thread Quelu
Github user Quelu commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-211265699 Any chances to get this merged ? :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as