[GitHub] cordova-docs pull request: ToC Generation Refactor

GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/583 ToC Generation Refactor **Note**: this PR is easier to review one commit at a time, and the commit messages roughly describe each change. Changes: - now `*-src.yml` files are

[GitHub] cordova-docs pull request: ToC Generation Refactor

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/583#issuecomment-212213980 @riknoll @rakatyal @nikhilkh please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-file pull request: CB-11115 android: Fixing test co...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-file/pull/178 CB-5 android: Fixing test content provider Seems like `FileDescriptor.toString()` changed in Android N and it broke three of our tests. This removes our dependency on the output of

RE: [DISCUSS] Faster incremental builds

I collected data for 4 projects with varying numbers and sizes of source files (mostly .js and .png): Tiny : 17 files, 0.24 MB (A new Cordova project created from the VS template) Small : 55 files, 7.7 MB Medium:242 files, 44 MB Large : 12,923 files, 134 MB

[GitHub] cordova-windows pull request: CB-11066 Remove uap prefixed capabil...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/168#discussion_r60334412 --- Diff: template/cordova/lib/ConfigChanges.js --- @@ -0,0 +1,85 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License");

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60334146 --- Diff: www/static/css-src/main.scss --- @@ -194,6 +194,23 @@ code { color: #00; } +/* algolia search formatting */

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/581#issuecomment-212179026 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Clarify the docs w.r.t. directory struct...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-cli/pull/245 Clarify the docs w.r.t. directory structure You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilkh/cordova-cli patch-1 Alternatively

[GitHub] cordova-windows pull request: CB-11066 Remove uap prefixed capabil...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/168#discussion_r60332098 --- Diff: template/cordova/lib/ConfigChanges.js --- @@ -0,0 +1,85 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License");

[GitHub] cordova-plugin-file-transfer pull request: CB-11067 - Adds content...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/140#issuecomment-212176107 @daserge to help review. Looks like we might need some tests for this as well. --- If your project is set up for it, you can reply to this

[GitHub] cordova-windows pull request: CB-11066 Remove uap prefixed capabil...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/168#discussion_r60331966 --- Diff: template/cordova/Api.js --- @@ -29,7 +29,7 @@ var ActionStack = require('cordova-common').ActionStack; var CordovaError =

[GitHub] cordova-plugin-statusbar pull request: New feature 'styleAndroidTr...

Github user MrARC commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/51#issuecomment-212174489 I tested this feature on Motorola devices and it looks good, but this isn't the case when testing on Samsung and Sony Xperia devices, the statusbar

[GitHub] cordova-docs pull request: CB-11091 added plugins release blog pos...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/582#issuecomment-212171858 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329788 --- Diff: conf/_config.yml --- @@ -81,3 +81,5 @@ kramdown: # exclude these directories from the build exclude: - static/css-src

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-docs/pull/581#issuecomment-212170562 @dblotsky Let me know when you are done... I will merge the commits to one commit. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329745 --- Diff: conf/_config.yml --- @@ -81,3 +81,5 @@ kramdown: # exclude these directories from the build exclude: - static/css-src

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329685 --- Diff: www/_includes/algolia.html --- @@ -0,0 +1,14 @@ +{% if page.version %} +{% assign version = page.version %} +{% else %}

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329718 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,20 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329698 --- Diff: www/_includes/header.html --- @@ -29,18 +29,24 @@ Get Started

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329672 --- Diff: conf/_config.yml --- @@ -81,3 +81,5 @@ kramdown: # exclude these directories from the build exclude: - static/css-src

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60329456 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329201 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,20 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60329126 --- Diff: www/_includes/header.html --- @@ -29,18 +29,24 @@ Get Started

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328845 --- Diff: www/_includes/algolia.html --- @@ -0,0 +1,14 @@ +{% if page.version %} +{% assign version = page.version %} +{% else %} +

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328800 --- Diff: conf/_config.yml --- @@ -81,3 +81,5 @@ kramdown: # exclude these directories from the build exclude: - static/css-src

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328734 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/93#issuecomment-212168418 Very helpful guide! I was able to get the tests running on my machine (for Android, didn't try iOS). One thing to note is that it seems like the tests are very

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328488 --- Diff: www/static/css-src/main.scss --- @@ -194,6 +194,23 @@ code { color: #00; } +/* algolia search formatting */

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328530 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328452 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328435 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60328400 --- Diff: www/_includes/head.html --- @@ -18,6 +18,9 @@ {% endif %} + +

[GitHub] cordova-docs pull request: CB-11091 added plugins release blog pos...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/582#issuecomment-21216 It might be helpful to mention that cordova-plugin-compat is replacing the PermissionHelper.java file that was duplicated in all the plugin repos. There were a

Re: [DISCUSS] Plugins release

Please review the plugins release blog post https://github.com/apache/cordova-docs/pull/582 On Thu, Apr 14, 2016 at 6:39 PM, Carlos Santana wrote: > No objections, plugins owners could benefit of the new way to handle the > android permissions with common plugin > > On

[GitHub] cordova-docs pull request: CB-11091 added plugins release blog pos...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/582 CB-11091 added plugins release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-docs master Alternatively

Re: [DISCUSS] Faster incremental builds

Sounds like a worthy cause. Do you have any stats on how much time is saved? Definitely put it behind the --incremental flag to start. On Tue, Apr 19, 2016 at 2:43 PM, Jason Ginchereau wrote: > We've had a few customers complain that the dev inner loop for Cordova >

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60320027 --- Diff: main.js --- @@ -37,6 +39,30 @@ if (pathToParamedicConfig || // --config ParamedicConfig.parseFromFile(pathToParamedicConfig):

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60319977 --- Diff: main.js --- @@ -37,6 +39,30 @@ if (pathToParamedicConfig || // --config ParamedicConfig.parseFromFile(pathToParamedicConfig):

[GitHub] cordova-plugin-media pull request: Protect setVolume call in case ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-212146985 @fafaman that does sound like a `configChanges` issue as Nikhil mentioned. To prevent the restart, you need to add the `uiMode` value in the

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60319371 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path =

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60319212 --- Diff: lib/ParamedicConfig.js --- @@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) { startPort:

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60318605 --- Diff: lib/ParamedicConfig.js --- @@ -36,8 +36,10 @@ ParamedicConfig.parseFromArguments = function (argv) { startPort:

[DISCUSS] Faster incremental builds

We've had a few customers complain that the dev inner loop for Cordova apps is slow compared to native app development. So recently I've been looking at ways to optimize it. The two largest pieces of a Cordova build are "prepare" and "compile" phases. While there's not much we can realistically

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/429#discussion_r60314872 --- Diff: cordova-common/src/FileUpdater.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60314159 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60313932 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60313371 --- Diff: www/static/css-src/main.scss --- @@ -194,6 +194,23 @@ code { color: #00; } +/* algolia search formatting */

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60313002 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60312938 --- Diff: www/_layouts/base.html --- @@ -3,12 +3,27 @@ --- - +{% if page.language %} +{% assign language =

[GitHub] cordova-docs pull request: CB-11104: Integrate Algolia Search to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/581#discussion_r60312014 --- Diff: www/_includes/head.html --- @@ -18,6 +18,9 @@ {% endif %} + +

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-android/pull/295 CB-7: Use FileUpdater to optimize prepare for android platform This uses the FileUpdater module added in https://github.com/apache/cordova-lib/pull/429 to optionally skip copying

[GitHub] cordova-android pull request: CB-11036 'args.slice is not a functi...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/291#issuecomment-212126887 Should the cloning happen in `cordova-lib` instead - to ensure isolation? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-windows pull request: CB-11066 Remove uap prefixed capabil...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/168#issuecomment-212124345 @rakatyal to help review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media pull request: Protect setVolume call in case ...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-212122345 @riknoll to recommend on how to handle Android activity restart when ['configchanges'

[GitHub] cordova-lib pull request: Add FileUpdater module to cordova-common

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-212121255 I opened CB-7 to track this work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r60307151 --- Diff: lib/ParamediciOSPermissions.js --- @@ -0,0 +1,43 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path =

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/94#discussion_r60300760 --- Diff: lib/medicPermissions.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path=

[GitHub] cordova-plugin-contacts pull request: [CB-8076] Provide error supp...

GitHub user surajpindoria opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/122 [CB-8076] Provide error support for browser platform You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/94#discussion_r60300110 --- Diff: lib/medicPermissions.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* jshint node: true */ +var path=

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/94#issuecomment-212074252 @sarangan12 could you please review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/94#issuecomment-212074104 This PR ports part of the following paramedic PR to medic: https://github.com/apache/cordova-paramedic/pull/4 --- If your project is set up for it, you can

[GitHub] cordova-medic pull request: CB-10475 (cordova-plugin-contacts) Gra...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-medic/pull/94 CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions while… … running on iOS simulator You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/428#issuecomment-212067153 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/93#discussion_r60287104 --- Diff: APPIUM.md --- @@ -0,0 +1,64 @@ +Cordova Medic Appium Runner +=== + +This document describes a method

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60286817 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60286669 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60286296 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-plugin-contacts pull request: [CB-8076] Add cordova-plugin...

Github user surajpindoria closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/93#discussion_r60279829 --- Diff: APPIUM.md --- @@ -0,0 +1,64 @@ +Cordova Medic Appium Runner +=== + +This document describes a method

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-medic/pull/93#issuecomment-212044839 Minor comments. Otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/93#discussion_r60279661 --- Diff: APPIUM.md --- @@ -0,0 +1,64 @@ +Cordova Medic Appium Runner +=== + +This document describes a method

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/93#discussion_r60278921 --- Diff: APPIUM.md --- @@ -0,0 +1,64 @@ +Cordova Medic Appium Runner +=== + +This document describes a method

[GitHub] cordova-lib pull request: Add FileUpdater module to cordova-common

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-212039256 @nikhilkh @vladimir-kotikov please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: Add FileUpdater module to cordova-common

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-lib/pull/429 Add FileUpdater module to cordova-common The new FileUpdater module contains a few functions that enable optimized file copies by comparing timestamps. These functions are primarily

Re: [VOTE] Plugins Release April 15, 2016

The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Alexander Sorokin Shazron Abdullah The vote has passed. I will share the blog post for review, and then publish and announce the release. On Mon, Apr 18, 2016 at 3:56 PM, Shazron wrote: > I vote

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r60276684 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https =

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r60274259 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https =

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r60274232 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https =

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r60274095 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https =

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/87#discussion_r60274167 --- Diff: medic/medic-downloadlogs.js --- @@ -0,0 +1,80 @@ +var path = require('path'), +fs = require('fs'), +https =

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60268796 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60268018 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-medic pull request: CB-11112 Added Appium documentation

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/93 CB-2 Added Appium documentation https://issues.apache.org/jira/browse/CB-2 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60264056 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60263398 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/428#issuecomment-212000688 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60262487 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60262428 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-docs pull request: CB-11077 backbutton does not minimize a...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/580#discussion_r60262381 --- Diff: www/docs/en/dev/cordova/events/events.md --- @@ -323,6 +323,16 @@ function onBackKeyDown() { } ``` +### Windows Quirks

[GitHub] cordova-plugin-dialogs pull request: Simply add Browser to support...

GitHub user cfjedimaster opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/72 Simply add Browser to supported platforms You can merge this pull request into a Git repository by running: $ git pull

Re: Why does the Dialogs plugin in inject itself into navigator and has no browser support?

So on plugins.cordova.io, if you filter by Browser, Dialogs *does* show up. But when you go to the docs, it isn't shown as supported - so that could be a minor doc bug. I'll do a PR. On Tue, Apr 19, 2016 at 10:22 AM, Raymond Camden wrote: > I'm looking at the dialog

Re: Why does the Dialogs plugin in inject itself into navigator and has no browser support?

I'm looking at the dialog plugin, and I swear I see code for browser support already in there. Going to test a bit. On Thu, Apr 14, 2016 at 3:59 PM, Jesse wrote: > Notification pre-dates the use of plugin namespaces, most plugins > originally were hung off of navigator

[GitHub] cordova-medic pull request: CB-11084 CameraUsesGeolocation=true fo...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-11084 CameraUsesGeolocation=true fo...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-medic/pull/92#issuecomment-211959785 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-network-information pull request: fixed two potenti...

GitHub user AllenConquest opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/41 fixed two potential memory leaks when doing Analyze on iOS 9 When you perform an Analyze using Xcode 7, two places are identified as potential memory leaks. These

[VOTE] Cordova-common@1.2.0 release

Please review and vote on this cordova-common release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11096 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11096/ The

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/428 CB-10761 Resore plugins saved without spec attribute This PR updates plugin restore logic to restore plugins that were added to plugin.xml without `spec` attribute. See

[GitHub] cordova-android pull request: CB-11015 Error adding plugin with gr...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

Github user GustavoCostaW commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/544#discussion_r60228374 --- Diff: www/docs/en/dev/guide/platforms/android/webview.md --- @@ -29,106 +29,86 @@ components can communicate with each other, see Application

[GitHub] cordova-android pull request: CB-11015 Error adding plugin with gr...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/292#issuecomment-211913900 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

  1   2   >