Hey
So, it's been a while, but it looks like we should really drop support for
ICS, because Crosswalk is dropping support for ICS.
https://crosswalk-project.org/blog/deprecate-40.html
So, yeah, I think we should drop support for ICS. I know it's been a "Meh,
why not?" thing for people to suppor
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217338006
Yes it is needed. jQuery mobile broke because apps were not permitted to
xhr to their own resources.
It IS browser functionality, BUT we still ne
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217334128
It seems like this whole test suite is only about checking browser/webview
functionality.
Do we still really need them ?
---
If your project is set up
Github user robario commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/138#issuecomment-217319724
I confirmed it in the repository. I'm waiting for the next release into
npmjs.com.
---
If your project is set up for it, you can reply to this em
Github user robario closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r62273198
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
var args =
GitHub user adzellman opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/61
CB-11212 iOS: Explicitly set the bundle for images
- set the bundle to the CDVCapture's bundle instead of assuming
application bundle.
You can merge this pull request
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/140
CB-11050 Removing the flaky XHR Test
This test isn't really needed since it's just checking the browser's
functionality.
You can merge this pull request into a Git repository by runn
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217307363
@sarangan12 , @omefire: Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/434
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217283363
Great! Thanks @jasongin! Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217281613
As discussed, I tested this with symbolic links both at the root and in a
subdirectory. It works fine without any special symlink handling in the code.
---
If you
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r62252220
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,20 +22,20 @@ var fs = require('fs');
var path = require('path');
var _ = require('undersc
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/434#issuecomment-217265794
Looking to merge this by EOD today if there are no other concerns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r62247519
--- Diff: cordova-lib/cordova-lib.js ---
@@ -18,19 +18,35 @@
*/
// For now expose plugman and cordova just as they were in the old repos
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-motion/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217259632
a comment would also be great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#discussion_r62237574
--- Diff: tests/tests.js ---
@@ -122,6 +122,7 @@ exports.defineAutoTests = function () {
describe("watchAcceleration",
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217239510
Other than the minor stuff mentioned, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217238656
+1 . Introducing a delta for this kind of comparisons is a good strategy
for this issue.
---
If your project is set up for it, you can reply to th
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#discussion_r62233809
--- Diff: tests/tests.js ---
@@ -122,6 +122,7 @@ exports.defineAutoTests = function () {
describe("watchAcceleration", fun
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217236642
@nikhilkh waiting on you. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Yeah, lets get this in and create a board for cordova-android 6.0.x so
other can help pitch in.
Simon Mac Donald
http://hi.im/simonmacdonald
On Wed, May 4, 2016 at 10:09 AM, Joe Bowser wrote:
> Hey, I'm bumping this thread up and creating an issue for this.
>
> https://issues.apache.org/jira/b
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43
CB-11188: cordova-plugin-device-motion-tests are failing in CI
The error is happening in an assert statement where it tries to compare two
timestamp values. This kind of comp
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-217228255
@ktop thanks for the hint about running `cordova-coho/coho npm-link`. Once
I did I was able to get your code to run. It seems to be working pretty good to
me. So I
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/209
CB-11183 Appium tests: Added image verification
https://issues.apache.org/jira/browse/CB-11183
You can merge this pull request into a Git repository by running:
$ git pull http
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/102#discussion_r62209585
--- Diff: src/android/SplashScreen.java ---
@@ -300,6 +304,23 @@ public void run() {
// Create and show the di
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-lib/pull/435
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/435
Disable e2e to decrease coverage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib disable_e2e
Alterna
GitHub user morki opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/102
Statusbar color
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madvision/cordova-plugin-splashscreen master
Alternatively y
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-217091665
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
33 matches
Mail list logo
