[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62777073 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/599#issuecomment-218331338 Thanks, comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62776600 --- Diff: www/privacy/index.md --- @@ -0,0 +1,22 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy +

RE: [DISCUSS] Cordova tools release

I expect it to be merged in by tomorrow EOD or day Thursday morning. If it's still not merged in by then, I wouldn't want to hold the release any longer. Thanks, Omar Mefire -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 10, 2016 2:39 PM To:

[GitHub] cordova-ios pull request: Use "cdv_" prefixed scrollView for UIVie...

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/187#discussion_r62772944 --- Diff: CordovaLib/Classes/Public/CDVPlugin.m --- @@ -25,11 +25,11 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/174#issuecomment-218324502 Oh, yeah I'll update those tests. --- In reply to: [218305527](https://github.com/apache/cordova-windows/pull/174#issuecomment-218305527)

[GitHub] cordova-ios pull request: 4.0.x

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: - fix generate .ipa ios

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/207#issuecomment-218323850 Any update on this? If not I will probably close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request: Use "cdv_" prefixed scrollView for UIVie...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/187#issuecomment-218323149 I understand why this change should be made. However, since it is part of the public API (it is part of CDVPlugin), any changes to this will have to go in a major

[GitHub] cordova-ios pull request: CB-10695 Replacing SDK/ARCH parameters b...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-10695 Replacing SDK/ARCH parameters b...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/197#issuecomment-218318589 Successfully manual test by creating a new project and adding the platform by specifying this repo with the changes and: ``` cordova emulate ios cordova

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media-capture pull request: CB-10554: Implementing ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62768428 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62767415 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62766681 --- Diff: doc/cordova.txt --- @@ -23,6 +23,12 @@ Project Commands serve .. Run project with a local webserver

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62766491 --- Diff: www/privacy/index.md --- @@ -0,0 +1,22 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy +

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62766349 --- Diff: www/privacy/index.md --- @@ -0,0 +1,22 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy

[GitHub] cordova-cli pull request: Telemetry

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62765915 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user axemclion commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62764381 --- Diff: www/privacy/index.md --- @@ -0,0 +1,22 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user axemclion commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62764282 --- Diff: www/privacy/index.md --- @@ -0,0 +1,22 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy +

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user axemclion commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62764339 --- Diff: www/privacy/index.md --- @@ -0,0 +1,22 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy +

[GitHub] cordova-windows pull request: CB-11117: Optimize prepare for windo...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/174#issuecomment-218305527 Looks like there are some unit test failures --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: Update about easing of Apple IOS restri...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Fixed Typo: ccordova to cordova

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Update SQLite plugin details

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/600 Update SQLite plugin details @brodybits to help review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilkh/cordova-docs patch-6

[GitHub] cordova-docs pull request: Fix URL to cordova-sqlite-ext plugin Re...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Fixed a typo in a title

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Update index.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: change 'portait' to 'portrait'

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62759764 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-docs pull request: Update images.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Update plugman.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Update Win8 plugin.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Edit commands

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62758588 --- Diff: spec/cli.spec.js --- @@ -50,19 +56,34 @@ describe("cordova cli", function () { beforeEach(function () { });

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62758273 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

Re: [DISCUSS] Cordova tools release

When do you expect to merge it in? On Tue, May 10, 2016 at 2:19 PM, Mefire O. wrote: > I'd like to get the telemetry feature out with this release. > > Thanks, > Omar Mefire > > -Original Message- > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]

[GitHub] cordova-cli pull request: Telemetry

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218299896 Related: https://github.com/apache/cordova-docs/pull/599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/599#issuecomment-218299426 What it looks like: http://imgur.com/FSDAifF --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/599#issuecomment-218298615 http://imgur.com/FSDAifF --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62755937 --- Diff: www/privacy/index.md --- @@ -0,0 +1,21 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy +

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/599#discussion_r62755904 --- Diff: www/privacy/index.md --- @@ -0,0 +1,21 @@ +--- +layout: page +title: Privacy Policy +--- + +# Privacy Policy +

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/599#issuecomment-218296850 @axemclion, @nikhilkh to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Telemetry: Privacy Policy

GitHub user omefire opened a pull request: https://github.com/apache/cordova-docs/pull/599 Telemetry: Privacy Policy You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-docs TelemetryPrivacyPolicy Alternatively you

RE: [DISCUSS] Cordova tools release

I'd like to get the telemetry feature out with this release. Thanks, Omar Mefire -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Tuesday, May 10, 2016 12:47 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Cordova tools release +1 Thanks

[GitHub] cordova-plugin-camera pull request: Add pull request template

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218282825 great points @tony-- ! +1 to all of 'em --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera pull request: Add pull request template

Github user tony-- commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218277348 There are a couple places that contributor workflow is documented: The wiki has a [contributor workflow

[GitHub] cordova-plugin-camera pull request: Add pull request template

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218265034 +1 to the PR title suggestion The icla is NOT actually required for smaller changes, and we should only be enforcing this for large/deep

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62734243 --- Diff: lib/utils/utilities.js --- @@ -50,10 +50,14 @@ function getSimId() { if (findSimResult.code > 0) {

Cordova Monthly Hangouts

It has been a while since all of us met, so I was wondering if it would help to do a Cordova Monthly hangout ? I also understand that we have Phonegap day EU this month, and maybe we could use that timeframe to get more folks involved in the hangout ? For the rest of us who could not attend

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62733686 --- Diff: lib/paramedic.js --- @@ -175,39 +178,58 @@ ParamedicRunner.prototype.runTests = function() { reject(new Error('device is

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62733344 --- Diff: lib/ParamedicTargetChooser.js --- @@ -0,0 +1,127 @@ +var Q = require('q'); +var shelljs = require('shelljs'); +var path

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62733203 --- Diff: lib/ParamedicTargetChooser.js --- @@ -0,0 +1,127 @@ +var Q = require('q'); +var shelljs = require('shelljs'); +var path

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62730561 --- Diff: lib/ParamedicAppUninstall.js --- @@ -0,0 +1,66 @@ +var shelljs = require('shelljs'); +var path= require('path'); +var fs

[GitHub] cordova-plugin-camera pull request: Add pull request template

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218253991 Do we need to provide a link for CCLA info just in case? Can we also suggest a format for PR titles? Something like: ``` [CB-12345]: Short

[GitHub] cordova-paramedic pull request: Choose Target and use it for loggi...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/5#discussion_r62729774 --- Diff: lib/ParamedicAppUninstall.js --- @@ -0,0 +1,66 @@ +var shelljs = require('shelljs'); +var path= require('path'); +var fs

RE: Github issue and PR templates

I have submitted a PR to add a pull request to cordova-plugin-camera: https://github.com/apache/cordova-plugin-camera/pull/213 Please review and provide feedback. I intend to add this to all other repos. -Nikhil -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com]

[GitHub] cordova-plugin-camera pull request: Add pull request template

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/213 Add pull request template You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera pr-template

[GitHub] cordova-medic pull request: CB-11237: linking cordova-fetch

Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-11237: linking cordova-fetch

Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/102#issuecomment-218225885 @stevengill no worries! Thanks for taking a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62710076 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62709210 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708834 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708649 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708496 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62708439 --- Diff: src/cli.js --- @@ -235,41 +317,58 @@ function cli(inputArgs) { throw new CordovaError(msg); } -

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62707187 --- Diff: src/telemetry.js --- @@ -0,0 +1,132 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62705738 --- Diff: spec/cli.spec.js --- @@ -50,19 +56,34 @@ describe("cordova cli", function () { beforeEach(function () { });

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62705505 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62705209 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62704961 --- Diff: doc/telemetry.txt --- @@ -0,0 +1,24 @@ +Synopsis + +cordova-cli telemetry [STATE] + + STATE: on|off +

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62704887 --- Diff: doc/cordova.txt --- @@ -23,6 +23,12 @@ Project Commands serve .. Run project with a local webserver

[GitHub] cordova-cli pull request: Telemetry

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r62704632 --- Diff: doc/cordova.txt --- @@ -43,4 +49,7 @@ Examples cordova-cli requirements android cordova-cli build android --verbose

proposal for new core plugin to control screen orientation

The proposal is to create a new core plugin that enables the user to dynamically control the orientation of their app. This plugin would be based on the W3C screen-orientation spec [1]. This was originally proposed via CB-9528 [2] (which currently has 10 votes and 16 watchers, indicating strong

RE: Node 6.x and Cordova CLI

Small update. Looks like failing jshint in https://github.com/apache/cordova-lib/pull/437 is another Node 6.x (In particular npm@3.x) issue. Corresponding bug is filed here: https://github.com/npm/npm/issues/10343. Hopefully this doesn't affect regular users, as the problem only can be seen

[GitHub] cordova-lib pull request: CB-11200 Bump xcode dependency and updat...

Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/437#issuecomment-218113832 ## [Current coverage][cc-pull] is **80.59%** > Merging [#437][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

RE: [DISCUSS] Cordova tools release

+1 Thanks for handling cordova-common release - there is probably not much sense in releasing it separately (as I was planning initially) when other components also need to be released. - Best regards, Vladimir -Original Message- From: julio cesar sanchez

[GitHub] cordova-windows pull request: Fix build result when using --bundle...

Github user CSharpFan commented on the pull request: https://github.com/apache/cordova-windows/pull/175#issuecomment-218070737 `npm install lodash --save` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-medic pull request: CB-11237: linking cordova-fetch

Github user stevengill commented on the pull request: https://github.com/apache/cordova-medic/pull/102#issuecomment-218068505 LGTM too! Sorry I forgot about medic :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-10034 Addresses Embedded/Linked/Signe...

Github user robertoandrade commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/399#discussion_r62616494 --- Diff: cordova-lib/package.json --- @@ -40,7 +40,7 @@ "underscore": "1.7.0", "unorm": "1.3.3",

[GitHub] cordova-lib pull request: CB-10034 Addresses Embedded/Linked/Signe...

Github user robertoandrade commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/399#discussion_r62616280 --- Diff: cordova-lib/package.json --- @@ -40,7 +40,7 @@ "underscore": "1.7.0", "unorm": "1.3.3",