[GitHub] cordova-android issue #315: CB-11078 fixed "Empty string for BackgroundColor...

Github user daserge commented on the issue: https://github.com/apache/cordova-android/pull/315 Ensure you are creating a PR from the correct branch - it should be https://github.com/akilawickey/cordova-android -> master (and now it is coming from `5.2.x`). Also please rename

Re: Finding a Bug fix Apache cordova

Ok i think i have done some upgrade in the Android Studio IDE. Ok i'll check it again Thank you On Wed, Jul 13, 2016 at 11:22 AM, Jesse wrote: > The fact that you changed 64 files is probably a red flag, I would expect > this to be a 1 or 2 line fix. > I'll look more in

Re: Finding a Bug fix Apache cordova

The fact that you changed 64 files is probably a red flag, I would expect this to be a 1 or 2 line fix. I'll look more in the morning. > On Jul 12, 2016, at 10:27 PM, Akila Wicky wrote: > > HI all, > > i fixed CB-11078 fixed "Empty string for BackgroundColor preference

Re: Starting Bug fixing Apache cordova

Hi, I have searched bug from issue tracker. It is CB-11333 *`cordova build` missing packages are not installed when you are prompted to install for it* . Can i get some help for this? Thanks.. On Jul 7, 2016 17:42, "julio cesar sanchez"

Re: Finding a Bug fix Apache cordova

HI all, i fixed CB-11078 fixed "Empty string for BackgroundColor preference crashes application" issue but when i pull request it to the main branch it shows 2 failing and 1 successful checks. failing checks are * continuous-integration/appveyor/pr and * *

Nightly build #69 for cordova has failed

Nightly build #69 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/69/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/69/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on the issue: https://github.com/apache/cordova-ios/pull/234 Writing tests currently. Thank you, @shazron! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70545166 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70541974 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70541767 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var

[GitHub] cordova-docs issue #614: CB-11023 New edit-config tag in plugin.xml

Github user riknoll commented on the issue: https://github.com/apache/cordova-docs/pull/614 That make sense to me. I added a few more comments, but otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request #614: CB-11023 New edit-config tag in plugin.xml

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/614#discussion_r70540948 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -365,6 +365,111 @@ For windows-specific attributes: ``` The above example will set pre-8.1

[GitHub] cordova-docs pull request #614: CB-11023 New edit-config tag in plugin.xml

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/614#discussion_r70540822 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -365,6 +365,111 @@ For windows-specific attributes: ``` The above example will set pre-8.1

[GitHub] cordova-docs pull request #614: CB-11023 New edit-config tag in plugin.xml

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/614#discussion_r70540748 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -365,6 +365,111 @@ For windows-specific attributes: ``` The above example will set pre-8.1

[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70534998 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -66,17 +66,19 @@ var handlers = { install:function(obj,

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70534885 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -91,18 +93,29 @@ var handlers = { } },

[GitHub] cordova-android pull request #315: CB-11078 fixed "Empty string for Backgrou...

GitHub user akilawickey opened a pull request: https://github.com/apache/cordova-android/pull/315 CB-11078 fixed "Empty string for BackgroundColor preference crashes application" issue A preference of will cause an a cordova application to crash on startup with a

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70526583 --- Diff: bin/templates/scripts/cordova/lib/podMod.js --- @@ -0,0 +1,162 @@ +var fs = require('fs'); +var util = require('util'); +var

Re: [Vote] Cordova-android 5.2.1 release

+1 * ran coho verify-archive * tested platform add via github * mobilespec test * verified releasenotes On Tue, Jul 12, 2016 at 6:25 AM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > I vote +1. > > * Verified archives via `coho verify-archive` > * Verified tags manually > *

Re: Proof of Concept: Plugins as Android Modules

Hey Does anyone have a solution to the problem I'm facing with Gradle dependencies. I can use some more eyeballs on this. Thanks Joe On Mon, Jun 27, 2016 at 1:57 PM, Joe Bowser wrote: > I know, that's extremely annoying, and I would like to remove that > sometime in the

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70507754 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, installOptions) {

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70507813 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin, installOptions) { *

[GitHub] cordova-ios issue #235: [CB-11562] Generate .ipa

Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/235 ## [Current coverage][cc-pull] is **51.81%** > Merging [#235][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #235 diff

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70496395 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, installOptions) {

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70491773 --- Diff: bin/templates/scripts/cordova/Api.js --- @@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, installOptions) {

[GitHub] cordova-ios pull request #235: [CB-11562] Generate .ipa

GitHub user ramonornela opened a pull request: https://github.com/apache/cordova-ios/pull/235 [CB-11562] Generate .ipa Support to generation .ipa You can merge this pull request into a Git repository by running: $ git pull https://github.com/bluebile/cordova-ios master

[GitHub] cordova-docs issue #614: CB-11023 New edit-config tag in plugin.xml

Github user ktop commented on the issue: https://github.com/apache/cordova-docs/pull/614 I shortened the AndroidManifest to snippets. I could see the force add content going into both locations, but in the CLI guide it should be more describing the error about conflicting

[GitHub] cordova-lib issue #459: CB-11493: Add cordova emulate option to skip prepare

Github user gruppjo commented on the issue: https://github.com/apache/cordova-lib/pull/459 Hello. How can I get anyone to look at this? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[Vote] Cordova-windows 4.1.1 release

Please review and vote on this Cordova-windows 4.1.1 release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11552 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11552

RE: [Vote] Cordova-android 5.2.1 release

I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core

[GitHub] cordova-plugin-camera issue #219: Dont work camera on Android

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/219 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-windows issue #185: CB-11558 Make windows plugin rm remove ProjectRe...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/185 ## [Current coverage][cc-pull] is **72.55%** > Merging [#185][cc-pull] into [master][cc-base-branch] will increase coverage by **0.05%** ```diff @@ master

[GitHub] cordova-windows pull request #185: CB-11558 Make windows plugin rm remove Pr...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/185 CB-11558 Make windows plugin rm remove ProjectReference items The issue was that we have been passing a relative path during `JsprojManager`.`addProjectReference` and an absolute path

[GitHub] cordova-docs pull request #620: Modify the document errors

GitHub user ShenghuGong opened a pull request: https://github.com/apache/cordova-docs/pull/620 Modify the document errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/ShenghuGong/cordova-docs patch-1 Alternatively you can

[GitHub] cordova-windows issue #144: CB-10446 Windows 10 Cordova Application restart ...

Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/144 @gasby82, thanks for the info. Do you mean `WinJS` by `javascript framework`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-windows issue #144: CB-10446 Windows 10 Cordova Application restart ...

Github user gasby82 commented on the issue: https://github.com/apache/cordova-windows/pull/144 Hi @daserge, Now it works. Thanks for the support. The problem was due to an incompatibility in the javascript framework. It does not depend on cordova. --- If your project is set up

[GitHub] cordova-docs issue #619: CB-11550 Add android@5.2.1 release blog post

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/619 @stevengill, added the link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

Github user pwbs commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 I remembered later that every time I inspected the contents of the WSOD, the page actually was a about:blank, so can't we test window.location instead? Also, the reason why