[GitHub] cordova-plugin-camera pull request #115: CB-9490 Fixed cleanup function

2016-07-20 Thread cojomojo
Github user cojomojo closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Nightly build #77 for cordova has failed

2016-07-20 Thread Apache Jenkins Server
Nightly build #77 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/77/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/77/consoleFull - Jenkins for Apache Cordova

[DISCUSS] cordova-create breakout from cordova-lib proposal

2016-07-20 Thread Steven Gill
Please review and comment at https://github.com/cordova/cordova-discuss/pull/51

[GitHub] cordova-lib pull request #461: CB-9825 framework tag spec parsing

2016-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: [DISCUSS] Platforms and tools releases

2016-07-20 Thread Vladimir Kotikov (Akvelon)
Sorry for delay, Jesse. I will publish it tomorrow morning. Also could you please take a look at the blog post here: https://github.com/apache/cordova-docs/pull/621 - Best regards, Vladimir -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Wednesday, July 20, 2016

[GitHub] cordova-plugin-inappbrowser pull request #167: doc: do not use `with` in JS ...

2016-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread toddm
Github user toddm commented on the issue: https://github.com/apache/cordova-windows/pull/187 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #167: doc: do not use `with` in JS samples

2016-07-20 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/167 This is big in my mind, gonna merge it now. A CLA would be appreciated at some point if you wish to contribute more. Thanks for this @jakub-g --- If your project

Re: [DISCUSS] Platforms and tools releases

2016-07-20 Thread Jesse
Where are we with the tools release? CB-11023 has landed in cordova-lib master but has not been released yet. It would be great to get this out. @purplecabbage risingj.com On Mon, Jul 11, 2016 at 5:27 PM, Steven Gill wrote: > LGTM. > > Published the android 5.2.0

Re: process.env.PWD vs process.cwd()

2016-07-20 Thread Steven Gill
Hey Toby, Send over the PR if you don't mind. It got put on the backlog for me. On Jul 20, 2016 10:46 AM, "Tobias Bocanegra" wrote: > Hi Steven, > > did you have a chance to take a look at this? If not, I would create a PR. > Regards, Toby > > On Wed, Jun 8, 2016 at 10:17

Re: process.env.PWD vs process.cwd()

2016-07-20 Thread Tobias Bocanegra
Hi Steven, did you have a chance to take a look at this? If not, I would create a PR. Regards, Toby On Wed, Jun 8, 2016 at 10:17 AM, Steven Gill wrote: > Hey Toby, > > Thanks for bringing this up. I'll take a look at it > On Jun 8, 2016 10:14 AM, "Tobias Bocanegra"

Re: Resigning

2016-07-20 Thread Jesse
Hi Dmitry, We are doing well but miss your input ... :( There is no reason to resign, unless you really want to break up. We have only ever had ~3 members resign before even though we still have pmc members who have not contributed in years. It is not a big deal to just mute the channel and go

[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-windows/pull/187 +1 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-windows pull request #187: CB-11241 Return adding BOM to www back to...

2016-07-20 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/187#discussion_r71557328 --- Diff: template/cordova/lib/prepare.js --- @@ -512,8 +515,6 @@ function addBOMSignature(directory) { }); --- End diff --

[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread sgrebnov
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-windows/pull/187 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...

2016-07-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/187 /cc @sgrebnov, @purplecabbage. Could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update

2016-07-20 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/465 ## [Current coverage][cc-pull] is **61.73%** > Merging [#465][cc-pull] into [master][cc-base-branch] will decrease coverage by **18.88%** ```diff @@ master

[GitHub] cordova-lib pull request #465: CB-11605 Non-destructive platform update

2016-07-20 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/465 CB-11605 Non-destructive platform update backup platformId@oldVersion before updating You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-inappbrowser issue #170: CB-11578 fix some calls which used a...

2016-07-20 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/170 Thanks. I forgot one thing, before we can merge it though, you need to sign Apache's Contributor License Agreement (can be done online):

[GitHub] cordova-plugin-inappbrowser issue #170: CB-11578 fix some calls which used a...

2016-07-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/170 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #170: CB-11578 fix some calls which used a...

2016-07-20 Thread DrMoriarty
Github user DrMoriarty commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/170 @jcesarmobile done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this