[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72366794 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -33,326 +33,453 @@ var helpers = require('./helpers'), var projectRoot =

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72366626 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/doc/de/index.md --- @@ -0,0 +1,206 @@

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72366592 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/RELEASENOTES.md --- @@ -0,0 +1,141 @@

[VOTE] cordova ios 4.2.1 release

Please review and vote on this 4.2.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11627 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11627 The package was

[VOTE] cordova android 5.2.2 release

Please review and vote on this 5.2.2 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11626 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11626 The package

Re: Cordova Screen orientation plugin

I have updated the issue to include the w3c spec, and the fact that we need to add tests. I have also assigned it to you Vishal. @purplecabbage risingj.com On Tue, Jul 26, 2016 at 5:21 PM, Vishal Mishra wrote: > > Its CB-11628 > > On 7/26/16, 4:59 PM, "Shazron"

Re: Cordova Screen orientation plugin

Its CB-11628 On 7/26/16, 4:59 PM, "Shazron" wrote: >Vishal, which JIRA issue is this tracked at? > >On Wed, Jul 27, 2016 at 3:41 AM, Vishal Mishra wrote: > >> Tony, >> >> I am working on the cordova screen orientation plugin where I intend to >> have

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 There still need to be tests for the new code that is introduced in this repo (platform API etc), or perhaps I'm misunderstanding your last comment Steve --- If your project is set up for it,

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/467 Did 77 files actually change or GH is not reporting this right? Seems an abnormally large number of files changed for tests. --- If your project is set up for it, you can reply to this email

Re: [Android] Road to 6.0.0

+1 On Tue, Jul 26, 2016 at 6:41 AM, Joe Bowser wrote: > Hey > > So, after the 5.2.2 release of Android, I think we should start merging the > API breaking changes that we have setup for 6.0.0 into mainline. If we > need to do another patch release of Cordova-Android, we

Re: Requesting more information about CB-11214 bug

Hi Sanjeewa, Please copy the repo steps and perhaps continue this discussion in the JIRA issue itself, where it can be tracked more effectively. Since Chris Armstrong is the reporter for the issue, he would get the email notifications when you commented on the issue.

Re: Cordova Screen orientation plugin

Vishal, which JIRA issue is this tracked at? On Wed, Jul 27, 2016 at 3:41 AM, Vishal Mishra wrote: > Tony, > > I am working on the cordova screen orientation plugin where I intend to > have just one javascript file instead of the dedicated javascript files for > each

Re: opinion about a bug fix

I would go with option 3, and keep the notification sending for backwards compat purposes. On Sun, Jul 17, 2016 at 12:02 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I'm looking into this issue https://issues.apache.org/jira/browse/CB-11178 > > The problem is on iOS 9 you can no

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user stevengill commented on the issue: https://github.com/apache/cordova-ios/pull/234 Tests for this are at https://github.com/apache/cordova-lib/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Proof of Concept: Plugins as Android Modules

Bump - any eyeballs on Joe's issue? On Wed, Jul 13, 2016 at 4:53 AM, Joe Bowser wrote: > Hey > > Does anyone have a solution to the problem I'm facing with Gradle > dependencies. I can use some more eyeballs on this. > > Thanks > > Joe > > On Mon, Jun 27, 2016 at 1:57 PM,

Re: [Android] Dropping support for ICS and CB-8834

+1 On Tue, Jul 12, 2016 at 6:53 AM, julio cesar sanchez wrote: > +1 > > 2016-07-12 0:38 GMT+02:00 Joe Bowser : > > > Hey > > > > I'm looking through old issues, and I noticed that CB-8834 is still open > > because we still needed to support ICS, but

Re: Finding a bug for get familiar with code base

Hi Deshan, Try any of these "easyfix" labelled issues: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=131 On Sat, Jul 9, 2016 at 8:29 PM, Deshan Kalupahana < deshankalupah...@gmail.com> wrote: > Hi, > > I'm a beginner to this cordova code base. It will be easy to get > familiar

Re: feedback on statusbar plugin ios

Thanks for all your work on this Julio - we should add the second option for the future. As for the magic number stuff, its fine for now to fix those issues since we have no alternative. On Fri, Jul 8, 2016 at 6:56 AM, julio cesar sanchez wrote: > The statusbar plugin on

Re: [Android] FileProvider Hell

Most serious cordova/phonegap plugins I know already make use of some form of "*com.android.support:**", I would say that even though it's a bad thing to make cordova-android depend on it by default, it won't be a problem in practice. 2016-07-26 15:54 GMT-03:00 julio cesar sanchez

Re: Requesting more information about CB-11214 bug

I set the defaultText parameter on a call to navigator.notification.prompt() using the cordova-plugin-dialogs plugin. The relevant code lives in src/android/Notification.java. My expectation is that the box should be pre-filled with the value of the "defaultText" parameter (if it is specified;

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72350543 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/NOTICE --- @@ -0,0 +1,5 @@ +Apache Cordova

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72350555 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/LICENSE --- @@ -0,0 +1,202 @@ + --- End

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72350533 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/README.md --- @@ -0,0 +1,309 @@ +--- ---

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346220 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/README.md --- @@ -0,0 +1,309 @@ +--- ---

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346148 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/LICENSE --- @@ -0,0 +1,202 @@ + --- End

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346180 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/NOTICE --- @@ -0,0 +1,5 @@ +Apache Cordova

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72346117 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/CONTRIBUTING.md --- @@ -0,0 +1,37 @@

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

GitHub user juliascript opened a pull request: https://github.com/apache/cordova-lib/pull/467 CB-9825: tests for cocoapod integration for plugins You can merge this pull request into a Git repository by running: $ git pull https://github.com/juliascript/cordova-lib CB-9825

Cordova Screen orientation plugin

Tony, I am working on the cordova screen orientation plugin where I intend to have just one javascript file instead of the dedicated javascript files for each platform implementled currently. Vishal

Re: [Android] FileProvider Hell

Ah, I didn't understand that part, I thought they were using their own content provider. Yes, camera plugin will need a rewrite, but I don't think we have another choice El martes, 26 de julio de 2016, Joe Bowser escribió: > The FileProvider class is provided by the Android

Re: [Android] FileProvider Hell

The FileProvider class is provided by the Android Compat library. If we don't use Android Compat, we'd have to write the provider, and re-inventing the wheel is worse than having to use the FileProvider. It's looking more and more like we're going to have to completely re-write Camera because

Re: [Android] FileProvider Hell

The blog talks about "fixing" it using a content provider, how can it be fixed with android-compat? El martes, 26 de julio de 2016, Joe Bowser escribió: > Hey > > It looks like we're hit by this change in Android, which makes it so that > we can no longer use file providers.

Re: [DISCUSS] cordova-ios 4.2.1

+1 @purplecabbage risingj.com On Tue, Jul 26, 2016 at 7:54 AM, Simon MacDonald wrote: > +1, no issue, do it > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Mon, Jul 25, 2016 at 9:57 PM, Shazron wrote: > > > +1 > > > > On Tuesday, July

[Android] FileProvider Hell

Hey It looks like we're hit by this change in Android, which makes it so that we can no longer use file providers. There's an easy fix, but it's not a pretty one. We're going to have to add Android-Compat as a dependency for Cordova. This is really bad, and could cause a lot of things to screw

[GitHub] cordova-plugin-camera issue #223: CB-11447 Fix Appium camera tests failures

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/223 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [Android] Road to 6.0.0

Sounds good to me On Jul 25, 2016 3:41 PM, "Joe Bowser" wrote: > Hey > > So, after the 5.2.2 release of Android, I think we should start merging the > API breaking changes that we have setup for 6.0.0 into mainline. If we > need to do another patch release of

Re: [DISCUSS] cordova-ios 4.2.1

+1, no issue, do it Simon Mac Donald http://hi.im/simonmacdonald On Mon, Jul 25, 2016 at 9:57 PM, Shazron wrote: > +1 > > On Tuesday, July 26, 2016, Steven Gill wrote: > > > Similar to android, i want to update the bundled cordova-common version > to

Re: Android 5.2.1 not pinned in latest tools 6.3.0?

Thanks a lot for clarifying this to me! On Tue, Jul 26, 2016 at 9:51 AM Steven Gill wrote: > It should be ~5.2.0 that is pinned which grabs minor updates automatically. > So 5.2.1 should be default android. > > On Jul 26, 2016 6:59 AM, "Victor Sosa"

Re: Android 5.2.1 not pinned in latest tools 6.3.0?

It should be ~5.2.0 that is pinned which grabs minor updates automatically. So 5.2.1 should be default android. On Jul 26, 2016 6:59 AM, "Victor Sosa" wrote: > Hello all. > > I'm just noticing that the latest tools release (6.3.0) has Android > platform v5.2.0 as the

RE: Android 5.2.1 not pinned in latest tools 6.3.0?

The version range ~5.2.0 allows patch version updates so latest cordova (6.3.0) should install android 5.2.1 by default. Just tried this: λ cordova --version 6.3.0 λ cordova platform rm android && cordova platform add android Adding android project... Creating Cordova

[GitHub] cordova-plugin-camera issue #223: CB-11447 Fix Appium camera tests failures

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/223 Cordova CI Build has one or more failures. **Commit** -

Android 5.2.1 not pinned in latest tools 6.3.0?

Hello all. I'm just noticing that the latest tools release (6.3.0) has Android platform v5.2.0 as the pinned version. http://cordova.apache.org/news/2016/07/13/tools-release.html I'm was keeping an eye on the fix for this defect https://issues.apache.org/jira/browse/CB-9489 And it came in

[GitHub] cordova-plugin-camera pull request #223: CB-11447 Fix Appium camera tests fa...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/223 CB-11447 Fix Appium camera tests failures ### Platforms affected Android, iOS ### What does this PR do? This PR resolves issues w/ the plugin (and

[GitHub] cordova-plugin-contacts issue #35: fix a nasty memory leak on ios

Github user lboekhorst commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/35 @shazron was the dealloc ever implemented? I am also having this issue, and