Github user don commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/80
@jcesarmobile passing strings as the message is the *right* thing to do,
IMO. My main goal was to stop iOS from crashing when the user sent bad data. I
think the documentation should
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/80
Hi.
I think you should edit the README.md to document the changes commenting
that accept any type but will be stringified or something like that.
And maybe add this
Github user philbenoit commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/130
Any word on when this might be merged or if I need to provide any more
details?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/321
## [Current
coverage](https://codecov.io/gh/apache/cordova-android/pull/321?src=pr) is
33.85% (diff: 100%)
> Merging
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-android/pull/321
CB-8978 Prepare copy resource-files from config.xml
See also cordova/cordova-discuss#6
Depends on https://github.com/apache/cordova-lib/pull/468
This copies files specified by
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/469#discussion_r72688890
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -31,14 +31,20 @@ var fs= require('fs'),
function
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/80
Cordova CI Build has completed successfully.
**Commit** -
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/469#discussion_r72685014
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -31,14 +31,20 @@ var fs= require('fs'),
function
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/65
Why do you use medium quality for value 0? shouldn't you use Low?
I think you should use:
0 - low
1 - high
no quality passed - medium (default)
---
If
GitHub user don opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/80
CB-8947: (ios)
### Platforms affected
iOS
### What does this PR do?
Fix crash when non-strings are passed to dialogs
### What testing has been done on
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/234#discussion_r72683673
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +94,31 @@ var handlers = {
}
},
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/219
Cordova CI Build has one or more failures.
**Commit** -
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/223
Reviewed, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
I vote +1:
* Reviewed release notes
* Verified signatures and hashes
* Verified that blank app could be created with the platform from RC archive
* Verified that blank app could be successfully built and ran
-
Vladimir
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
I vote +1:
* Reviewed release notes
* Verified signatures and hashes
* Verified that blank app could be created with the platform from RC archive
* Verified that blank app could be successfully built and ran
-
Vladimir
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/223
@sgrebnov, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/470
@stevengill, @purplecabbage, could you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Blog post:
http://cordova.apache.org/announcements/2016/07/27/cordova-windows-4.4.2.html
Tweet: https://twitter.com/apachecordova/status/758621979238887424
-
Vladimir
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/470
CB-11636 Handle attributes with quotes correctly
This PR changes `mergeXml` inner implementation to avoid using
`elementtree.findall()` with complex queries such as
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user akilawickey commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/316#discussion_r72580800
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -175,9 +175,13 @@ protected void createViews() {
Github user akilawickey commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/316#discussion_r72578456
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -175,9 +175,13 @@ protected void createViews() {
Github user akilawickey commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/316#discussion_r72578371
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -175,9 +175,13 @@ protected void createViews() {
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/316#discussion_r72573856
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -175,9 +175,13 @@ protected void createViews() {
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/316#discussion_r72573788
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -175,9 +175,13 @@ protected void createViews() {
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-lib/pull/469
CB-8320: We look for a build.gradle to make sure it's Android, this allows
plugman to be used with non-standard Cordova projects.
You can merge this pull request into a Git repository by
27 matches
Mail list logo
