Nightly build #87 for cordova has failed

2016-07-30 Thread Apache Jenkins Server
Nightly build #87 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/87/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/87/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-vibration pull request #40: add JIRA issue tracker link

2016-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request #19: CB-8001

2016-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/55 Hi. Sorry that it took me so long to review this. As you were using the hardcoded value 20 for the statusbar height I had to ask on the developer list, because on

[GitHub] cordova-ios issue #239: CB-11648: Make CDVViewController send notifications

2016-07-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/239 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/239?src=pr) is 51.81% (diff: 100%) > Merging [#239](https://codecov.io/gh/apache/cordova-ios/pull/239?src=pr) into

Re: feedback on statusbar plugin ios

2016-07-30 Thread julio cesar sanchez
I have created an issue for second option https://issues.apache.org/jira/browse/CB-11648 And sent a PR https://github.com/apache/cordova-ios/pull/239 2016-07-27 1:45 GMT+02:00 Shazron : > Thanks for all your work on this Julio - we should add the second option > for the

[GitHub] cordova-ios pull request #239: CB-11648: Make CDVViewController send notific...

2016-07-30 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-ios/pull/239 CB-11648: Make CDVViewController send notifications Make CDVViewController to send notifications when UIViewController methods are called Added notifications for

[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update

2016-07-30 Thread csantanapr
Github user csantanapr commented on the issue: https://github.com/apache/cordova-lib/pull/465 LGTM Maybe print some message about next steps "you need to manually moved any platform configuration from backup version a.b.c to x.y.z as you see it fit for your project" --- If your

[GitHub] cordova-plugin-file-transfer pull request #128: Allow to pass an ArrayBuffer...

2016-07-30 Thread tuvistavie
Github user tuvistavie closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-dialogs pull request #78: Master

2016-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: opinion about a bug fix

2016-07-30 Thread julio cesar sanchez
Thanks for your opinion, I've followed your advice and fixed the issue that way 2016-07-27 1:51 GMT+02:00 Shazron : > I would go with option 3, and keep the notification sending for backwards > compat purposes. > > On Sun, Jul 17, 2016 at 12:02 AM, julio cesar sanchez < >

[GitHub] cordova-plugin-dialogs issue #80: CB-8947: (ios)

2016-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/80 Couldn't find your ICLA, then I realized you were a committer, lol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-dialogs pull request #80: CB-8947: (ios)

2016-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

2016-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 If you do what I said you won't change the behavoiur, if there is no quality passed, then you use medium quality, that is how it works now. If you pass quality option