Nightly build #91 for cordova has succeeded!

2016-08-03 Thread Apache Jenkins Server
Nightly build #91 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/91/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-contacts issue #132: CB-11667 - Memory leak in CDVContact for...

2016-08-03 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/132 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-08-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/236 @bhariharan what cordova-ios version are you using? cordova-ios-4.1.0 fixes that loop problem. no, what you [linked

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

2016-08-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 I'm afraid this PR needs to be re-based with master. I had to pull in other pull requests that probably touched part of the code you were working on. --- If your project is set up for it, you

[GitHub] cordova-plugin-contacts pull request #132: CB-11667 - Memory leak in CDVCont...

2016-08-03 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/132 CB-11667 - Memory leak in CDVContact for CoreFoundation ABRecordRef Related to https://github.com/apache/cordova-plugin-contacts/pull/35 You can merge this pull request into a Git

[GitHub] cordova-plugin-contacts issue #35: fix a nasty memory leak on ios

2016-08-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/35 @lboekhorst see #132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

2016-08-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 I have failing unit tests that do objectively verify that as others have shown, yes, we can't update the configuration dynamically (I've tried all sorts of clever runtime

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

2016-08-03 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/232#discussion_r73437041 --- Diff: tests/CordovaLibTests/CDVWhitelistTests.m --- @@ -295,6 +295,37 @@ - (void)testAllowIntentsAndNavigations

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

2016-08-03 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/232#discussion_r73432421 --- Diff: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m --- @@ -95,23 +95,33 @@ -

[DISCUSS] Cordova-common 1.5.0.

2016-08-03 Thread Steven Gill
Any blockers? I'm going to look into merging https://github.com/apache/cordova-lib/pull/466 & https://github.com/apache/cordova-lib/pull/468 as well.

[GitHub] cordova-lib pull request #474: CB-11653 copied findProjectRoot from cordova-...

2016-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

2016-08-03 Thread macrozone
Github user macrozone commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 Any update on this? In my opinion, this is a very severe issue with WKWebview. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

2016-08-03 Thread tony--
Github user tony-- commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/232#discussion_r73358461 --- Diff: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m --- @@ -95,23 +95,33 @@ -

[GitHub] cordova-ios pull request #232: CB-11270 - Handle JavaScript onclick handler ...

2016-08-03 Thread tony--
Github user tony-- commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/232#discussion_r73356143 --- Diff: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m --- @@ -95,23 +95,33 @@ -

RE: Managing typescript typings for Cordova and plugins

2016-08-03 Thread Vladimir Kotikov (Akvelon)
> Right now the only typings that I am aware of are in the definitelytyped git > repository What about new typings delivery mechanism via `npm I @types` [1]. What they are saying is that "The major and minor version number of the types package will match the version of the underlying package,

[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build

2016-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #462: CB-8151 util.js creates directory if require(...

2016-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/462 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #462: CB-8151 util.js creates directory if require()d

2016-08-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/462 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

RE: [DISCUSS] cordova-plugin-media-capture video quality

2016-08-03 Thread Vladimir Kotikov (Akvelon)
+1 Sounds good - Vladimir -Original Message- From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] Sent: Wednesday, August 3, 2016 10:11 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-plugin-media-capture video quality So 0 - Low ... // Other possible values in the