Re: To merge fixed bug

2016-08-29 Thread Steven Gill
Thanks Sanjeewa! Merged in. On Mon, Aug 29, 2016 at 10:01 PM, sanjeewa kumara wrote: > I have fixed CB-11085 > > AudioHandler logs should use system log, not println and made PR. > Can you check there is anything to fix or not. If there is anything > to fix again please

[GitHub] cordova-plugin-media pull request #110: CB-11085 (Android) Fixed AudioHandle...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media issue #110: CB-11085 (Android) Fixed AudioHandler logs ...

2016-08-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-media/pull/110 LGTM. I'll merge it in. Thanks @sanjeewa894 for sending the PR!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-file-transfer issue #156: CB-9027 (android, ios): Expose HTTP...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/156 Cordova CI Build has one or more failures. **Commit** -

To merge fixed bug

2016-08-29 Thread sanjeewa kumara
I have fixed CB-11085 AudioHandler logs should use system log, not println and made PR. Can you check there is anything to fix or not. If there is anything to fix again please mention it otherwise can you merge it? Thank you.

[GitHub] cordova-plugin-file-transfer pull request #156: CB-9027 (android, ios): Expo...

2016-08-29 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/156 CB-9027 (android, ios): Expose HTTP client read timeout as an option ### Platforms affected Android iOS ### What does this PR do? Expose HTTP Client

[GitHub] cordova-plugin-file-transfer pull request #155: CB-9027 (android, ios): Expo...

2016-08-29 Thread ryanwilliams83
Github user ryanwilliams83 closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Nightly build #122 for cordova has succeeded!

2016-08-29 Thread Apache Jenkins Server
Nightly build #122 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/122/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-file-transfer pull request #155: CB-9027 (android, ios): Expo...

2016-08-29 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/155 CB-9027 (android, ios): Expose HTTP client read timeout as option ### Platforms affected Android iOS ### What does this PR do? Expose HTTP Client

[GitHub] cordova-plugin-whitelist issue #19: Update README.md

2016-08-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-whitelist/pull/19 Hey @vladimirnani, we generally don't put third party tools in cordova readmes. If you remove the stuff about PhoneGap, I can merge this in. The readme should include a install

[GitHub] cordova-plugin-console pull request #14: add JIRA issue tracker link

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request #131: CB-11455: (ios) Add mandatory iOS...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android pull request #262: CB-10680 Expose isFirstAttempt API in ICo...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #262: CB-10680 Expose isFirstAttempt API in ICordovaHt...

2016-08-29 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/262 I guess not? I'm going to close this. If you can give us more information on how to review this thing, that'd be awesome. --- If your project is set up for it, you can reply to this

[GitHub] cordova-android pull request #243: Include native libraries from armeabi dir...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #227: Move CordovaWebView to CordovaWebInterfac...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #219: Fixed CB-9697 Cordova emulate for Android...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #185: CB-8965 Copy cordova-js-src directory to ...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

2016-08-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 Merged! Thanks again @swbradshaw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser issue #183: CB-11783: (android) Add intent schem...

2016-08-29 Thread GavinPacini
Github user GavinPacini commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/183 Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-camera pull request #197: [CB-5195][CB-4078]: correctOrientat...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser pull request #28: Events are not firing on Black...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #78: I need when user hit hardware ...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #183: CB-11783: (android) Add intent schem...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/183 Thanks for the PR, I've merged it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-inappbrowser pull request #183: CB-11783: (android) Add inten...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-statusbar issue #55: Handle extended status bar on iOS

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/55 The ICLA has been received, can you make the code changes I proposed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request #631: Added iPad Pro icon

2016-08-29 Thread monove
GitHub user monove opened a pull request: https://github.com/apache/cordova-docs/pull/631 Added iPad Pro icon You can merge this pull request into a Git repository by running: $ git pull https://github.com/monove/cordova-docs patch-1 Alternatively you can review and apply

[GitHub] cordova-plugin-inappbrowser issue #183: CB-11783: (android) Add intent schem...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/183 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera pull request #197: [CB-5195][CB-4078]: correctOrientat...

2016-08-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#discussion_r76660583 --- Diff: src/android/CameraLauncher.java --- @@ -927,6 +859,21 @@ private void writeUncompressedImage(Uri src, Uri dest) throws

Re: CI Build Status

2016-08-29 Thread Steven Gill
wooo! On Mon, Aug 29, 2016 at 6:00 AM, Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > Hi guys, > > Here's the last week's report > > > > # of legitimate test failures: > > 0 - Android > > 0 - iOS > > 0 - WP 8.1 > > 0 - Windows 8.1 > > 0 - Windows 10 > > There are some new and

[GitHub] cordova-plugin-inappbrowser pull request #183: CB-11783: (android) Add inten...

2016-08-29 Thread GavinPacini
GitHub user GavinPacini opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/183 CB-11783: (android) Add intent scheme to be handled by OS ### Platforms affected Android ### What does this PR do? The intent scheme `intent://` is

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 There is a google+ plugin https://github.com/EddyVerbruggen/cordova-plugin-googleplus BTW, I'm not saying that this shouldn't be merged, I'm saying that it

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread dotNetkow
Github user dotNetkow commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Thanks for sharing. Really good to know - someone needs to start building a "Google Sign-In" plugin! ;) Naturally, I disagree on this, what with an infinite amount of

Adding NSB/AppStudio to Tools section of Cordova home page

2016-08-29 Thread George Henne
I'd like to nominate NSB/AppStudio for inclusion in the Cordova Tools section of Cordova home page. See https://github.com/apache/cordova-docs/pull/626 NSB/AppStudio is a tool for developing apps using Apache Cordova. It has supported PhoneGap since its initial release in December, 2010.

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 The ICLA is for individuals, so if you already sent it that is good. It's recommended to use a personal email, but you can use any email you want, I can't really see your

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-29 Thread jonathanli2
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, I believe I have signed the agreement a while ago (on November 2014) when suggested by John Wargo, but I think at that time I signed the agreement using my company's

CI Build Status

2016-08-29 Thread Alexander Sorokin (Akvelon)
Hi guys, Here's the last week's report # of legitimate test failures: 0 - Android 0 - iOS 0 - WP 8.1 0 - Windows 8.1 0 - Windows 10 There are some new and old infrastructure issues: for example, the cordova-vm is down at the moment which means we cannot effectively run tests for the

Re: [Discuss] plugins release

2016-08-29 Thread julio cesar sanchez
If somebody with an iPad that supports multitasking can test this PR... https://github.com/apache/cordova-plugin-statusbar/pull/62 I have reviewed the code and looks good, bud I don't have an iPad that supports multitasking to test it, and I don't trust the simulator in this case as I tried to

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 It looks good now. Sadly I don't have an iPad Pro to test it, I'm going to send a mail on the developer mailing list to see if somebody can test it. In the

[GitHub] cordova-plugin-media pull request #113: CB-11757 (ios) Error out if trying t...

2016-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-media/pull/113 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [iOS] Feature change - updates in config.xml

2016-08-29 Thread julio cesar sanchez
+1 2016-08-29 10:51 GMT+02:00 Shazron : > Due to lazy consensus, I will proceed with this change. > > On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts > wrote: > > > +1; totally fine with this. :-) > > > > ~ Kerri > > > > > On Aug 24, 2016, at 20:30,

Re: [iOS] Feature change - updates in config.xml

2016-08-29 Thread Shazron
Due to lazy consensus, I will proceed with this change. On Thu, Aug 25, 2016 at 12:26 PM, Kerri Shotts wrote: > +1; totally fine with this. :-) > > ~ Kerri > > > On Aug 24, 2016, at 20:30, Shazron wrote: > > > > More details and discussion in: > >

Nightly builds - npm publish issue

2016-08-29 Thread Shazron
See: https://issues.apache.org/jira/browse/CB-11778 Long story short -- we need to use node 6.x to publish the npm nightlies. I know the nightly CI uses coho, is it a matter of just updating coho code and the CI picks it up, or do we have to do something else?

[GitHub] cordova-plugin-media issue #113: CB-11757 (ios) Error out if trying to stop ...

2016-08-29 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/113 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Starting in October 20th google won't allow to use WebViews (like inAppBrowser) for OAuth, so I think that's another reason to not change the behaviour of the plugin just