[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-09-08 Thread jonathanli2
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Actually as mentioned in jcesarmobile's comment at above, the right issue id for this pull request is CB-10288. I just edited the PR title to the "CB-10288" using the

Nightly build #140 for cordova has failed

2016-09-08 Thread Apache Jenkins Server
Nightly build #140 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/140/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/140/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-dialogs issue #82: Make sure the alert buttonLabel is a strin...

2016-09-08 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/82 I think we are okay with ``` alert("What is the meaning of life?", function(){}, "Your Question", 42); ``` also, your code overlooks empty string ... ( ""

[GitHub] cordova-plugin-dialogs pull request #83: CB-11281 windows: defaultText is ta...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib issue #489: CB-11811 - Updated travis settings

2016-09-08 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/489 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/489?src=pr) is 25.34% (diff: 100%) > Merging [#489](https://codecov.io/gh/apache/cordova-lib/pull/489?src=pr) into

[GitHub] cordova-lib pull request #489: CB-11811 - Updated travis settings

2016-09-08 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/489 CB-11811 - Updated travis settings EXPERIMENTING. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11811

[GitHub] cordova-plugin-wkwebview-engine pull request #19: CB-11824 - Update tests to...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-ios issue #252: Add missing LD_RUNPATH_SEARCH_PATHS setting to the R...

2016-09-08 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/252 Hi, thanks for the PR. It seems that you erased the Issue Template without reading it. One of the requirements is that you create a JIRA issue and prefix the PR with the issue token, to enable

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

2016-09-08 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 @jonathanli2 Please update the prefix to the title of this PR from "CB:-9161" to "CB-9161". Any comments on this PR are not reflected in JIRA because of this typo. Thanks! --- If

Re: [Discuss] Cordova-Android 6.0.x

2016-09-08 Thread Darryl Pogue
Crosswalk plugin has already been updated (on master anyways) :) https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview/pull/95 On 8 September 2016 at 14:46, Joe Bowser wrote: > Hey > > So, this is exciting. Things are broken on Master if you're trying to use

Re: [Discuss] Cordova-Android 6.0.x

2016-09-08 Thread Shazron
Ask Crosswalk to: "To detach the fork and turn it into a standalone repository on GitHub, contact GitHub Support." From: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/ On Thu, Sep 8, 2016 at 2:46 PM, Joe Bowser wrote: > Hey > > So,

[GitHub] cordova-plugin-media-capture pull request #70: Add mandatory iOS 10 privacy ...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [Discuss] Cordova-Android 6.0.x

2016-09-08 Thread julio cesar sanchez
I think it should be fixed, not everyone is going to add crosswalk because it adds a lot of extra weight to the app 2016-09-08 23:46 GMT+02:00 Joe Bowser : > Hey > > So, this is exciting. Things are broken on Master if you're trying to use > Cordova with Jellybean.

Re: [Discuss] Cordova-Android 6.0.x

2016-09-08 Thread Joe Bowser
Hey So, this is exciting. Things are broken on Master if you're trying to use Cordova with Jellybean. Apparently we forgot to add a failsafe for the bridge to go back to APIs lower than 19, so the bridge doesn't work if you're targeting people still on Jellybean. Unfortunately, we still have

[GitHub] cordova-plugin-media-capture issue #70: Add mandatory iOS 10 privacy descrip...

2016-09-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/70 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #70: Add mandatory iOS 10 privacy ...

2016-09-08 Thread leshik
GitHub user leshik opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/70 Add mandatory iOS 10 privacy description for microphone access You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request #218: CB-9696: Add possibility to use non-immer...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #279: fullscreen no immersive

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs issue #74: [Windows] Separated CSS from JS code. Fixe...

2016-09-08 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/74 Gonna merge this, thanks @serbanghita Do you have a CLA on file? If not, please follow the instructions here: http://cordova.apache.org/contribute/ --- If your project is

Re: optimizing ios inappbrowser plugin's open and openInSystem method s

2016-09-08 Thread Jesse
Second call steals the callbackID of the first. On it. Thanks! > On Sep 7, 2016, at 6:34 AM, Li, Jonathan wrote: > > Hi, > > The problem with > self.callbackId = command.callbackId; > is it causes the current inappbrowser stopping work properly after user > clicks a link

Re: [Discuss] plugins release

2016-09-08 Thread David Barth
Hey guys, Alex has a set of fixes for ubuntu code in the following plugins: - https://github.com/apache/cordova-plugin-inappbrowser/pull/174 - https://github.com/apache/cordova-plugin-battery-status/pull/38 - https://github.com/cordova-ubuntu/cordova-plugin-geolocation/pull/2 Should we

Re: [Discuss] plugins release

2016-09-08 Thread Steven Gill
I can review and merge On Sep 8, 2016 9:00 AM, "David Barth" wrote: > Hey guys, > > Alex has a set of fixes for ubuntu code in the following plugins: > >- https://github.com/apache/cordova-plugin-inappbrowser/pull/174 >-

[GitHub] cordova-plugin-inappbrowser issue #174: CB-3360 Fix Oxide version & support ...

2016-09-08 Thread david-barth-canonical
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/174 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-wkwebview-engine pull request #19: CB-11824 - Update tests to...

2016-09-08 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/19 CB-11824 - Update tests to include objective-c tests You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-geolocation issue #78: navigator.geolocation.getCurrentPositi...

2016-09-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/78 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera issue #236: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-09-08 Thread kristiyandobrev
Github user kristiyandobrev commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/236 Sorry @jcesarmobile my bad because it's actually [Cordova Media Capture Plugin](https://github.com/apache/cordova-plugin-media-capture) not the camera one. --- If your

[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...

2016-09-08 Thread lucatorella
Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Sorry, just updated the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-wkwebview-engine issue #17: Avoid retain cycle caused by WKUs...

2016-09-08 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Found it - CB-11818. Unfortunately I can't edit the issue title, can you please update it. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-wkwebview-engine issue #17: Avoid retain cycle caused by WKUs...

2016-09-08 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Where's the JIRA issue? Prefix it to the title for automated tracking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-wkwebview-engine pull request #18: CB-11815: (iOS) Fix hard-c...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-whitelist pull request #22: CB-11795 Add 'protective' entry t...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request #113: CB-11795 Add 'protective' ent...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-dialogs pull request #85: CB-11795 Add 'protective' entry to ...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-network-information pull request #47: The entry is required t...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-globalization pull request #50: CB-11795 Add 'protective' ent...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-geolocation pull request #80: CB-11795 Add 'protective' entry...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file-transfer pull request #157: CB-11795 Add 'protective' en...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device-orientation pull request #29: CB-11795 Add 'protective...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-device-motion pull request #47: CB-11795 Add 'protective' ent...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device pull request #55: CB-11795 Add 'protective' entry to c...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request #133: CB-11795 Add 'protective' entry t...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-console pull request #19: CB-11795 Add 'protective' entry to ...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #234: CB-11795 Add 'protective' entry to ...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows issue #195: Allow setting of 'ForegroundText' property via c...

2016-09-08 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/195 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/195?src=pr) is 74.10% (diff: 37.50%) > Merging

[GitHub] cordova-windows pull request #195: Allow setting of 'ForegroundText' propert...

2016-09-08 Thread tsschaffert
GitHub user tsschaffert opened a pull request: https://github.com/apache/cordova-windows/pull/195 Allow setting of 'ForegroundText' property via config.xml We had a problem when trying to release an app in the Windows Store with BackgroundColor set to white because of the contrast

[GitHub] cordova-plugin-media-capture pull request #69: CB-11821 (ios) Add mandatory ...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or