[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...

2016-09-20 Thread lucatorella
Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 I haven't checked. I can easily check next week when I've access to a Mac again 🌴 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera issue #167: Adding force orientation lock to Camera

2016-09-20 Thread gitlovenotwar
Github user gitlovenotwar commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/167 👍 for locking orientation of camera --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-android pull request #331: Android studio

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Nightly build #152 for cordova has succeeded!

2016-09-20 Thread Apache Jenkins Server
Nightly build #152 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/152/consoleFull - Jenkins for Apache Cordova

[PROPOSAL] Deprecation of node.js 0.x and upgrade to a minimum usage of node.js 6.x in Apache Cordova

2016-09-20 Thread Shazron
See: https://github.com/cordova/cordova-discuss/pull/52 Please discuss and comment directly on the PR. Finalized proposal will be pasted back into the list.

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-09-20 Thread manucorporat
Github user manucorporat commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 @ephemer sure! I can rename it! it was just a funny name (bad clean code practice haha) > does the window clean itself up if its rootViewController dismisses itself, or

[GitHub] cordova-android issue #331: Android studio

2016-09-20 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/331 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/331?src=pr) is 35.15% (diff: 67.44%) > Merging

[GitHub] cordova-android pull request #331: Android studio

2016-09-20 Thread imhotep
GitHub user imhotep reopened a pull request: https://github.com/apache/cordova-android/pull/331 Android studio Adds support for Android Studio plugin install/uninstall You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request #331: Android studio

2016-09-20 Thread imhotep
Github user imhotep closed the pull request at: https://github.com/apache/cordova-android/pull/331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Fwd: Google Play change to Android ACCESS_FINE_LOCATION permissions

2016-09-20 Thread Joe Bowser
FYI. I'm going to create an issue to add this to the plugin.xml for geolocation later. -- Forwarded message -- From: Google Play Date: Tue, Sep 20, 2016 at 11:40 AM Subject: Google Play change to Android ACCESS_FINE_LOCATION permissions To:

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 I like the implementation in #187 for the `show` method, what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-ios pull request #259: CB-11792 - Fixed configuration file could not...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #259: CB-11792 - Fixed configuration file could not be par...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/259 @dpogue Thanks for testing! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #259: CB-11792 - Fixed configuration file could not be par...

2016-09-20 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/259 Tested this and I'm not getting any errors from the xcconfig :+1: Thanks Shaz! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-wkwebview-engine pull request #20: Fix handling of tel and ma...

2016-09-20 Thread manucorporat
GitHub user manucorporat opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20 Fix handling of tel and mailto schemes in local file ### Platforms affected iOS ### What does this PR do? - WKWebview appears to do nothing when

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-09-20 Thread dotNetkow
Github user dotNetkow commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 Developer here that originally requested this change. To lend more credence to @manucorporat's changes: I tested them on an iPhone 6 running iOS 10 - works now as expected.

[GitHub] cordova-docs pull request #639: Xcode Other linker flags

2016-09-20 Thread MountainHill
GitHub user MountainHill opened a pull request: https://github.com/apache/cordova-docs/pull/639 Xcode Other linker flags change > -Obc-C to > -ObjC You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-windows issue #195: CB-11836 Allow setting of 'ForegroundText' prope...

2016-09-20 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/195 @tsschaffert, please let me know if you plan to address the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request #638: CB-11836 Documented Windows ForegroundText p...

2016-09-20 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/638 CB-11836 Documented Windows ForegroundText preference https://issues.apache.org/jira/browse/CB-11836 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios issue #259: CB-11792 - Fixed configuration file could not be par...

2016-09-20 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/259 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/259?src=pr) is 56.89% (diff: 75.00%) > Merging [#259](https://codecov.io/gh/apache/cordova-ios/pull/259?src=pr) into

[GitHub] cordova-ios pull request #259: CB-11792 - Fixed configuration file could not...

2016-09-20 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/259 CB-11792 - Fixed configuration file could not be parsed due to preprocessing errors You can merge this pull request into a Git repository by running: $ git pull