Nightly build #224 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/224/consoleFull
-
Jenkins for Apache Cordova
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/278
It's not a failure in node-xcode. Therefore, the tests are incorrect
somehow.
Tested using:
```
#!/usr/bin/env node
var xcode = require('xcode'),
fs =
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/278
I'm going to run some independent tests on node-xcode to verify that
updateBuildProperty is working properly (it has unit-tests already) or whether
it is our test pbxproj that is faulty, etc.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/277
Evaluated this. Turns out this is not the problem - see #278 failing test
for this issue which looks like a failure in node-xcode updateBuildProperty.
Note that the test project pbxproj already
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/278
CB-11243 - Added failing tests
### Platforms affected
iOS
### What does this PR do?
Added failing tests for `target-device` and `deployment-target` preferences
on
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-windows/pull/207
> Do I get it right that it will require us to release cordova-common
before platform release?
@matrosov-nikita, I think the idea was to make it so updated
cordova-windows
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/197
The existing hide and the new browserHide do exactly the same, can you make
the old hide just call browserHide instead of duplicating code.
Can you try adding this
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/277
Reviewing this to understand where the bug
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/277
CB-11648 will be obsolete and may not be needed with
https://issues.apache.org/jira/browse/CB-12127 already implemented. Example
use:
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/165
@beatgrabe And the tests that are failing are all related to this plugin.
Until these pass, I'm not going to merge it in.
---
If your project is set up for it, you can reply
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/54
Hey @romedius!
Thanks for sending this in!
I have a few questions I was hoping you could answer to speed up the review.
So right now, media will keep
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/277
## [Current
coverage](https://codecov.io/gh/apache/cordova-ios/pull/277?src=pr) is 60.00%
(diff: 100%)
> Merging [#277](https://codecov.io/gh/apache/cordova-ios/pull/277?src=pr)
into
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-ios/pull/277
CB-11243: Fix target-device and deployment-target preferences
### Platforms affected
iOS
### What does this PR do?
Fixes target-device and deployment-target preferences.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87596875
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo =
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87598394
--- Diff: spec/unit/ConfigChanges.spec.js ---
@@ -161,3 +165,40 @@ describe('Capabilities within
package.windows.appxmanifest', function() {
Github user mikeg-red5hift closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
GitHub user mikeg-red5hift reopened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/71
iOS multitasking fix not yet committed to the source plug-in repo
### Platforms affected
### What does this PR do?
### What testing
GitHub user mikeg-red5hift opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/71
iOS multitasking fix not yet committed to the source plug-in repo
### Platforms affected
### What does this PR do?
### What testing has
Github user mikeg-red5hift closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user beatgrabe commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/165
@infil00p Seems like project is still brokenâ¦
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user katzlbt commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/54
@ghenry22 Current sources and README do not indicate any deprecation of
**_playAudioWhenScreenIsLocked_** in iOS. Which tickets did you read?
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/165
Cordova CI Build has one or more failures. Link:
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/43/
312 tests run, 26 skipped, 50 failed.
22 matches
Mail list logo