[GitHub] cordova-windows issue #207: Move windows-specific logic from cordova-common

2016-11-13 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/207 Also, @matrosov-nikita could you please create a Jira issue for tracking (http://issues.cordova.io), rename the PR title and add the commit prefix? --- If your project is set up for it,

[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...

2016-11-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 @jcesarmobile, rebuilt in c9e6a9a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

2016-11-13 Thread gkrizek
Github user gkrizek commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 @rthomasclearwave I just cloned the repo and made the change myself --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Nightly build #226 for cordova has failed

2016-11-13 Thread Apache Jenkins Server
Nightly build #226 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/226/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/226/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-13 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 @jcesarmobile - updated to remove that duplicate code, tested in my app and it's working well. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...

2016-11-13 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/197 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 @vladimir-kotikov I have tried to generate the README.md from the TEMPLATE.md, but it's failing. Can you take a look? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-camera pull request #240: CB-12086: Added NSPhotoLibraryUsage...

2016-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Thanks, merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-statusbar pull request #62: CB-10288: statusbar plugin intera...

2016-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jonathanli2
Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Just squashed the commits into a single one for the PR request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-inappbrowser issue #107: CB-9274 Adds missing methods to InAp...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/107 Ok, I've merged this in case there were still people using amazon-fireos, but it's deprecated and the plugin code might be deleted in future releases --- If your project

[GitHub] cordova-plugin-inappbrowser pull request #107: CB-9274 Adds missing methods ...

2016-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #66: CB-7608 : add option useWidthViewPort...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/66 @sebastienblanc I would like to merge this, can you fix the conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 I agree with @jonathanli2, as this way is a bit hackish, I think it's better doing it were it's strictly necessary to fix the bug --- If your project is set up for it,

[GitHub] cordova-plugin-inappbrowser issue #196: CB-NONE: (android) Set correct conte...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 @PhilippeMorier, can you create an issue on issues.cordova.io and use the id you get as start of the title of this PR? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 @jonathanli2 can you rebase your PR squashing the 3 commits into one? I'm having trouble merging this with the tool we use to merge --- If your project is set up for it,

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

2016-11-13 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 I had the chance to test this on a real device and looks good, so I'm merging it in --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-13 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87713717 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =

[GitHub] cordova-windows issue #207: Move windows-specific logic from cordova-common

2016-11-13 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-windows/pull/207 @vladimir-kotikov, yes, you are right. Have you any questions or concerns about this matter? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...

2016-11-13 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87713341 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,109 @@ +var semver = require('semver'); +var CommonPluginInfo =