Nightly build #241 for cordova has succeeded!

Nightly build #241 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/241/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-android issue #349: CB-12169: Check for build directory before runni...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/349 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/349?src=pr) is 35.58% (diff: 50.00%) > Merging

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/468 Any other input here? Are we in agreement to remove the top-level file copying? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Hello again!

Welcome back! @purplecabbage risingj.com On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald wrote: > Never heard of this guy. > Simon Mac Donald > http://simonmacdonald.com > > > On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: > > Hi everyone!

Re: Hello again!

Never heard of this guy. Simon Mac Donald http://simonmacdonald.com On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: > Hi everyone! > > Just wanted to (re)introduce myself after a 3 year or so hiatus :) > > I used to be an active member of the group between 2011 and 2013

Hello again!

Hi everyone! Just wanted to (re)introduce myself after a 3 year or so hiatus :) I used to be an active member of the group between 2011 and 2013 when I was on the Adobe PhoneGap team. I took a 3 year detour focusing on mobile testing infrastructure at Sauce Labs, but recently rejoined the Adobe

[GitHub] cordova-lib pull request #:

Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/fbedd9e67f5a631404079b28e3def489cd07b129#commitcomment-19987410 In cordova-lib/src/cordova/platform.js: In cordova-lib/src/cordova/platform.js on line 121: hey @stevengill ... can

[GitHub] cordova-lib pull request #:

Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/fbedd9e67f5a631404079b28e3def489cd07b129#commitcomment-19987344 In cordova-lib/spec-cordova/pkgJson.spec.js: In cordova-lib/spec-cordova/pkgJson.spec.js on line 28: fixed this typo

[GitHub] cordova-lib pull request #:

Github user audreyso commented on the pull request: https://github.com/apache/cordova-lib/commit/fbedd9e67f5a631404079b28e3def489cd07b129#commitcomment-19987342 In cordova-lib/spec-cordova/pkgJson.spec.js: In cordova-lib/spec-cordova/pkgJson.spec.js on line 228: fixed this

[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov thank you for the review! I've addressed the notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89792140 --- Diff: cordova-js-src/splashscreen.js --- @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg) { } }

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89789288 --- Diff: template/cordova/lib/prepare.js --- @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) {

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89770853 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config) { }; } +/** Checks if a

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89769817 --- Diff: template/CordovaApp.Phone.jsproj --- @@ -79,7 +79,9 @@ Designer - + --- End diff --

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729105 --- Diff: template/cordova/lib/prepare.js --- @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) {

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726640 --- Diff: spec/unit/Prepare.Win10.spec.js --- @@ -541,4 +541,165 @@ describe('copyIcons method', function () {

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726245 --- Diff: cordova-js-src/splashscreen.js --- @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg) { }

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729119 --- Diff: template/cordova/lib/prepare.js --- @@ -362,7 +407,13 @@ function mapImageResources(images, imagesDir) { // find

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729302 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config) { }; } +/**

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89727836 --- Diff: template/cordova/lib/prepare.js --- @@ -297,48 +305,78 @@ function applyNavigationWhitelist(config, manifest) {

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89726251 --- Diff: cordova-js-src/confighelper.js --- @@ -22,16 +22,17 @@ // config.xml wrapper (non-node ConfigParser analogue) var

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89729637 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config) { }; } +/**

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89739598 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config) { }; } +/**

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89727040 --- Diff: template/CordovaApp.Phone.jsproj --- @@ -79,7 +79,9 @@ Designer - + --- End

[GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/212#discussion_r89739874 --- Diff: template/cordova/lib/prepare.js --- @@ -439,6 +490,109 @@ function getUAPVersions(config) { }; } +/**