[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92111761 --- Diff: package.json --- @@ -51,7 +51,7 @@ "wd": "^0.4.0" }, "devDependencies": { -"jasmine-node": "~1", -

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92113708 --- Diff: lib/appium/AppiumRunner.js --- @@ -419,8 +411,9 @@ AppiumRunner.prototype.prepareApp = function () { var deviceString =

[GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/18#discussion_r92112118 --- Diff: lib/paramedic.js --- @@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () { })

Re: [DISCUSS] EOL cordova-medic

Hey all! I’m +1 for killing Medic, since it hasn’t been used for months and I guess hardly ever will be used in the future. Though I have a bit different proposal about moving configs – IMO they are a part of CI and should live somewhere inside a CI. I don’t think there is a need to either

[GitHub] cordova-docs issue #314: Document lib-file for Android

Github user mbektchiev commented on the issue: https://github.com/apache/cordova-docs/pull/314 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92108886 --- Diff: appium-tests/common/common.spec.js --- @@ -228,11 +228,18 @@ describe('Contacts Android', function () { function

Re: [DISCUSS] Plugins Release

Starting on https://issues.apache.org/jira/browse/CB-12237 now. Acknowledgements: I would like to thank Rick Astley for getting me through the previous release. On Mon, Dec 12, 2016 at 3:39 PM, Shazron wrote: > https://issues.apache.org/jira/browse/CB-12224 is complete

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts issue #143: Jasmine use of `afterAll` and label twea...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/143 I re-added the `checkSession` functionality, and factored it out into a `beforeEach` to clean up the test code, at least. Take a look @alsrokin when you have a chance. --- If your

Re: [DISCUSS] Plugins Release

https://issues.apache.org/jira/browse/CB-12224 is complete (published to dist, npm and blog post is live). On Mon, Dec 12, 2016 at 10:48 AM, Shazron wrote: > Thanks Carlos and Steve for the access. > Unfortunately, one last hiccup -- when trying to publish >

[GitHub] cordova-docs issue #664: Update images.md

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-docs/pull/664 Yes @shazron, the icon problem is fixed in cordova-android 6.1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [DISCUSS] EOL cordova-medic

On Mon, Dec 12, 2016 at 1:46 PM, Jesse wrote: > What would be the added responsibilities for cordova-paramedic? Good question. As far as I can tell, I believe paramedic would need to additionally house the helper JSON files containing configuration that one passes into

[GitHub] cordova-docs issue #664: Update images.md

Github user ttimmy commented on the issue: https://github.com/apache/cordova-docs/pull/664 It was. My change was rejected, see CB-12221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] EOL cordova-medic

What would be the added responsibilities for cordova-paramedic? I am all about deleting code, but if we are simply reshuffling responsibilities then we are really not gaining/losing anything. Originally, and metaphorically ... 'medic' was the hospital and 'paramedic' was the ambulance. To

Re: [DISCUSS] EOL cordova-medic

+1 On Mon, Dec 12, 2016 at 10:57 AM, Filip Maj wrote: > Dearest cordova devs, > > I'd like to discuss the possibility of killing off the cordova-medic > repo. Kinda funny, as I landed the first commit in that repo over 4 > years ago. > > I recently sent some updates in a pull

[DISCUSS] EOL cordova-medic

Dearest cordova devs, I'd like to discuss the possibility of killing off the cordova-medic repo. Kinda funny, as I landed the first commit in that repo over 4 years ago. I recently sent some updates in a pull request to medic [1], updating some appium stuff, and after some discussion with Alex,

[GitHub] cordova-docs issue #314: Document lib-file for Android

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/314 Hi, this PR needs a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-docs issue #611: Lowercase Windows consistently through the docs

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/611 @purplecabbage can you give this a quick review? thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs issue #649: If you want to record sound on ios10 permission mus...

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/649 Please close this PR, the upcoming plugins release should have this permission added already, not only that, this note is in the wrong section. --- If your project is set up for it, you can

[GitHub] cordova-docs issue #664: Update images.md

Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/664 Has this been fixed in Cordova-Android 6.1.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request #665: Requesting the addition of Mobiscroll to the...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/665 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs issue #667: CB-12224 - Added plugins release blog post

Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/667 LGTM! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-medic issue #106: Appium updates

Github user filmaj commented on the issue: https://github.com/apache/cordova-medic/pull/106 @alsorokin ok no problem. I think we just need to move the jenkins configs over to paramedic, then we could probably delete the medic repo completely. I will start a discuss thread on the dev

[GitHub] cordova-docs pull request #667: CB-12224 - Added plugins release blog post

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/667 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request #106: Appium updates

Github user filmaj closed the pull request at: https://github.com/apache/cordova-medic/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [BLOG POST] Dec 07 2016 Plugins Release

+1 On Mon, Dec 12, 2016 at 11:19 AM, Kerri Shotts wrote: > +1 > > ~ Kerri > >> On Dec 11, 2016, at 17:17, Shazron wrote: >> >> https://github.com/apache/cordova-docs/pull/667 >> >> +1 it, etc >> >> Pending npm package publish. >

[GitHub] cordova-docs pull request #667: CB-12224 - Added plugins release blog post

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/667#discussion_r92020220 --- Diff: www/_posts/2016-12-07-plugins-release.md --- @@ -0,0 +1,231 @@ +--- +layout: post +author: +name: Shazron Abdullah +

Re: [BLOG POST] Dec 07 2016 Plugins Release

+1 ~ Kerri > On Dec 11, 2016, at 17:17, Shazron wrote: > > https://github.com/apache/cordova-docs/pull/667 > > +1 it, etc > > Pending npm package publish.

[GitHub] cordova-plugin-screen-orientation issue #2: Update YoikScreenOrientation.m

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/2 This changes is covered by the more exhaustive pr #4 Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-screen-orientation issue #5: change console.log to show Scree...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/5 Technically, this does not change anything. But it does point out that there is an issue in how toString is handled by the orientation object. Closing. --- If your

[GitHub] cordova-plugin-screen-orientation issue #3: Typo on YoikScreenOrientation.m

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/3 Thanks for the pr, this will be closed by another pull request #4 --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [BLOG POST] Dec 07 2016 Plugins Release

+1 @purplecabbage risingj.com On Mon, Dec 12, 2016 at 10:50 AM, Shazron wrote: > Edited to remove cordova-plugin-screen-orientation, it is moved to > https://issues.apache.org/jira/browse/CB-12237 > > On Sun, Dec 11, 2016 at 3:17 PM, Shazron wrote: > > >

Re: [BLOG POST] Dec 07 2016 Plugins Release

Edited to remove cordova-plugin-screen-orientation, it is moved to https://issues.apache.org/jira/browse/CB-12237 On Sun, Dec 11, 2016 at 3:17 PM, Shazron wrote: > https://github.com/apache/cordova-docs/pull/667 > > +1 it, etc > > Pending npm package publish. >

Re: [DISCUSS] Plugins Release

Thanks Carlos and Steve for the access. Unfortunately, one last hiccup -- when trying to publish `cordova-plugin-screen-orientation` to npm the version already exists (the package already existed before Apache, but now we have access). This is due to the migration of this plugin repo from a

[GitHub] cordova-windows issue #216: CB-11177 SplashScreen gets shifted on Windows de...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/216 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/216?src=pr) is 76.13% (diff: 100%) > Merging

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r92010506 --- Diff: package.json --- @@ -31,6 +31,7 @@ "cordova-common": "1.5.x", "cordova-lib": "6.4.0", "insight": "~0.8.2",

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r92009821 --- Diff: package.json --- @@ -11,7 +11,7 @@ "cordova": "./bin/cordova" }, "scripts": { -"test": "node

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/216 CB-11177 SplashScreen gets shifted on Windows devices with soft navbar ### Platforms affected Windows ### What does this PR do? Fixes splash jump bug (affected

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-cli/pull/265 CB-12018 : updated tests to function with jasmine instead of jasmine-node ### Platforms affected ### What does this PR do? Updated tests to function with jasmine

Re: [DISCUSSION] Windows tag, what should it be doing?

Does anyone have any other objections? Otherwise I'll proceed to work on this tomorrow. On Thu, Dec 8, 2016 at 8:03 PM, Shazron wrote: > +1 sounds good > > On Thu, Dec 8, 2016 at 4:36 PM, Karen Tran wrote: > > > I dug up the old pull request for this

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91970543 --- Diff: appium-tests/common/common.spec.js --- @@ -242,7 +248,6 @@ describe('Contacts Android', function () {

[GitHub] cordova-medic issue #106: Appium updates

Github user alsorokin commented on the issue: https://github.com/apache/cordova-medic/pull/106 Yeah, sorry about this confusion. I think we could get rid of medic altogether, not just the appium code. Medic was used back when we had buildbot CI up and running. Now it's just sits here

[GitHub] cordova-medic issue #106: Appium updates

Github user filmaj commented on the issue: https://github.com/apache/cordova-medic/pull/106 I see now that they are not! My mistake. I will go look around in paramedic, then :) We should probably remove this functionality from medic if it is all based in paramedic! Code

[GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91953513 --- Diff: appium-tests/common/common.spec.js --- @@ -242,7 +248,6 @@ describe('Contacts Android', function () {

[GitHub] cordova-medic issue #106: Appium updates

Github user filmaj commented on the issue: https://github.com/apache/cordova-medic/pull/106 Good question @alsorokin ! I thought that the appium-based CI tests were triggered via medic, not paramedic? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-medic pull request #106: Appium updates

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/106#discussion_r91951340 --- Diff: medic/medic-appium.js --- @@ -355,9 +358,8 @@ function isFailFastError(error) { function killProcess(procObj, killSignal, callback) {

Re: [DISCUSS] Plugins Release

Ok Shaz, you have access to all cordova plugins on npm now Keep the good work adn train moving forward shoo shoo !!! On Mon, Dec 12, 2016 at 8:06 AM Carlos Santana wrote: > Shaz giving you access at the moment, should be done in 5 minutes > > On Sun, Dec 11, 2016 at 5:37

Re: [DISCUSS] Plugins Release

Shaz giving you access at the moment, should be done in 5 minutes On Sun, Dec 11, 2016 at 5:37 PM Shazron wrote: > Hi Steve Gill and/or Carlos Santana -- please give me write access to these > npm modules below. Publishing is stalled until I get permissions. > >

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-windows pull request #215: CB-12193 cordova.js crashes windows app i...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/46 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/46 Just to clarify: the failures are caused by missing commit (I've updated my branch before tests could start). Expecting 1 more failure and then a success. --- If your

[GitHub] cordova-plugin-inappbrowser pull request #201: (Android) Implement Download ...

GitHub user Gorebar opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 (Android) Implement Download Files from URL on Android WebView. ### Platforms affected Android ### What does this PR do? Allow Download

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/46 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-battery-status pull request #46: CB-12227 (windows) Fixed Bro...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-battery-status issue #46: CB-12227 (windows) Fixed Browserify...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/46 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-battery-status pull request #46: CB-12227 (windows) Fixed Bro...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/46 CB-12227 (windows) Fixed Browserify error ### Platforms affected Windows ### What does this PR do? Fixes the `cordova run --browserify` error described here:

Re: [DISCUSS] Plugins Release

Hi Shazron Gave you permissions to packages which I have access to. - Best regards, Vladimir On 12/12/16, 01:37, "Shazron" wrote: Hi Steve Gill and/or Carlos Santana -- please give me write access to these npm modules below. Publishing is stalled until I get

[GitHub] cordova-plugin-media-capture issue #73: decrease file size

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/73 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #73: decrease file size

GitHub user saaksshi opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/73 decrease file size File size for 2 min audio was 21 MB. Now with lower bit rate it's been decreased to almost half ### Platforms affected iOS ###

[GitHub] cordova-medic pull request #106: Appium updates

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/106#discussion_r91896443 --- Diff: medic/medic-appium.js --- @@ -355,9 +358,8 @@ function isFailFastError(error) { function killProcess(procObj, killSignal, callback) {