Re: plugins and engines

Forgot about that merged proposal. What's lacking here is I think, a way for the user to override the engine version enforcement (for whatever reason, buggy CLI or plugin.xml, or they know something we don't know), something like a --force-install or something to that effect. On Wed, Jan 4, 2017

Re: plugins and engines

OK, so we've already agreed to this? Why don't we just do this? On Wed, Jan 4, 2017 at 10:52 PM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Here is another relevant proposal and discussion: > https://github.com/cordova/cordova-discuss/pull/30. I think we’ve agreed > to follow

Re: plugins and engines

Here is another relevant proposal and discussion: https://github.com/cordova/cordova-discuss/pull/30. I think we’ve agreed to follow this way to “pin” specific plugins’ versions to specific cordova versions. Here are some examples: 1.

[GitHub] cordova-plugin-media issue #124: CB-12319: (Android) Fix bug that record...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/124 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/124/commits/62270a07341a115b9eb65e278224b9f9ae3e78c8)

[GitHub] cordova-plugin-media pull request #124: CB-12319: (Android) Fix bug that...

GitHub user happy2discover opened a pull request: https://github.com/apache/cordova-plugin-media/pull/124 CB-12319: (Android) Fix bug that recorded audio files of Android cannot be played in iOS with the html tag Make the output file of Android an acc file in order to play the

[GitHub] cordova-plugin-wkwebview-engine issue #26: Allow XHR to file:// and allow lo...

Github user kerrishotts commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26 @rubenstolk: First, thanks for the contribution! However, in this instance, I agree with @shazron; the fix may work, but due to the unsupported and

Re: [Vote] 6.1.1 Android Release

I vote +1: - nightly CI builds for cordova-android have two failures, but they are both "connection broken" ones. (cc @alsorokin). otherwise looks good. I attribute this to a CI server hiccup: *

Re: [Vote] 6.1.1 Android Release

I vote +1: * Created an app using the CLI * Ran Mobilespec (debugged mobilespec) * Installed and removed plugins to make sure the functionality affected was fixed. On Wed, Jan 4, 2017 at 11:47 AM, Karen Tran wrote: > I vote +1: > * Created and ran a plain app > * Ran app from

[GitHub] cordova-ios issue #285: CB-12098 (iOS) removed spaces

Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/285 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/285?src=pr) is 64.11% (diff: 100%) > Merging [#285](https://codecov.io/gh/apache/cordova-ios/pull/285?src=pr) into

Re: [Vote] 6.1.1 Android Release

I vote +1: * Created and ran a plain app * Ran app from Android Studio * Ran mobilespec On Tue, Jan 3, 2017 at 9:03 PM, Steven Gill wrote: > Please review and vote on this 6.1.1 Android Release > by replying to this email (and keep discussion on the DISCUSS thread) > >

[GitHub] cordova-ios pull request #285: CB-12098(iOS) removed spaces

GitHub user sterlingann opened a pull request: https://github.com/apache/cordova-ios/pull/285 CB-12098(iOS) removed spaces ### Platforms affected iOS ### What does this PR do? 12098 updates supported interface return types. This PR is simply removing some extra

[GitHub] cordova-plugin-globalization issue #53: CB-11154: (Android, iOS) Add IANA ti...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-globalization/pull/53 Reviewing this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: plugins and engines

I think we should start testing plugins with cordova-android 4.1.1 as is the lower required by Google to publish on Google play. If some plugin doesn't compile then increase the engine version to next cordova-android. In example, camera plugin doesn't compile with cordova-android 4.1.1. For

Re: plugins and engines

Sounds like a good idea, but how to go about doing it? We probably can't easily, for example, rule out older versions of iOS without someone testing with an old Xcode version. On Tue, Jan 3, 2017 at 5:15 PM, Shazron wrote: > Related:

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/205 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser issue #205: CB-9148 - (android) Add support for ...

Github user darron1217 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/205 I fixed my code according to comments :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-dialogs issue #50: CB-8773: Fix for iOS 8 keyboard not appear...

Github user dirkpostma commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/50 For ionic users who suffer the same problem, I found a workaround by applying a 500ms timeout. It's bad UX because of the delay, but at least the keyboard is not dismissed

[GitHub] cordova-plugin-dialogs issue #50: CB-8773: Fix for iOS 8 keyboard not appear...

Github user dirkpostma commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/50 I still suffer from keyboard not appearing on prompt, this fix doesn't seem to work for me. I tried to debug, but couldn't find the cause. I tried setting a breakpoint in

[GitHub] cordova-ios issue #283: CB-6274 Added support for BackgroundColor preference

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/283 That would be where I would put it, since you are testing the `colorFromColorString` from CDVViewController here. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios issue #283: CB-6274 Added support for BackgroundColor preference

Github user mdoelker commented on the issue: https://github.com/apache/cordova-ios/pull/283 Right. Any hints what the correct place for this would be? It seems like there are no tests for any other preference yet. Would adding a test for the method to the CDVViewControllerTest.m be

[GitHub] cordova-plugin-wkwebview-engine issue #26: Allow XHR to file:// and allow lo...

Github user rubenstolk commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/26 I'm aware of the unsupportedness but I don't think we should give up on this. We all know that 1000s of developers are relying on UIWebView rather than WKWebView just