[GitHub] cordova-plugin-wkwebview-engine issue #5: CB-10817 The webView should reload...

2017-01-11 Thread alexfoxy
Github user alexfoxy commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5 Do you think it would be possible to show the launch screen when this happens to provide a more seamless experience? For example my app sometimes experiences a crash when you

[GitHub] cordova-cli issue #265: CB-12018 : updated tests to function with jasmine in...

2017-01-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-cli/pull/265 Yeah, not a big deal and probably not worth renaming all test cases back now, It just reminded me file transfer tests where we have 'spec.11' then `spec.9` then `spec.10`, etc. :)

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/510 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android issue #355: CB-12018 : updated tests to work with jasmine (p...

2017-01-11 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/355 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/355?src=pr) is 35.58% (diff: 100%) > Merging

[GitHub] cordova-cli issue #265: CB-12018 : updated tests to function with jasmine in...

2017-01-11 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/265 @vladimir-kotikov hey! You make a good point about it being annoying to add tests later and have to update all the numbers. And I agree the stack trace is more useful. We ran into issues

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #287: Delete the correct build output folder

2017-01-11 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/287 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/287?src=pr) is 64.11% (diff: 0.00%) > Merging [#287](https://codecov.io/gh/apache/cordova-ios/pull/287?src=pr) into

[GitHub] cordova-ios pull request #287: Delete the correct build output folder

2017-01-11 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/287 Delete the correct build output folder JIRA is down, so no JIRA ticket 🙊 ### Platforms affected iOS (Simulator, mostly) ### What does this PR do? Ensures that when

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

2017-01-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r95645698 --- Diff: spec/cli.spec.js --- @@ -134,11 +134,11 @@ describe("cordova cli", function () { describe("create", function () {

[GitHub] cordova-cli pull request #265: CB-12018 : updated tests to function with jas...

2017-01-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/265#discussion_r95635545 --- Diff: package.json --- @@ -11,8 +11,8 @@ "cordova": "./bin/cordova" }, "scripts": { -"test": "node

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95627089 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -192,34 +203,39 @@ beforeEach(function () {

[GitHub] cordova-lib pull request #510: Fixjasmine : CB:12018 - updating tests in cor...

2017-01-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/510#discussion_r95625647 --- Diff: cordova-lib/spec-plugman/platforms/windows.spec.js --- @@ -192,34 +203,39 @@ beforeEach(function () {

[GitHub] cordova-windows issue #220: CB-12298 [Windows] bundle.appxupload not generat...

2017-01-11 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/220 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/220?src=pr) is 76.93% (diff: 0.00%) > Merging

[GitHub] cordova-windows pull request #220: CB-12298 [Windows] bundle.appxupload not ...

2017-01-11 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/220 CB-12298 [Windows] bundle.appxupload not generated for Windows 10 target ### Platforms affected Windows ### What does this PR do? Adds a MSBuild flag to get

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-11 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-11 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-docs pull request #674: CB-8486 Corrected the docs on signing

2017-01-11 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/674 CB-8486 Corrected the docs on signing ### Platforms affected Windows ### What does this PR do? - Certificate Thumbprint was being extracted from wrong path -

[GitHub] cordova-plugin-camera issue #248: Fix number for sdk comparison.

2017-01-11 Thread tomchiverton
Github user tomchiverton commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/248 FYI I opened https://issues.apache.org/jira/browse/CB-12343 to track this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-globalization pull request #54: CB-11154 (Windows) Return IAN...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-globalization issue #54: CB-11154 (Windows) Return IANA timez...

2017-01-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-globalization/pull/54 🚢 it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature