Re: [Vote] Tools Release

2017-01-20 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, Android * Ability to build/run apps * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserified app builds and runs

[GitHub] cordova-plugin-file-transfer pull request #171: CB-12336 (android) Do not ca...

2017-01-20 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Hey @filmaj, nice to see you 😄 Nevermind this test, it was meant to ensure that my changes does not break downloading two files successively. The bad

RE: Platform Version support/coverage

2017-01-20 Thread Alexander Sorokin (Akvelon)
Hey guys, iOS 10 builds for periodic and per-PR jobs are up and running on Jenkins. I had some trouble with permission dialogs busting, but now everything seems to be in order. Woo! http://cordova-ci.cloudapp.net:8080/view/Periodic%20builds/job/cordova-periodic-build/293/ --Alex -Original

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 oo, nice catch! However, I fail to see how the test added is exercising the `abort()` code path? I'm not actually sure what the test is doing other than ensuring a

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

2017-01-20 Thread ramses80
Github user ramses80 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/115 hellow.julymartin.can.you.herme.or.not --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file-transfer issue #171: CB-12336 (android) Do not call win ...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/171 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-dialogs issue #90: CB-12353 Corrected merges usage in plugin....

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/90 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-device-orientation issue #32: CB-12353 Corrected merges usage...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/32 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #74: CB-12353 Corrected merges usa...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media pull request #125: CB-12353 Corrected merges usage in p...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file-transfer pull request #172: CB-12353 Corrected merges us...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file pull request #200: CB-12353 Corrected merges usage in pl...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs pull request #90: CB-12353 Corrected merges usage in ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-orientation pull request #32: CB-12353 Corrected merge...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-device-motion pull request #49: CB-12353 Corrected merges usa...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-device pull request #59: CB-12353 Corrected merges usage in p...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-inappbrowser issue #208: CB-12353 Corrected merges usage in p...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/208 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts pull request #147: CB-12353 Corrected merges usage i...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request #249: CB-12353 Corrected merges usage in ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-splashscreen pull request #122: CB-12353 Corrected merges usa...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #208: CB-12353 Corrected merges usa...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-splashscreen issue #122: CB-12353 Corrected merges usage in p...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/122 Cordova CI Build has completed successfully. **Commit** -

RE: CB-11602: (android) Adds onRestart event support

2017-01-20 Thread daserge
Hello, There's a related issue marked as WontFix [1][2] but as far as I understand it does not apply to the SplashScreen plugin as it is initialized on startup (via ). So the question is - should we add onRestart as it is not fundamentally different from onStart, which is supported? Or is

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-01-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request #212: Add 'hide' method in typing d...

2017-01-20 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Add 'hide' method in typing definitions You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-inappbrowser issue #208: CB-12353 Corrected merges usage in p...

2017-01-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/208 @daserge, should we really remove windows8 section? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-splashscreen pull request #123: CB-12369: Add plugin typings ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-splashscreen issue #123: CB-12369: Add plugin typings from De...

2017-01-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/123 Travis failure is unrelevant to this change, so merging. However I found that native tests are passing with cordova-ios@4.3.0 and failing w/ 4.3.1 /cc @shazron,

[GitHub] cordova-plugin-battery-status pull request #49: CB-12369: Add plugin typings...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-vibration pull request #51: CB-12369: Add plugin typings from...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request #75: CB-12369: Add plugin typings from...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-network-information pull request #53: CB-12369: Add plugin ty...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-media pull request #126: CB-12369: Add plugin typings from De...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media-capture pull request #75: CB-12369: Add plugin typings ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #211: CB-12369: Add plugin typings ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request #173: CB-12369: Add plugin typings...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-globalization pull request #55: CB-12369: Add plugin typings ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-dialogs pull request #91: CB-12369: Add plugin typings from D...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-orientation pull request #33: CB-12369: Add plugin typ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-device pull request #60: CB-12369: Add plugin typings from De...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device-motion pull request #50: CB-12369: Add plugin typings ...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-contacts pull request #148: CB-12369: Add plugin typings from...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-camera pull request #250: CB-12369: Add plugin typings from D...

2017-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the