[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...

2017-02-09 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 I think something like [this](https://gist.github.com/cjpearson/ae2a1c12e4737549721ec3c04e617789) should work. You can add the files to your Xcode project or create a

[GitHub] cordova-plugin-media issue #127: CB-12434 (Android) fix Stoping a Paused Rec...

2017-02-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/127 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #127: CB-12434 (Android) fix Stoping a Paused Rec...

2017-02-09 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-plugin-media/pull/127 @jcesarmobile yes, merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-media issue #127: CB-12434 (Android) fix Stoping a Paused Rec...

2017-02-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/127 @macdonst can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media pull request #127: CB-12434 (Android) fix Stoping a Pau...

2017-02-09 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-media/pull/127 CB-12434 (Android) fix Stoping a Paused Recording throws exception ### Platforms affected Android ### What does this PR do? When you pause the recording

[GitHub] cordova-android issue #358: CB-12424: (android) Fix encoding of multipart me...

2017-02-09 Thread kalliste
Github user kalliste commented on the issue: https://github.com/apache/cordova-android/pull/358 Sure! I can edit this and submit a new pull request --- What would be least confusing to you? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-android issue #358: CB-12424: (android) Fix encoding of multipart me...

2017-02-09 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/358 Can we have better method names? encodeJsMessage and encodeMessageAsJsMessage looks confusing. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugins pull request #28: CB-12443 CB-10959 (ios) include path and f...

2017-02-09 Thread jordanhaven
GitHub user jordanhaven opened a pull request: https://github.com/apache/cordova-plugins/pull/28 CB-12443 CB-10959 (ios) include path and fragment when updating startPage When setting the startPage, ensure that paths and fragments are included You can merge this pull request into a

[GitHub] cordova-plugin-camera issue #190: Allowing camera plugin to set an container...

2017-02-09 Thread NiltonFelicio
Github user NiltonFelicio commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/190 You also need to do something like that. Allowing camera plugin to set an container id for camera preview and button. But in my case it would be with ionic2, is it possible? I

Re: [Vote] 5.0.0 Windows Release

2017-02-09 Thread Karen Tran
I vote +1 - Tested tag functionality is copying or referencing if reference attribute is set - Tested compatibility with Visual Studio - Ran automated tests On Thu, Feb 9, 2017 at 9:24 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com.invalid> wrote: > I vote +1 > > - Verified licenses

Re: Temporary turbulence on the CI

2017-02-09 Thread Filip Maj
Holy cow! This is so awesome Alex, awesome job! I've started watching the issue, perhaps we can make that test server more stable so we can more effectively leverage Sauce for the testing. On Thu, Feb 9, 2017 at 5:52 AM, wrote: > I think I've stabilized the builds now.

[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...

2017-02-09 Thread rubenstolk
Github user rubenstolk commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 @cjpearson Good idea, for that we need to have some kind of hook in the regular `createConfigurationFromSettings` implementation. I'm not really into Objective C so not

Re: [Vote] 5.0.0 Windows Release

2017-02-09 Thread Vladimir Kotikov (Akvelon)
I vote +1 - Verified licenses and license headers - Ran automates tests - Verified archive - Verified tag - Best regards, Vladimir On 2/9/17, 09:57, "alsoro...@apache.org" wrote: I vote +1. * Verified archives via `coho verify-archive` * Verified tags

[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...

2017-02-09 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 @rubenstolk, you could try creating a plugin that swizzles `createConfigurationFromSettings` and adds your changes. Then anybody who wants this fix can just install your

RE: Temporary turbulence on the CI

2017-02-09 Thread alsorokin
I think I've stabilized the builds now. Each node now has 2 executors. Each separate build takes longer to complete but because a lot more builds can now be executed in parallel, we've got ~70% performance increase overall. One thing to note though is that I moved the file transfer builds back to