Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/58
hey @yamane-dsys!
Your PR is in great shape. I appreciate you adding tests too!
Unfortunately, I don't think I can accept this PR. We only add new
properties to
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/57
Agree with @pke. Close 57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TommiKetola commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
Looking closer at other pull requests, merging #122 should make this patch
unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/19
As sinzianag mentioned, this needs to be updated to add support for the
permission helper. Tests would be nice too.
---
If your project is set up for it, you can reply
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-vibration/pull/48
Why do you want to add .csproj to the .gitignore? This plugin has a .csproj
it needs to commit. Just wondering what your usecase is.
---
If your project is set up for it, you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/130
Cordova CI Build has completed successfully.
**Commit** -
GitHub user ghenry22 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/130
CB-8098 & CB-7810:(android) Added media rate for android
### Platforms affected
Android
### What does this PR do?
adds set rate function for android
this already
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
@shazron - this would be a great one to get in, I am having this issue
frequently now on android with more apps having audible announcements and
prompts. Nothing like having your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Nightly build #261 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/261/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/261/consoleFull
-
Jenkins for Apache Cordova
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/289
Thanks Kevin - this is a good building block anyways, in a bigger puzzle --
we'll punt that problem off for later. I'll pull this in after I get some time
to review it further.
---
If your
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
This pr does address part of the issue, I think we can move ahead with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
I've started a discuss thread on this subject.
https://github.com/cordova/cordova-discuss/issues/64
@purplecabbage
risingj.com
On Tue, Feb 21, 2017 at 4:20
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
We should ultimately just be checking that there is a valid platformAPI,
and if so, use it, otherwise fail.
( super simplification )
@purplecabbage
risingj.com
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/519
Yeah, it's deep. If a platform does not have a known name, there will be
issues currently.
The only way right now is to fork a blessed platform, but there is no way
to easily
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/519
The `src/platforms/platforms.js` file touches almost all commands,
particularly the use of the `getPlatformAPI` call, so removing this is tricky
-- but at least there is only one API call to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/519
re:
https://issues.apache.org/jira/browse/CB-11346?focusedCommentId=15875577=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15875577
Looks like there is more
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/289
You are correct: the support added here would only enable the consumption
of the Cordova iOS dependency itself from Carthage, at this point. Or maybe
more accurately, it's the first step in
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/518
I think this is ready to merge in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/518#discussion_r102321817
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg,
target, fetchOptions) {
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/209
Thanks for the PR, I've merged it after making sure that changing the
window level doesn't break the changes introduced in #187
---
If your project is set up for it, you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121
Closed the PR, it was already covered by #89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/88
@cjpearson as this was never merged for CB-3750, I've created CB-12479 to
track the Android spinner.
Can you change the title to link CB-12479 and also rebase fixing
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/176
Cordova CI Build has completed successfully.
Please note that a lot of tests are currently disabled on CI. To make sure
everything works, please run tests locally
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/176
CB-12439 (Tests) Re-enable the tests
### Platforms affected
All
### What does this PR do?
* Some tests now retry up to 100 times due to Heroku giving
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/254#discussion_r102245774
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -82,11 +86,43 @@ describe('Camera tests iOS.', function () {
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Cordova CI Build has one or more failures.
**Commit** -
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Cordova CI Build has one or more failures.
**Commit** -
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Cordova CI Build has one or more failures.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Cordova CI Build has one or more failures.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Cordova CI Build has one or more failures.
**Commit** -
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Cordova CI Build has one or more failures.
**Commit** -
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/50
Testing PR job
Don't merge me
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-battery-status
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
Cordova CI Build has completed successfully.
**Commit** -
GitHub user TommiKetola opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/129
(android) Fix NullPointerException in AudioPlayer.readyPlayer
### Platforms affected
Android
### What does this PR do?
Fixes null pointer exception with
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/254#discussion_r102157186
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -82,11 +86,43 @@ describe('Camera tests iOS.', function () {
47 matches
Mail list logo
