[GitHub] cordova-ios issue #290: test

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/290 @iPhuan please close this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Nightly build #263 for cordova has failed

Nightly build #263 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/263/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/263/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 There is a test failed on SM-G9250. > org.apache.cordova.unittests.IFrameTest > iFrameHistory[SM-G9250 - 6.0.1] FAILED at junit.framework.Assert.fail(Assert.java:48) And

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 FYI: I'll be collapsing the commits on Friday when I merge this thing in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-contacts issue #51: Windows phone contact picker filter

Github user Hurtyto commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/51 Just accept it. No need to sign. On Feb 23, 2017 21:05, "Fil Maj" wrote: > Until @Hurtyto signs the ICLA, we

[GitHub] cordova-plugin-contacts pull request #81: update blackbery10 to npm dependen...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #81: update blackbery10 to npm dependencies

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/81 Haha I was only semi-serious about the review but thanks anyways! I think I will merge this in... --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-contacts pull request #150: Intentionally fail one test to ch...

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-contacts pull request #146: CB-12326

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #81: update blackbery10 to npm dependencies

Github user gtanner commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/81 Oh wow :) talk about a blast from the past. Can't offer more then the two new dependencies are both in npm and authored by Tim Windsor who I know works (or worked) at

[GitHub] cordova-plugin-contacts issue #150: Intentionally fail one test to check CI

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/150 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts issue #146: CB-12326

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/146 Oh, and @mad-nuts have you signed an Apache ICLA? (individual contributor license agreement) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-contacts issue #146: CB-12326

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/146 Thanks for the review @infil00p ! @mad-nuts can you do me a favour and rebase w/ the latest master and force-push up to your branch, for one more CI / cordova-qa run, please?

Re: [Discuss] plugins release

I've worked through the contacts plugin PRs, and either closed them, pinged the authors for rebases/updates/more info, or pinged platform maintainers for some extra eyes on ones I am unsure about. Current state of plugin PRs: cordova-plugin-inappbrowser --> Last week: 30, Today: 38 - it's

[GitHub] cordova-plugin-contacts issue #146: CB-12326

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/146 Honestly, the Contacts API on Android itself is buggy and unpredictable. Just run adb logcat without debugging anything and you'll see a stack trace from Facebook, Twitter,

[GitHub] cordova-plugin-contacts pull request #150: Intentionally fail one test to ch...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/150 Intentionally fail one test to check CI Don't merge me You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-contacts pull request #122: [CB-8076] Provide error support f...

Github user surajpindoria closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-contacts issue #122: [CB-8076] Provide error support for brow...

Github user surajpindoria commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/122 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-android issue #364: CB-8348: (android) Updating version number

Github user bhariharan commented on the issue: https://github.com/apache/cordova-android/pull/364 @stevengill I realized that you're trending towards `6.2.0`, so I updated the version number to accurately reflect that. You might want to tweak this to pull in the version number from

[GitHub] cordova-plugin-contacts pull request #10: [iOS]Fixed issue about classes in ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android pull request #364: CB-8348: (android) Updating version numbe...

GitHub user bhariharan opened a pull request: https://github.com/apache/cordova-android/pull/364 CB-8348: (android) Updating version number ### Platforms affected Android ### What does this PR do? Updates the version from `6.1.0` to `6.2.0`. ### What

[GitHub] cordova-plugin-contacts issue #10: [iOS]Fixed issue about classes in Address...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/10 Until we get an ICLA from @huanghf, we cannot do much. There are also merge conflicts in this 3.5 year old pull request. I will close this pull request. @huanghf if you have

[GitHub] cordova-plugin-contacts issue #134: CB-11855: (ios) Allow iOS to use hasPhon...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 @soonahn it looks like the tests are hanging in this pull request, across all platforms, surprisingly! I think it may be because your branch is ~25 commits behind master.

[GitHub] cordova-lib issue #520: CB-11977 : removed support for node 0.x

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/520 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/520?src=pr=h1) Report > Merging [#520](https://codecov.io/gh/apache/cordova-lib/pull/520?src=pr=desc) into

[GitHub] cordova-plugin-contacts issue #51: Windows phone contact picker filter

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/51 Until @Hurtyto signs the ICLA, we cannot accept this patch :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts issue #81: update blackbery10 to npm dependencies

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/81 Ping @gtanner for review please and thank you ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-contacts issue #134: CB-11855: (ios) Allow iOS to use hasPhon...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-contacts issue #70: Remove ops

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/70 As discussed, the issue in question should be discussed and a problem identified first before a solution is proposed. If this is still a problem, please head over to

[GitHub] cordova-plugin-contacts pull request #70: Remove ops

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/363 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr=desc) into

[GitHub] cordova-plugin-contacts pull request #71: Try catch finally cursors

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #71: Try catch finally cursors

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/71 There are merge conflicts in this pull request, and I believe a more complete and up-to-date implementation is in #146 (along with try/catch protection when interacting with the

[GitHub] cordova-plugin-contacts issue #88: CB-9348 Fetch phoneNumbers and emails fro...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/88 FWIW, the latest UI automation framework on iOS 9.3+, XCUITest, _should_ allow interacting with built-in/preinstalled applications. However, in practice we won't be able to elegantly

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei OK, yeah, this is a minor mistake. The errorUrl wasn't correct in the config.xml, the test passes and it no longer hangs. --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-contacts pull request #102: Label for custum type phone numbe...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #102: Label for custum type phone numbers

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/102 This pull request has merge conflicts at this point, and I believe a more-complete pull request satisfying this functionality (without merge conflicts) is already live at #146.

[GitHub] cordova-plugin-contacts pull request #103: back button not working fine...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #103: back button not working fine...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/103 This pull request is either malformed or a mistake happened. There is no code here to test! Closing this. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-contacts issue #107: CB-10784: CDVContactsPicker finish anima...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/107 Ping @shazron once more for a quick review, please and thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-contacts issue #109: CB-10935: fix an issue of can not sync n...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/109 Ping @shazron - what do you think of this? Looks like we're forcing decoding base64 image data in a contact to help with an alleged iCloud sync issue. --- If your project is set up

[GitHub] cordova-plugin-camera issue #255: CB-12501 (Android) Appium tests don't use ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/255 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-contacts pull request #130: CB-11532: (ios) Fix bug with bad ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts issue #130: CB-11532: (ios) Fix bug with bad charact...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/130 Please see the discussion in [CB-11532](https://issues.apache.org/jira/browse/CB-11532) for details on the issue. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-contacts issue #134: CB-11855: (ios) Allow iOS to use hasPhon...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-camera issue #255: CB-12501 (Android) Appium tests don't use ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/255 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-camera issue #255: CB-12501 (Android) Appium tests don't use ...

Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/255 Yeah, finally --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-camera issue #255: CB-12501 (Android) Appium tests don't use ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/255 Would be nice to get rid of the multiple-calls-to-elements-via-xpath :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-camera issue #255: CB-12501 (Android) Appium tests don't use ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/255 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-camera pull request #255: CB-12501 (Android) Appium tests don...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/255 CB-12501 (Android) Appium tests don't use XPath selectors anymore ### Platforms affected Android ### What does this PR do?

[GitHub] cordova-plugin-contacts issue #146: CB-12326

Github user mad-nuts commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/146 I've tried for hours to reproduce the error, but the app just won't crash anymore. Something must have changed since then and I don't know what it is...

[GitHub] cordova-plugin-media pull request #99: Suppress warnings: Pass in the settin...

Github user charliewilliams closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media issue #99: Suppress warnings: Pass in the settings obje...

Github user charliewilliams commented on the issue: https://github.com/apache/cordova-plugin-media/pull/99 Excellent, glad it's in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media issue #99: Suppress warnings: Pass in the settings obje...

Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/99 I had a PR for the same issue which has just been merged and is in master. Installing the media plugin from github confirms the errors in xcode are resolved. This PR could be