[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-03-08 Thread shanesmith
Github user shanesmith commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This change has broken recording from what I'm seeing. The plugin requires the file to have a "wav" extension, however now that the audio is being encoded as

Nightly build #276 for cordova has failed

2017-03-08 Thread Apache Jenkins Server
Nightly build #276 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/276/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/276/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-screen-orientation issue #12: Follows spec w3 c

2017-03-08 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/12 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-screen-orientation pull request #12: Follows spec w3 c

2017-03-08 Thread maverickmishra
GitHub user maverickmishra opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/12 Follows spec w3 c ### Platforms affected iOS, Android, Windows ### What does this PR do? The PR makes the plugin conform to exact W3C specs.

[GitHub] cordova-android issue #365: CB-12524: Fix the GradleBuilder so that it build...

2017-03-08 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/365 Closing this PR because we can't distribute JARs, we have to find another solution. Apologies. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android pull request #365: CB-12524: Fix the GradleBuilder so that i...

2017-03-08 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

2017-03-08 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/289 Thanks @khawkins ! I'll let the CI run, then merge these in. No worries, I can squash on my end --- If your project is set up for it, you can reply to this email and have your reply appear on

[DISCUSS] Cordova 7 Prep

2017-03-08 Thread Steven Gill
Hey Folks, We got many cordova@7 related prs waiting to be merged. I've held off on merging them incase we wanted to do another 6.x release. I am going to start merging them. If we need another 6.x release, we can branch off the previous release branch. 6.5.x Some Prs to review/merge *

[GitHub] cordova-lib issue #524: CB-12528 use fs instead of our own existsSync

2017-03-08 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/524 It was deprecated for a time but then got undeprecated. Great find! https://github.com/nodejs/node/issues/1592 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

2017-03-08 Thread khawkins
Github user khawkins commented on the issue: https://github.com/apache/cordova-ios/pull/289 Okay @shazron , I've rebased and updated the deployment target of the framework to 9.0. All tests are passing. Let me know if you'd like me to squash these review commits down. --- If your

[GitHub] cordova-plugin-media issue #131: CB-1254: (ios) Fix wav file recording, add ...

2017-03-08 Thread chmac
Github user chmac commented on the issue: https://github.com/apache/cordova-plugin-media/pull/131 Would be awesome to get this merged, just took me several hours to figure out why this wasn't working until I eventually found this PR. Thanks @leopatras for posting. 👍 ---

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

2017-03-08 Thread khawkins
Github user khawkins commented on the issue: https://github.com/apache/cordova-ios/pull/289 Actually, I end up seeing a ton of warnings now complaining about the fact that I didn't otherwise do that, so that probably answers my question. 😉 I'll have the update pushed shortly.

[GitHub] cordova-android issue #366: CB-12546: More robust support spawning the emula...

2017-03-08 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/366 Ah, I forgot to ping you: please review @infil00p --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

2017-03-08 Thread khawkins
Github user khawkins commented on the issue: https://github.com/apache/cordova-ios/pull/289 No worries @shazron ! Question: I see that 2a323fad2156a434e928eb570e7f272921b75d6a moved the iOS deployment target up to 9.0. I presume I should amend the framework target to do the same?

[GitHub] cordova-android pull request #366: CB-12546: More robust support spawning th...

2017-03-08 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-android/pull/366 CB-12546: More robust support spawning the emulator with newer Android SDK ### Platforms affected Android ### What does this PR do? Two things related to