Nightly build #292 for cordova has succeeded!

Nightly build #292 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/292/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/137/commits/36e4fdf22820f750d96774e0e254327aca062dec)

[GitHub] cordova-plugin-media pull request #121: CB-12146: (android) Adds support for...

Github user romedius closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Old PR: #121 One question: I couldn't test the `onMessage(String id, Object data) {` method and its affects. when is this triggered? --- If your project is set

[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...

Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 New PR: https://github.com/apache/cordova-plugin-media/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-media pull request #137: CB-12146 (android) Adding playAudioW...

GitHub user romedius opened a pull request: https://github.com/apache/cordova-plugin-media/pull/137 CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android When loosing focus of the app in android (onPause()) the audio playback is paused when playAudioWhenScreenIsLocked

[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...

Github user robertoandrade commented on the issue: https://github.com/apache/cordova-lib/pull/399 Will check it out let you guys know. On Fri, Mar 24, 2017 at 9:03 PM Shazron Abdullah wrote: > @robertoandrade

[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/399 @robertoandrade I want to get this in, any word? If not I can just fork your branch and do the edits needed --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib issue #508: CB-11908 Add tests for edit-config in config.xml and...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/508 Hey @ktop! Any chance you can rebase this? If not, let us know and I can take a look at reimplementing. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #514: CB-12337 Resolve symbolic links in project ro...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108009704 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108009309 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r107994895 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #489: CB-11811 - Updated travis settings for CocoaP...

Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Plugin search is broken

Cool. Thanks! :-) ~ Kerri > On Mar 24, 2017, at 12:52, Shazron wrote: > > Here: > https://github.com/apache/cordova-docs/blob/a3589ce66336821f2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js > > On Fri, Mar 24, 2017 at 5:36 AM, Kerri Shotts wrote:

Re: [DISCUSS] Plugin search is broken

Here: https://github.com/apache/cordova-docs/blob/a3589ce66336821f2fd714a1115125cfcfa9fd1b/www/static/plugins/app.js On Fri, Mar 24, 2017 at 5:36 AM, Kerri Shotts wrote: > +1 to moving off npmsearch. > > While I’m thinking of it — where does the code for the plugin search

[GitHub] cordova-android issue #304: fix crash when calling methods on a destroyed we...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/304 1. We need a JIRA for this 2. This has become more interesting since we need to add an Android O version of this code to handle it better, because the renderer goes away, not the whole

[GitHub] cordova-android pull request #370: CB-12595: Fix Android Studio Detection (m...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r107954943 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -114,13 +135,19 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r107954295 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #522: CB-12016 : removes pluginId mapping

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/522#discussion_r107952809 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -255,13 +235,7 @@ function checkID(expectedIdAndVersion, pinfo) { if (!expectedIdAndVersion)

Re: [DISCUSS] Plugin search is broken

+1 to moving off npmsearch. While I’m thinking of it — where does the code for the plugin search live? I found variations on it, but not sure I ever came across the canonical version. ~ Kerri > On Mar 23, 2017, at 16:04, Shazron wrote: > > I'm going to assume by lazy

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/11 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

Github user Sh1d0w commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/11 @cnspaha Can you advise on the issue above, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

Github user cnspaha commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/11 @purplecabbage applied your proposed changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-screen-orientation issue #11: CB-12543 (iOS) Set orientation ...

Github user Sh1d0w commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/11 The proposed fix works ok (reverted `screenObject.nativeLock !== null` back to `screenObject.nativeLock != null`), expect that it does not force rotate the screen if you are

Re: [DISCUSS] Update iOS Embedded WebView docs for Carthage

Sent from my iPhone > On 24 Mar 2017, at 01:11, Shazron wrote: > > Yes for plugins we have to use plugman. > > Why Carthage and not CocoaPods? > > Firstly I like that Carthage is not opinionated like CocoaPods -- you have > to have a Podfile, podspec, etc, and it creates

[GitHub] cordova-lib issue #489: CB-11811 - Updated travis settings for CocoaPods tes...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/489 can we close this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib issue #424: CB-11062 Add --recursive option to git clone command

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/424 I think I'm going to close this. In cordova-7, we don't use gitclone.js and instead use cordova-fetch which runs npm install under the hood. --- If your project is set up for it, you can

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r107840862 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -114,13 +135,19 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r107840945 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -63,7 +64,27 @@ function installPlatformsFromConfigXML(platforms, opts) {

[GitHub] cordova-lib pull request #455: CB-10438 Install correct dependency version, ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #530: CB-10438 : Install correct dependency version

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/530 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #530: CB-10438 : Install correct dependency version

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature