[GitHub] cordova-docs pull request #689: CB-12591 : Updating cordova docs to reflect ...

2017-03-29 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/689#discussion_r108813703 --- Diff: www/docs/en/dev/platform_plugin_versioning_ref/index.md --- @@ -27,7 +27,7 @@ From version 4.3.0 onwards, Cordova provides the ability to

[GitHub] cordova-lib issue #533: CB-12250 CB-12409 iOS: Fix bug with escaping propert...

2017-03-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/533 CI failure is unrelated to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-29 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108751887 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108737235 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) {

RE: [Vote] 6.2.0 Android Release

2017-03-29 Thread alsorokin
Whoops, re-sending from the apache mailbox to avoid hitting spam-filters. -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com.INVALID] Sent: Wednesday, March 29, 2017 6:59 PM To: dev@cordova.apache.org Subject: RE: [Vote] 6.2.0 Android Release I vote +1.

RE: [Vote] 6.2.0 Android Release

2017-03-29 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can successfully build and run * Verified that platform can be updated from previous version * Verified compatibility with core

[GitHub] cordova-lib pull request #533: CB-12250 CB-12409 iOS: Fix bug with escaping ...

2017-03-29 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/533 CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file ### Platforms affected iOS ### What does this PR do? This PR fixes some bugs with