Re: [DISCUSS] Cordova@7 Release

2017-04-21 Thread Filip Maj
Any specific things worth manually testing out above and beyond what our CI does? On Fri, Apr 21, 2017 at 6:56 PM, Shazron wrote: > Yes! > I'll get on https://issues.apache.org/jira/browse/CB-12655 for the release > (its on the board) > > On Fri, Apr 21, 2017 at 4:49 PM, Jesse

[GitHub] cordova-plugin-media issue #136: mediaFile.play(); its not working

2017-04-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/136 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-file pull request #203: 4.3.x

2017-04-21 Thread mnharvey
Github user mnharvey closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request #203: 4.3.x

2017-04-21 Thread mnharvey
GitHub user mnharvey opened a pull request: https://github.com/apache/cordova-plugin-file/pull/203 4.3.x ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ]

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-21 Thread Shazron
Umm typo: REMOVED: iOS 8 Support On Fri, Apr 21, 2017 at 5:27 PM, Shazron wrote: > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=162 > > cordova-ios@4.4.0 is feature complete. Vote thread upcoming. > > ## HIGHLIGHTS > > NEW: tag support in config.xml >

Re: [DISCUSS] cordova-ios@4.4.0 release

2017-04-21 Thread Shazron
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=162 cordova-ios@4.4.0 is feature complete. Vote thread upcoming. ## HIGHLIGHTS NEW: tag support in config.xml FIXED: target attribute was ignored in plugin.xml NEW: Carthage support NEW: support in plugin.xml to put custon

[GitHub] cordova-ios pull request #310: CB-12009 - target attribute i...

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Cordova@7 Release

2017-04-21 Thread Shazron
Yes! I'll get on https://issues.apache.org/jira/browse/CB-12655 for the release (its on the board) On Fri, Apr 21, 2017 at 4:49 PM, Jesse wrote: > Let's do it! > > > @purplecabbage > risingj.com > > On Fri, Apr 21, 2017 at 4:48 PM, Steven Gill >

Re: [DISCUSS] Cordova@7 Release

2017-04-21 Thread Jesse
Let's do it! @purplecabbage risingj.com On Fri, Apr 21, 2017 at 4:48 PM, Steven Gill wrote: > The time is nearly upon us! Next week I want to get the vote for cordova@7 > out. We have a couple more prs I plan on merging in. > > I recommend folks start testing it via

[DISCUSS] cordova-android@6.2.2 release

2017-04-21 Thread Steven Gill
Need to do another patch release due to android sdk tools being updated by google. Any concerns?

[DISCUSS] Cordova@7 Release

2017-04-21 Thread Steven Gill
The time is nearly upon us! Next week I want to get the vote for cordova@7 out. We have a couple more prs I plan on merging in. I recommend folks start testing it via `npm i -g cordova@nightly` Post any links here for PRs you think should make it in. Any questions?

[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...

2017-04-21 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/18 CB-12684 : added package.json to default hello world app ### Platforms affected ### What does this PR do? Added package.json to default hello world

[GitHub] cordova-ios pull request #310: CB-12009 - target attribute i...

2017-04-21 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/310 CB-12009 - target attribute ignored on iOS when installing a Cordova plugin ### Platforms affected self ### What does this PR do? Fix bug where `target` attribute

[GitHub] cordova-plugin-wkwebview-engine issue #33: Fixing some Xcode warnings

2017-04-21 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/33 @stevengill @shazron FYI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-wkwebview-engine pull request #33: Fixing some Xcode warnings

2017-04-21 Thread bhariharan
GitHub user bhariharan opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/33 Fixing some Xcode warnings ### Platforms affected `iOS` ### What does this PR do? Fixes some `Xcode` warnings ### What testing has been

[GitHub] cordova-lib pull request #548: CB-12683: improved error messaging for when a...

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request #277: CB-12683: fixed error handling

2017-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #548: CB-12683: improved error messaging for when a plugin...

2017-04-21 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-lib/pull/548 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib issue #548: CB-12683: improved error messaging for when a plugin...

2017-04-21 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/548 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/548?src=pr=h1) Report > Merging [#548](https://codecov.io/gh/apache/cordova-lib/pull/548?src=pr=desc) into

[GitHub] cordova-cli pull request #277: CB-12683: fixed error handling

2017-04-21 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-cli/pull/277 CB-12683: fixed error handling ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ###

[GitHub] cordova-lib pull request #548: CB-12683: improved error messaging for when a...

2017-04-21 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/548 CB-12683: improved error messaging for when a plugin doesn't have pac… …kage.json ### Platforms affected ### What does this PR do? ### What

[GitHub] cordova-windows issue #80: CB-9057: Replaced the Windows 10 Preview version ...

2017-04-21 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-windows/pull/80 http://cordova.apache.org/docs/en/6.x/guide/cli/index.html#using-merges-to-customize-each-platform --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-04-21 Thread jonasof
Github user jonasof commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 Hello MeirBon and Gorebar, I make some improvements on your code, some are breaking changes to current behaviour: 1. I add the External Storage permissions to

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

2017-04-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...

2017-04-21 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-lib/pull/542 @stevengill, 1. install cordova via coho (`cordova -v` outputs `6.5.1-dev (cordova-lib@6.5.1-dev)`) 2. run `cordova plugin add cordova-plugin-inappbrowser` output:

[GitHub] cordova-windows issue #80: CB-9057: Replaced the Windows 10 Preview version ...

2017-04-21 Thread peterjuras
Github user peterjuras commented on the issue: https://github.com/apache/cordova-windows/pull/80 I'm trying to include ui.js only in the Windows build of our app. Do you know a plugin which could achieve this? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-camera pull request #262: fix(error): changes error message f...

2017-04-21 Thread stalniy
GitHub user stalniy opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/262 fix(error): changes error message for ios in case if user cancel ### Platforms affected iOS, Android ### What does this PR do? changes cancel error message

[GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...

2017-04-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/78 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-statusbar issue #64: CB-11858: Add possibility to utilize And...

2017-04-21 Thread urmx
Github user urmx commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 According to [this plugin README][1] and the [official Apple reference][1], the deprecated styles "blackTranslucent", "blackOpaque" and "black" are meant to be used for a light content

[GitHub] cordova-plugin-statusbar pull request #78: CB-11858: (android) Add StatusBar...

2017-04-21 Thread urmx
GitHub user urmx opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/78 CB-11858: (android) Add StatusBarStyle feature support for Android M+ ### Platforms affected Android 6.0+ (API level 23+) ### What does this PR do? This PR

[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...

2017-04-21 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/76 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #76: Audio Capture - added support...

2017-04-21 Thread momomatteo
GitHub user momomatteo opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/76 Audio Capture - added support for iPhone 6 and iPhone 6 Plus microphone images ### Platforms affected iOS ### What does this PR do? Added

[GitHub] cordova-android issue #377: CB-8980: Ensure copied resource-files are cleane...

2017-04-21 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/377 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr=h1) Report > Merging [#377](https://codecov.io/gh/apache/cordova-android/pull/377?src=pr=desc) into

[GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....

2017-04-21 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/321 With regards to point 1 above, I've found the root cause: In a project-level config.xml, `resource-file` is only supported under a `platform` tag. These files get copied into the native

[GitHub] cordova-android pull request #377: CB-8980: Ensure copied resource-files are...

2017-04-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/377 CB-8980: Ensure copied resource-files are cleaned Requires https://github.com/apache/cordova-lib/pull/547 for the intended functionality, but is safe to merge even without it.

[GitHub] cordova-lib issue #547: CB-8978: Add option to get resource-file from root

2017-04-21 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/547 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr=h1) Report > Merging [#547](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr=desc) into

[GitHub] cordova-ios pull request #309: CB-8980: Ensure copied resource-files are cle...

2017-04-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-ios/pull/309 CB-8980: Ensure copied resource-files are cleaned Requires https://github.com/apache/cordova-lib/pull/547 for the intended functionality, but is safe to merge even without it.

[GitHub] cordova-lib pull request #547: CB-8978: Add option to get resource-file from...

2017-04-21 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/547 CB-8978: Add option to get resource-file from root Step 1 of resolving the first issue mentioned in https://github.com/apache/cordova-android/pull/321#issuecomment-294985346 Step 2 will be