By the way, we now do per-commit builds on the cloudapp CI for the platforms.
Here's this revision's build (SPOILER: all tests green):
http://cordova-ci.cloudapp.net:8080/job/cordova-ios-commit/36/
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Saturday, April 22,
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/78
Cool, so we can fall back on your PR should @urmx be unable to. What about
you, @urmx ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user Lemon-King commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
The patch itself allows WebView and CookieManager's cookies to be used
together really.
It won't overwrite WebView but join WebView and CookieManager together as a
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
I see, so any custom handling of cookies via CookieManager are being
appended over and on top of whatever the WebView is handling. I guess if there
are conflicts between the
Github user tobiasviehweger commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/78
@filmaj I did, actually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user stalniy commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
Agree.
"No Image Selected" is better. I will change this, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user alsorokin commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/149
@videmort are you affected by this issue? Can you show us some repro so we
are certain that the fix is working?
---
If your project is set up for it, you can reply to this email
Github user Lemon-King commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
Can do.
This PR resolves an issue we came across on our framework with File
Transfer and were unsure if others were dealing with the same problem.
The issue
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/199
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file/pull/199/commits/1a4361fdb5cad6be5731c6d85742311d6e169a4a)
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-docs/pull/696
CB-12686 - Add docs for support in config.xml
### What does this PR do?
Adds docs for config.xml support
### Checklist
- [X] [Reported an
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-docs/pull/695
CB-12655 - Add docs for embed attribute of tag
### What does this PR do?
Adds docs for the embed attribute of the tag (iOS only)
### Checklist
- [X] [Reported an
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/199
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
I think we should try to write a test for this, if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/88
Please stop using pull requests to ask questions. Feel free to use Slack or
contact us on our mailing lists: cordova.apache.org/contact
Closing.
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/693
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/87
Ping @shazron for a review.
@avishekcode have you signed an Apache ICLA?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/690
@maverickmishra response to the review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
Ping @infil00p for a review.
@Lazza have you signed an ICLA for Apache?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Cordova CI Build has one or more failures.
**Commit** -
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/130
@ghenry22 any updates on your testing?
On the one side, I am not super keen on adding undocumented functionality,
on the other, this already exists in iOS
---
If your
Please review and vote on this 4.4.0 iOS Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-12687
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-12687
The package
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/132
@shazron @jcesarmobile How does this relate to #134 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/133
Please stop using pull requests to ask for help. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
It is always nice to have, but not specifically required; sending a pr is
proof of the intent to contribute.
In this case the graphics are really just resized
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/135
This looks like a completely different plugin. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/138
This good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Do we need an ICLA signed for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/78
Two PRs for the same feature, wow! Thanks you two.
Have either of you signed an ICLA?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user macdonst commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/77
This PR is good to merge and we should look at removing reflection from the
rest of the plugin.
---
If your project is set up for it, you can reply to this email and have your
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103261864
--- Diff: src/android/StatusBar.java ---
@@ -164,4 +181,21 @@ private void setStatusBarBackgroundColor(final String
colorPref) {
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103260428
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true;
}
+
Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/77#discussion_r103258589
--- Diff: src/android/StatusBar.java ---
@@ -142,6 +142,23 @@ public void run() {
return true;
}
+
Github user stevengill commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/202
hey @gattex
sure! Do you have a issue number for this yet? if not, could you create one
at issues.cordova.io and share it here?
---
If your project is set up for it, you
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/92
No answer from reporter, will close this down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/62
@infil00p should we close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/73
I don't think we will be accepting this. Only a single-platform change,
setting to an arbitrary bit rate. At a minimum, this would have to be a part of
the spec across all
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-cli/pull/278
CB-12693 : Update cordova-cli docs for cordova config command with
descriptions and options
### Platforms affected
### What does this PR do?
Update cordova-cli
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
they are both device specific, and cordova specific
I see these as something that an app developer should be providing
themselves, unfortunately there is not an API for
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-vibration/pull/53
Cordova CI Build has completed successfully.
**Commit** -
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
Thanks for the feedback. I agree that it should go under the cordova
umbrella somewhere. I just wanted to show a working example in the PR.
We have an internal plugin in our
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Ping @purplecabbage @shazron for a quick review. Is having these microphone
images something we would want?
I am concerned that the images and configuration for this
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/149
Reporter has not responded in the JIRA thread. How should we proceed
@alsorokin ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/33
Thanks @filmaj.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/33
FYI I've filed [CB-12696](https://issues.apache.org/jira/browse/CB-12696)
to link to this.
---
If your project is set up for it, you can reply to this email and have your
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/53
CB-12695: fix jshint / double-varing
### Platforms affected
All - JS
### What does this PR do?
Fixes `npm test` failure due to double-definition of
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/30
No, @ktran13, it was not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-vibration/pull/52
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I can't find the issue in JIRA. At any rate, I don't think we should pull
this in right now, and I think that we should probably move this into the
android platform source in the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/43
This looks fine to me as well. Will close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/256
This PR looks to be commenting out a whole bunch of code and adding
incorrect properties (such as setting aspect to width).
We won't be accepting this.
---
If your project is
Github user dblood commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
Because the core issue behind this null pointer is threading, having a
automated test that would work consistently 100% of the time isn't possible and
a flaky test is a bad thing
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I'm not sure we can merge this PR in as it relies on a non-Apache plugin.
We would have to move that file provider plugin under the Cordova umbrella.
Thoughts @stevengill ?
---
If
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
Based on what I'm seeing here, it really shouldn't say "Camera cancelled"
because you're selecting an image from the gallery, not taking a picture. They
both should say "Selection
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/260
Good to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
What tests have you added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/18#discussion_r113055741
--- Diff: template_src/package.json ---
@@ -0,0 +1,11 @@
+{
+ "name": "hellocordova",
--- End diff --
actually, can
Github user bjomi commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
great! thanks for quick response @purplecabbage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ktran13 commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/30
does anyone know whether this feature was implemented?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ochakov commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/86
@patrickbussmann the workaround with the hook will create duplicate uses
line in AndroidManifest.xml if you have another plugin declaring the same uses
with required false.
---
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
cleaned up a few merge issues, this is now in master, thanks @cnspaha
Next the plugin will need to go thru the typical Apache vote process before
being pushed to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bjomi commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
@purplecabbage great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
there is nothing more that @ego7repo can do.
I am reviewing this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bjomi commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
@ego7repo +1. Please get this fix out now so that the plugin becomes usable
on iOS. Right now it isn't unfortunately.
---
If your project is set up for it, you can reply to
Github user ego7repo commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
Please push to NPM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
No. If you're a CLI user, you shouldn't notice the change once everything
is complete. This change
is for people who have to do some Android development to integrate some new
feature or write a custom
plugin or something.
Of course, we already have other problems with people who don't have
Dropping ANT support now seems like a good idea.
This overall sounds good to me. One question I have is how would this
affect users that have only the command-line tools installed, and not
a full Android studio setup? Does this approach preclude those users
from leveraging Cordova? I'm not sure
Hey
Since we've been running into numerous issues with Google updating their
tools already, I think it's time that we update the new project structure
to work with Android Studio more easily so that we can integrate JUnit
tests for plugins, Library Projects, Gradle dependencies and allow for
Github user ochakov commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/245
Yes, still happens on low RAM devices, e.g. Samsung S3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
81 matches
Mail list logo
