Nightly build #356 for cordova has succeeded!

2017-05-26 Thread Apache Jenkins Server
Nightly build #356 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/356/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-ios issue #313: CB-12856 - Skip CocoaPods check_reqs if on non-darwi...

2017-05-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/313 Array.includes failure on node 4 when on Windows. I will have to re-test everything again -- this means also that the check_reqs is not covered in the unit-tests (which do test on nodes 4 and 6)

[GitHub] cordova-ios issue #313: CB-12856 - Skip CocoaPods check_reqs if on non-darwi...

2017-05-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/313 Tested using ``` cordova platform add https://github.com/shazron/cordova-ios.git#CB-12856 cordova plugin add https://github.com/phonegap/phonegap-plugin-push.git --verbose ``` -

[GitHub] cordova-plugin-geolocation issue #28: CB-7754 - [Geolocation] Support Backgr...

2017-05-26 Thread kamendo
Github user kamendo commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/28 I tried > cordova plugin add https://github.com/apache/cordova-plugin-geolocation.git#master:src/ios/background-location but failed with this error: 'support f

[GitHub] cordova-ios issue #313: CB-12856 - Skip CocoaPods check_reqs if on non-darwi...

2017-05-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/313 Tested on macOS Sierra 10.12.5: - [X] CocoaPods not installed, should output error to install it - [X] CocoaPods not synced, should output error to `pod sync` - [X] Once installed, mad

[GitHub] cordova-browser issue #30: CB-12804 : manifest.json added to browser during ...

2017-05-26 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-browser/pull/30 @audreyso looks good. Is there a follow up issue to read the `icon` tag from config.xml and add it to the manifest? --- If your project is set up for it, you can reply to this email and hav

[GitHub] cordova-browser pull request #30: CB-12804 : manifest.json added to browser ...

2017-05-26 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-browser/pull/30 CB-12804 : manifest.json added to browser during create ### Platforms affected ### What does this PR do? manifest.json added to browser during create ###

[GitHub] cordova-node-xcode pull request #2: CB-12844 Update pbxProject.js

2017-05-26 Thread sruthakeerthikotla
Github user sruthakeerthikotla commented on a diff in the pull request: https://github.com/apache/cordova-node-xcode/pull/2#discussion_r118695621 --- Diff: lib/pbxProject.js --- @@ -1546,7 +1546,7 @@ function pbxShellScriptBuildPhaseObj(obj, options, phaseName) { obj.input