Re: [NOTICE] Intent on moving to Github

Thanks Carlos! Very useful information! On Tue, Jun 6, 2017 at 5:28 PM, Carlos Santana wrote: > ASF will allow it, other projects already showed interest and at ApacheCon > they made it public that they will allow it to any project > > My incubator project OpenWhisk is the

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/79 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

Github user imgx64 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/79 @filmaj Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/79 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user stalniy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120534419 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user stalniy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120533655 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user stalniy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120533184 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 @filmaj done! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Nightly build #367 for cordova has succeeded!

Nightly build #367 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/367/consoleFull - Jenkins for Apache Cordova

Re: [NOTICE] Intent on moving to Github

ASF will allow it, other projects already showed interest and at ApacheCon they made it public that they will allow it to any project My incubator project OpenWhisk is the first one to work out all the kinks For now let know everyone that wants write access, specially those that are repo owners

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120506321 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

Re: move common, fetch and serve to their own repo

no one make any commits to common, fetch or serve (in cordova-lib) until i'm done ripping it out please On Tue, Jun 6, 2017 at 3:29 PM, Filip Maj wrote: > Friendly reminder that we will have to update the CI scripts to handle > this now. I believe we are mid-transition away

[GitHub] cordova-ios issue #317: CB-12883 Add logging for malformed data

Github user rafael-chavez commented on the issue: https://github.com/apache/cordova-ios/pull/317 Done! @shazron --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [NOTICE] Intent on moving to Github

Yay! Hope ASF allows us to finally do this! On Tue, Jun 6, 2017 at 3:28 PM, Filip Maj wrote: > My one comment is OMG YISS! > > On Mon, Jun 5, 2017 at 6:41 PM, Shazron wrote: > > The Apache Cordova Project Management Committee (PMC) has consensus that > we

Re: move common, fetch and serve to their own repo

Friendly reminder that we will have to update the CI scripts to handle this now. I believe we are mid-transition away from cloudapp Jenkins to Travis/AppVeyor now (ping Alex Sorokin). On Tue, Jun 6, 2017 at 1:03 AM, Steven Gill wrote: > I've started moving cordova-common,

Re: [NOTICE] Intent on moving to Github

My one comment is OMG YISS! On Mon, Jun 5, 2017 at 6:41 PM, Shazron wrote: > The Apache Cordova Project Management Committee (PMC) has consensus that we > should move primary development of Apache Cordova to Github, from Apache's > servers (role would be reversed, Apache would

[GitHub] cordova-plugin-file-transfer pull request #150: CB-11534 This plugin should ...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/150#discussion_r120497208 --- Diff: plugin.xml --- @@ -30,6 +30,8 @@ https://issues.apache.org/jira/browse/CB/component/12320650 +

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120496517 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120496658 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath

[GitHub] cordova-ios issue #317: Add logging for malformed data

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/317 Thanks! One small thing to enable auto GH->JIRA tracking -- can you prefix the PR title with "CB-12883"? Thanks! I would do it myself but I don't have the karma (none of us committers do

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 @stalniy I'm happy to merge this in, but can you rebase your branch with latest master first? Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-docs issue #706: CB-12880: Remove Taco.tools from the homepage

Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/706 Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-docs pull request #706: CB-12880: Remove Taco.tools from the homepag...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request #318: CB-12887 - cordova run --list does not show v...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/318 CB-12887 - cordova run --list does not show virtual devices in iOS 11 ### Platforms affected self ### What does this PR do? Fix 'cordova run --list' not showing any

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120494584 --- Diff: README.md --- @@ -46,7 +46,7 @@ function onDeviceReady() { } ``` -Report issues with this plugin on the [Apache

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/79 LGTM. Can you rebase w/ latest master? I'll merge in then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-globalization pull request #57: Set language for code blocks ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-globalization issue #57: Set language for code blocks to add ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-globalization/pull/57 Thanks for the pull request @ihadeed! Merging in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Sweet, I'm down with merging this in. Small nit: if you could rebase w/ latest master and combine the commits into one that'd be fantastic! @infil00p any concerns from you on

[GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/561 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=h1) Report > Merging [#561](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr=desc) into

[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/380 I think this should be discussed on the list. There's upsides and downsides to this, and it could attract more developers to adopt JDK 7 and newer Java features. --- If your project is

[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/380 @infil00p so what's the plan here? Are these changes to readme/JDK requirements unfounded? Close this? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android pull request #382: CB-12859: document how to run the native ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #382: CB-12859: document how to run the native tests

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/382 Adjusted based on comments. Thanks y'all! Once tests pass I will merge in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request #707: Missing bracket

GitHub user dananos opened a pull request: https://github.com/apache/cordova-docs/pull/707 Missing bracket There is a missing bracket in the code example. I've just added it. Thanks. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 (hopefully this triggers the CI) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media issue #137: CB-12146 (android) Adding playAudioWhenScre...

Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/137 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

Github user darylldawn commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 @maxpaj works perfectly! thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

Github user maxpaj commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 Check out my branch here: https://github.com/maxpaj/cordova-plugin-media-capture --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-media-capture issue #65: CB-10180: (iOS) implement the 'quali...

Github user darylldawn commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/65 Hi, is this already merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

move common, fetch and serve to their own repo

I've started moving cordova-common, cordova-fetch and cordova-serve into their own repos. ISSUE: https://issues.apache.org/jira/browse/CB-11980 It is causing some extra jira notifications. Sorry about that! -Steve