Nightly build #370 for cordova has succeeded!

2017-06-09 Thread Apache Jenkins Server
Nightly build #370 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/370/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-ios pull request #318: CB-12887 - cordova run --list does not show v...

2017-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request #317: CB-12883 Add logging for malformed data

2017-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376: (ios) Fix bug wh...

2017-06-09 Thread ccorcos
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 CB-10376: (ios) Fix bug where WKWebView doesnt respect the KeyboardDisplayRequiresUserAction setting ### Platforms affected - iOS ### What does this PR do?

Proof-of-Concept: Studio Project Structure Cleanup

2017-06-09 Thread Joe Bowser
Hey I know that I've talked about this before, but I think that with the adoption of Kolton as a supported Android development language and with recent Gradle changes on the CLI, it's time to migrate our generated Android project structure to something a bit more modern so that we can support

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

2017-06-09 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/384 CB-11244: Studio project cleanup ### Platforms affected Android ### What does this PR do? Modernizes Android and makes it so we can do Modern Android Development

[GitHub] cordova-plugin-device-orientation issue #36: CB-12728: Device Orientation - ...

2017-06-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/36 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-device-motion issue #53: CB-12726: Device Motion - SUNSET

2017-06-09 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-motion/pull/53 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-device-orientation issue #36: CB-12728: Device Orientation - ...

2017-06-09 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/36 lgtm When we publish it next, we should also deprecate it in npm land. https://docs.npmjs.com/cli/deprecate --- If your project is set up for it, you can

[GitHub] cordova-plugin-device-motion issue #53: CB-12726: Device Motion - SUNSET

2017-06-09 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-device-motion/pull/53 lgtm When we publish it next, we should also deprecate it in npm land. https://docs.npmjs.com/cli/deprecate --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-device-motion pull request #53: CB-12726: Device Motion - SUN...

2017-06-09 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/53 CB-12726: Device Motion - SUNSET ### Platforms affected All ### What does this PR do? Add's deprecation notice to the repo ### What testing

[GitHub] cordova-plugin-device-orientation pull request #36: CB-12728: Device Orienta...

2017-06-09 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/36 CB-12728: Device Orientation - SUNSET ### Platforms affected All ### What does this PR do? Add's deprecation notice to the repo ###

[GitHub] cordova-browser issue #31: CB-12905: (linux) Fix issue with freezing after l...

2017-06-09 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-browser/pull/31 Also, I think you need to send this PR in the cordova-serve (https://github.com/apache/cordova-serve) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-browser pull request #31: CB-12905: (linux) Fix issue with freezing ...

2017-06-09 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/31#discussion_r121171981 --- Diff: node_modules/cordova-serve/src/exec.js --- @@ -29,7 +29,15 @@ var child_process = require('child_process'), module.exports =

[GitHub] cordova-browser pull request #31: CB-12905: (linux) Fix issue with freezing ...

2017-06-09 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/31#discussion_r121171609 --- Diff: node_modules/cordova-serve/src/exec.js --- @@ -29,7 +29,15 @@ var child_process = require('child_process'), module.exports =

[GitHub] cordova-browser pull request #31: CB-12905: (linux) Fix issue with freezing ...

2017-06-09 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/31#discussion_r121171521 --- Diff: node_modules/cordova-serve/src/exec.js --- @@ -29,7 +29,15 @@ var child_process = require('child_process'), module.exports =

[GitHub] cordova-browser pull request #31: CB-12905: (linux) Fix issue with freezing ...

2017-06-09 Thread paymicro
GitHub user paymicro opened a pull request: https://github.com/apache/cordova-browser/pull/31 CB-12905: (linux) Fix issue with freezing after launching the browser In Linux, the callback is not called until the process terminates. If the error is not caused within 2 seconds,

[GitHub] cordova-plugin-inappbrowser pull request #99: inAppBrowser custom applicatio...

2017-06-09 Thread steinwelberg
Github user steinwelberg commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r121070906 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *) toolbarPosition

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-06-09 Thread uloco
Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 You should also keep the last line if it's empty in both, `package.json` and `config.xml`. The [POSIX

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

2017-06-09 Thread uloco
Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 @stevengill Go for it. I don't have an account there... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not