Github user LightZam commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/199
@filmaj i had done the job for rebase latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Nightly build #376 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/376/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/376/consoleFull
-
Jenkins for Apache Cordova
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
Please close this PR, I consider it abandoned and it does not seem to serve
any purpose for Cordova currently.
---
If your project is set up for it, you can reply to this
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38
Two issues:
1. The checklist for PRs was not adhered to
2. This fails CI
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/708
Nope, it seems there are some mixed up deletions ) from a quick glance.
This is the data that shows up on
https://cordova.apache.org/docs/en/latest/guide/support/index.html right?
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/708
@purplecabbage is the removal of win8 here ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/562
I think we should get CI passing before merging. I'm looking into e2e
failures now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/562
We'd have to be OK with either removing the e2e tests from standard CI
until we finish the chip-away, or be OK with CI failing for a while. Both are
tough calls.
---
If your project is set up
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/562
Cheers. The CI is failing due to the end to end tests failing (also JSHint,
but that's minor, and I think JSHint in particular is on its way out anyways).
I will keep chipping away at
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122334506
--- Diff: src/util/alias.js ---
@@ -0,0 +1,27 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25
@ccorcos guide available here
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/562
This all looks great to me, good work.
I would like to move forward with this asap as it is big, and affects a lot
of different areas.
Let's keep our merge conflict exposure low
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122330032
--- Diff: src/util/alias.js ---
@@ -0,0 +1,27 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/199
I think this one's good to merge. @LightZam can you rebase w/ latest master
please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122284211
--- Diff: spec-cordova/platform/index.spec.js ---
@@ -0,0 +1,181 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user kerrishotts commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122233685
--- Diff: spec-cordova/platform/index.spec.js ---
@@ -0,0 +1,181 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r14237
--- Diff: spec-cordova/platform/addHelper.spec.js ---
@@ -0,0 +1,515 @@
+/**
--- End diff --
Sort of. The old tests I `xdescribe`d them
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r13046
--- Diff: src/cordova/platform.js ---
@@ -1,769 +0,0 @@
-/**
--- End diff --
Sure do! Basically, each module should have unit tests. A
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122219931
--- Diff: spec-cordova/platform.spec.ios.js ---
@@ -1,137 +0,0 @@
-/**
--- End diff --
Yes:
Github user kosssi commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/210
can you merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user LightZam commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/199
@stevengill could you assign new reviewer for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
22 matches
Mail list logo
