Nightly build #436 for cordova has failed

2017-07-23 Thread Apache Jenkins Server
Nightly build #436 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/436/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/436/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-screen-orientation issue #17: Update package.json

2017-07-23 Thread luckylooke
Github user luckylooke commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/17 I am sorry, this has to be some mistake on my side.. I cannot recall how I came into this. 🤔 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-screen-orientation pull request #17: Update package.json

2017-07-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-screen-orientation issue #17: Update package.json

2017-07-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/17 This plugin does not use anything from the ionic ecosystem. Cordova does not depend on ionic - perhaps the other way around is true (ionic depends on cordova). I will close

[GitHub] cordova-plugin-file pull request #211: CB-6938: (fix) on iOS, copyTo should ...

2017-07-23 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/211#discussion_r128926981 --- Diff: src/ios/CDVLocalFilesystem.m --- @@ -551,8 +551,13 @@ - (void)copyFileToURL:(CDVFilesystemURL *)destURL withName:(NSString *)newName f

[GitHub] cordova-plugin-device issue #67: Fixes the NPM build and much more things [N...

2017-07-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device/pull/67 I see lots of problems with this PR: 1. The travis build fails, for starters. 2. Why eliminate sauce labs testing? That is a core component of the end-to-end testing for

Re: Highlighting top issues w/ JIRA boards and labels

2017-07-23 Thread Filip Maj
Thanks for tweaking your workflow Shaz. FWIW I like the fixVersion field, and I don't think it's incompatible with the backlog/*-next labels - feels like the two can live side-by-side. Taking a look at the board configuration, it looks like only those blessed by Apache Infra to have JIRA Karma

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-07-23 Thread Filip Maj
By the way I think the details around how to handle INTEGRATED plugins is the last discussion point left to clarify for the plugin audit / core plugin roadmap next steps. After that we can start cranking on the plugins and axing/updating/integrating them. On Sun, Jul 23, 2017 at 10:57 AM, Filip

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-07-23 Thread Filip Maj
Thanks for the breakdown. I'll move discussion on this topic into the issue you linked to. On Sat, Jul 22, 2017 at 11:30 PM, Shazron wrote: > Thanks for all this work Fil! > > Let me clarify https://issues.apache.org/jira/browse/CB-12903 - this task > is to list integration

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-23 Thread russaa
Github user russaa commented on the issue: https://github.com/apache/cordova-android/pull/396 @infil00p I was not aware of this patch (I believe it is CB-12065 #387). I guess it would solve the issue for Windows right now -- but does not address the PATH problem (for Windows)

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #228: CB-13035 fix Create issue Lin...

2017-07-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread jcesarmobile
Github user jcesarmobile closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread jcesarmobile
GitHub user jcesarmobile reopened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 CB-12586 (iOS) fix method hide doesn't work ### Platforms affected iOS ### What does this PR do? Fix hide method self.viewController wasn't

[GitHub] cordova-plugin-inappbrowser pull request #229: CB-12586 (iOS) fix method hid...

2017-07-23 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/229 CB-12586 (iOS) fix method hide doesn't work ### Platforms affected iOS ### What does this PR do? Fix hide method self.viewController wasn't

[GitHub] cordova-plugin-inappbrowser pull request #228: CB-13035 fix Create issue Lin...

2017-07-23 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/228 CB-13035 fix Create issue Link ### Platforms affected README.md ### What does this PR do? Fix the JIRA link on the README.md ### What

Re: Highlighting top issues w/ JIRA boards and labels

2017-07-23 Thread Shazron
Thanks Fil! I like this organization and consistency (especially for getting new contributors up to speed). As an example, this is what I've done with my existing boards. I have 3: cordova-ios@4.4.1 (labelled ios-next, backlog) cordova-ios@4.5.0 (labelled backlog) cordova-ios@5.0.0 (labelled

Re: [CORE PLUGINS][DISCUSS] Roadmap 2017

2017-07-23 Thread Shazron
Thanks for all this work Fil! Let me clarify https://issues.apache.org/jira/browse/CB-12903 - this task is to list integration issues with respect to users trying to install older versions of the plugin. A lot of this can be mitigated with the engines tag/key but we haven't been using it for the

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-23 Thread aminul-technext
Github user aminul-technext commented on the issue: https://github.com/apache/cordova-android/pull/396 Guys I need this pr to be merged. I am developing on Ubuntu 16.04 and installed Android Studio. The problem is `check_reqs.js` never found my Android Studio. And another