[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...

2017-09-07 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 ping @shazron --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands

[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...

2017-08-23 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Alright @shazron made those changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-08-22 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron please check out my new PR https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference

2017-08-22 Thread ccorcos
Github user ccorcos closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-wkwebview-engine pull request #42: Dynamic swipe back enabled...

2017-08-22 Thread ccorcos
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Dynamic swipe back enabled preference ### Platforms affected ### What does this PR do? ### What testing has been done on this change

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-07-14 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron does this PR have any chance of making it in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-06-21 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 lol. would you mind making a ticket for this? I can't seem to get it to load! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-06-20 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron is JIRA broken? My browser says failed to connect: iled to connect to issues.apache.org port 443: Connection refused --- If your project is set up

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-06-19 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Hmm. Is JIRA down? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376, CB-12037: (ios) ...

2017-06-19 Thread ccorcos
Github user ccorcos closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-19 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @cjpearson really cool. I'll do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference

2017-06-14 Thread ccorcos
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 Dynamic Swipe Preference This PR lets you dynamically change whether or not you can swipe navigation using `window.WkWebView.allowsBackForwardNavigationGestures(boolean

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-13 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @SeanHub here's what I've learned so far: - you can call `.focus()` so long as its in the same tick as a user action. For example, you can call `.focus

[GitHub] cordova-plugin-wkwebview-engine issue #25: CB-12317: Allow to configure navi...

2017-06-13 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/25 @shazron @fkoester is there a way to dynamically change this preference? I see theres an `updateWithInfo` function but I don't know how to call it. https

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-12 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 I see. But I figured that why we test on the next iOS before it comes out. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-wkwebview-engine issue #37: CB-10376, CB-12037: (ios) Fix bug...

2017-06-12 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 @shazron @stevengill any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376: (ios) Fix bug wh...

2017-06-09 Thread ccorcos
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37 CB-10376: (ios) Fix bug where WKWebView doesnt respect the KeyboardDisplayRequiresUserAction setting ### Platforms affected - iOS ### What does this PR do