GitHub user cmarcelk opened a pull request:
https://github.com/apache/cordova-plugins/pull/19
clarify wording on browser intent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmarcelk/cordova-plugins wording
Alternatively you
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-android/pull/130#issuecomment-61550705
One of my concerns looking at the changes is that it would leave a new tmp
directory laying around on the filesystem everytime one was needed, but looking
at
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-android/pull/131#issuecomment-60624161
Pull request merged. Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/53#discussion_r18838799
--- Diff: docs/versioning-and-release-strategy.md ---
@@ -19,17 +19,100 @@
#
-->
-# Versioning and Release Strat
Github user cmarcelk closed the pull request at:
https://github.com/apache/cordova-coho/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/53#discussion_r18835781
--- Diff: docs/versioning-and-release-strategy.md ---
@@ -19,17 +19,100 @@
#
-->
-# Versioning and Release Strat
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/53#discussion_r18834641
--- Diff: docs/versioning-and-release-strategy.md ---
@@ -19,17 +19,100 @@
#
-->
-# Versioning and Release Strat
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/53#discussion_r18834684
--- Diff: docs/versioning-and-release-strategy.md ---
@@ -19,17 +19,100 @@
#
-->
-# Versioning and Release Strat
GitHub user cmarcelk opened a pull request:
https://github.com/apache/cordova-coho/pull/53
CB-7774 capture updates from Hangout and mailing list
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmarcelk/cordova-coho CB-7774
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58383730
If folks are OK with bumping versions numbers on a respin, I'm OK with
publishing to npm with the rc tag.
Due to the number of respins I did, I felt b
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58247365
I'd suggest that no RCs be pushed to the real npm registry. If there is a
respin, then you can't reuse the version number. I think that is more
prob
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18466054
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" in
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18420124
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" in
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18420090
--- Diff: createmobilespec/createmobilespec.js ---
@@ -413,6 +413,20 @@ function installPlugins() {
" in
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/45#issuecomment-55283012
Merged. Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-docs/pull/221#issuecomment-49392139
Thanks for the contribution! Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/66#issuecomment-44679399
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/65#issuecomment-44645617
Merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cmarcelk closed the pull request at:
https://github.com/apache/cordova-docs/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-docs/pull/205#issuecomment-43551933
Good point. I updated it to mention nave.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user cmarcelk opened a pull request:
https://github.com/apache/cordova-docs/pull/205
CB-6680 Clarify instructions for installing via npm
Here's my proposal regarding sudo.
You can merge this pull request into a Git repository by running:
$ git pull https://githu
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-docs/pull/194#issuecomment-42484546
There are 4 different commits in this pull request. Do you want the whole
pull request to be disregarded? If so, please close the pull request.
Optionally, I can
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-docs/pull/201#issuecomment-42548695
Looks like the code for these docs has already been merged in. Bryan /
Sergey, is there anything remaining here before doing a merge?
---
If your project is set
Github user cmarcelk closed the pull request at:
https://github.com/apache/cordova-docs/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/28#issuecomment-42966726
This has been merged. Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-docs/pull/148#issuecomment-42958017
I believe this has changed enough that it should be revisited from scratch.
So I will close this pull request.
---
If your project is set up for it, you can
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/60#issuecomment-41714556
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/59#issuecomment-41712597
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/9#issuecomment-41613038
I would suggest modifying the existing APIs instead of creating new ones,
assuming they have consistent signatures across platforms. And if changing
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41211898
I tried to merge this, but it didn't merge cleanly. Conflicts in 3 files.
Could you rebase your branch on master so it will merge cleanly?
---
If
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11875752
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,163 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11874991
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,163 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11874862
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,163 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11817386
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,197 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11817282
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,197 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11817216
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,197 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11816716
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,197 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r1181
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,197 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11816596
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,197 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11641446
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11640926
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607031
--- Diff: createmobilespec/createmobilespec.sh ---
@@ -0,0 +1,3 @@
+#!/bin/bash
--- End diff --
All files should include the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606853
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606571
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606359
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
Github user cmarcelk commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11604897
--- Diff: createmobilespec/createmobilespec.js ---
@@ -17,99 +16,215 @@
KIND, either express or implied. See the License for the
Github user cmarcelk closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/53#issuecomment-38924229
It would be helpful if you put your real name in your github profile, so we
could easily verify that you completed an ICLA. I had to search the mailing
list
GitHub user cmarcelk opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/54
CB-6372 Port createmobilespec from bash to node.
This is a straight-up port with no change in function. This is the initial
work. Improvements and expansion can come later.
You can
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-cli/pull/126#issuecomment-38831161
In a broad sense this looks reasonable.
In the config.xml, why is there width and height attributes when using
cdv:platform="android" and cdv:den
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/18#issuecomment-37535686
Merged into dev branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
51 matches
Mail list logo
