[GitHub] cordova-plugin-battery-status issue #38: CB-11256: (ubuntu) Qt API change br...

2016-09-08 Thread david-barth-canonical
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/38 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser issue #174: CB-3360 Fix Oxide version & support ...

2016-09-08 Thread david-barth-canonical
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/174 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request #610: CB 11328 - Ubuntu platform documentation upd...

2016-06-08 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/610 CB 11328 - Ubuntu platform documentation update Update the platform guide to reflect the status as of cordova-ubuntu@4.3.4 You can merge this pull request into a Git repository

[GitHub] cordova-docs pull request: Cordova Ubuntu 4.3.4 release announceme...

2016-05-26 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/607 Cordova Ubuntu 4.3.4 release announcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

2016-05-24 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-docs/pull/497#issuecomment-221223223 Yeah, probably. I'll redo an announcement for 4.3.4 --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

2016-05-24 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-docs/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

2016-05-12 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

2016-05-12 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/35 CB-11256 (was Fix due to Qt SystemInfo API updates) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

2016-05-09 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

2016-05-09 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/438 Fix plugin platform_www & cordova_plugins.json copy You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cor

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

2016-02-10 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/497 Add Cordova Ubuntu 4.3.3 blog post Blog post to announce cordova-ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3

2016-01-28 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3

2016-01-28 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/21 Set of fixes for Cordova-Ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu master

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.2 blog post

2016-01-08 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/452 Add Cordova Ubuntu 4.3.2 blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs cordova

[GitHub] cordova-ubuntu pull request: CB-10119 - Can't install click chroot...

2015-12-17 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/20 CB-10119 - Can't install click chroot 14.10 Fix for CB-10119, switching the default framework to 15.04 Also a fix for check_reqs which was referencing a function tha

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

2015-12-03 Thread david-barth-canonical
Github user david-barth-canonical commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/349#discussion_r46569876 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,54 @@ function toCamelCase(str) { }).join

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-12-02 Thread david-barth-canonical
Github user david-barth-canonical commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/294#discussion_r46471716 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,51 @@ function toCamelCase(str) { }).join

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

2015-12-02 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/349 Cb 9590 - Ubuntu support for the new plugin naming convention Re-opening the pull request with hopefully a better fix that can handle all situations. You can merge this pull

[GitHub] cordova-lib pull request: Cb 9618 - Icon parameter should not be r...

2015-12-02 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/347 Cb 9618 - Icon parameter should not be relative to the www directory on Ubuntu This patch fixes a long standing issue, whereby the icon parameter in the app manifest was

[GitHub] cordova-ubuntu pull request: Cordova-Ubuntu Platform Release 4.3.1...

2015-11-19 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/19 Cordova-Ubuntu Platform Release 4.3.1 From the RELEASENOTES.md * default icon name www/img/logo.png * add defaut icon parameter to config.xml * use QUrl

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

2015-11-13 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

2015-11-13 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

2015-11-12 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/18 Cb 9694 - Add support for HTTP urls The cordova-ubuntu container currently does not support loading the app from a network URL, only local file URLs. This prevents features

[GitHub] cordova-ubuntu pull request: check if content src points to a url ...

2015-11-12 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-11-03 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772 I have update the pull request to add support for taking the class name from the plugin.xml file. For plugins using one of the 2 existing naming

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-10-16 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166 ok, i understand the problem now. In particular, the code to guess the classname is nice, but other platforms resort to encapsulating this

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

2015-10-15 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/16 add defaut icon parameter to config.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-10-15 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148342742 It does work on my system at least. I run this branch along with my other 3 pull requests, but I don't think they have an influence on the p

[GitHub] cordova-ubuntu pull request: check if content src points to a url ...

2015-09-30 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/14 check if content src points to a url or local file You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-23 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241 Yes, makes sense. Icon management needs more tweaks, but this way it will work better already Thanks for the review. --- If your project is set up

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-07 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/299 icon parameter should not be relative to the www directory on Ubuntu You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova

[GitHub] cordova-lib pull request: Cb 9618

2015-09-07 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Cb 9618

2015-09-07 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/298 Cb 9618 Patch to change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore. You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-09-07 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-138310314 It does work both with old style plugin names, like "org.apache.cordova.battery-status" and new style names "cordova-plugin-media-capt

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-09-01 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/294 CB-9590 - Ubuntu support for the new plugin naming convention This patch allows ubuntu users to add plugins using the new naming convention and build properly. This also leaves