[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

2017-06-07 Thread dellagustin
Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 @ghenry22, I'm interested on using this feature as well in android, but I think some adaptations on the code are needed, can you take a look a my comments? --- If your project

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

2017-06-07 Thread dellagustin
Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 @filmaj @AshishMehra I created pull request https://github.com/apache/cordova-plugin-media/pull/142 to document the existing setRate method for iOS platform. --- If your project

[GitHub] cordova-plugin-media pull request #142: documentation: setRate method

2017-06-07 Thread dellagustin
GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/142 documentation: setRate method ### Platforms affected iOS ### What does this PR do? Adds documentation for the setRate method ### What testing

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120737624 --- Diff: src/android/AudioPlayer.java --- @@ -271,7 +272,6 @@ public void stopRecording(boolean stop

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120745011 --- Diff: src/android/AudioPlayer.java --- @@ -532,6 +532,27 @@ public void setVolume(float volume

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r119812195 --- Diff: www/Media.js --- @@ -173,7 +173,9 @@ Media.prototype.setRate = function(rate) { if (cordova.platformId === 'ios

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

2017-06-07 Thread dellagustin
Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 This pull request replaces https://github.com/apache/cordova-plugin-media/pull/140/commits/5e6cfb628f7a2e9d1a867ea223dfd7fd6212734f I had some mess with the commits

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

2017-06-07 Thread dellagustin
GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/141 Fixed link to issue tracker ### Platforms affected none ### What does this PR do? Fix the link to the issue tracker. The component Plugin Media

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

2017-06-07 Thread dellagustin
Github user dellagustin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120577449 --- Diff: README.md --- @@ -46,7 +46,7 @@ function onDeviceReady() { } ``` -Report issues with this plugin

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

2017-06-03 Thread dellagustin
GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/140 Fixed the link to report issues Past list was resulting in error: The value 'Plugin Media' does not exist for the field 'component'. No issue created because