[GitHub] cordova-docs pull request #732: CB-13284: Slackin.js on docs fails to load d...

2017-09-17 Thread devgeeks
GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-docs/pull/732 CB-13284: Slackin.js on docs fails to load due to insecure response ### Platforms affected Docs ### What does this PR do? Changed location of slackin.js

[GitHub] cordova-docs pull request #731: [CB-13283] Fetching of download counts fails...

2017-09-14 Thread devgeeks
GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-docs/pull/731 [CB-13283] Fetching of download counts fails on plugins.cordova.io ### Platforms affected Docs ### What does this PR do? Just before fetching the download

[GitHub] cordova-docs pull request #728: CB-13025 Remove use of React in plugins.cord...

2017-09-12 Thread devgeeks
GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-docs/pull/728 CB-13025 Remove use of React in plugins.cordova.io ### Platforms affected Docs ### What does this PR do? Switches https://plugins.cordova.io from React

[GitHub] cordova-docs pull request #703: CB-12770: revise security documentation

2017-05-22 Thread devgeeks
Github user devgeeks commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/703#discussion_r117873777 --- Diff: www/docs/en/dev/guide/appdev/security/index.md --- @@ -27,69 +27,155 @@ description: Information and tips for building a secure application

[GitHub] cordova-docs pull request #703: CB-12770: revise security documentation

2017-05-22 Thread devgeeks
Github user devgeeks commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/703#discussion_r117873392 --- Diff: www/docs/en/dev/guide/appdev/security/index.md --- @@ -27,69 +27,155 @@ description: Information and tips for building a secure application

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215812203 +1 for option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215697044 Well, it certainly works as advertised with the PrivacyScreenPlugin, anyway. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...

2016-04-29 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215685335 Nice, I'll try to have a look at this as well. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

2016-04-11 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-docs/pull/575#issuecomment-208684628 Looks nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-cli pull request: Simplify cordova CLI readme

2016-03-14 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-cli/pull/240#issuecomment-196574142 The help from the CLI itself only says: ``` --template=<PATH|NPM PACKAGE|GIT URL> ... use a custom template located locally, in NPM, or

[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...

2016-02-16 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184856505 LGTM. That third layer of binding always seemed confusing. :+1: --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-22 Thread devgeeks
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-ios/pull/167#issuecomment-142491934 Doesn't that completely opt out of "Slide Over and Split View" ? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cordova-android pull request: CB-9496 removed permissions added fo...

2015-08-16 Thread devgeeks
GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-android/pull/206 CB-9496 removed permissions added for crosswalk These would better live in the actual crosswalk plugin https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview